Age | Commit message (Collapse) | Author |
|
Apart from it never being initialized, note that m_status
is never set to 1, so the only path that references this
class can't be reached.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1537103002 .
|
|
R=thestig@chromium.org, dml@google.com
BUG=pdfium:327
Review URL: https://codereview.chromium.org/1536113002 .
|
|
BUG=pdfium:329
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1529173005 .
|
|
An email address contains user name part and host name part.
User name allows dash or underscore, but not leading/ending/double
period. Host name doesn't allow leading/ending/double
period either.
BUG=489107
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1530763005 .
|
|
It looks like an key length of 0 was incorrectly assumed to
denote an free entry.
Fixes a memory leak in FPDFViewEmbeddertest.Crasher_451830 due to values with
empty keys being incorrectly overwritten.
R=tsepez@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1534953002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1534003002 .
|
|
- Remove unused Clear() method.
- Replace Create() with actual ctors.
- Avoid const casts.
- Protect members.
- Add missing const in adjacent code.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1536623004 .
|
|
Also fix a newly introduced override warning.
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1532723003 .
|
|
While reading free entries in v4 cross reference table, changing the
start_objnum caused crossref table built wrong.
BUG=569795
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1527823003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1525853003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1520063002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1512763013 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1522283002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1528743002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1521563002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1514283002 .
|
|
TBR=thestig@chromium.org
BUG=566179
Review URL: https://codereview.chromium.org/1524983002 .
|
|
BUG=566179
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1523523002 .
|
|
BUG=447331
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1514093002 .
|
|
BUG=pdfium:326
R=dml@google.com
Review URL: https://codereview.chromium.org/1521543002 .
|
|
Also clean up while we're here.
BUG=557223
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1512833008 .
|
|
Missed some conversions in an ifdef mac block.
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1511413008 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1520643002 .
|
|
These are synonyms for CFX_Matrix.
Nothing but sed and manual deletion of 2 #defines in
fpdf_parser.h and fx_coordinates.h
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1513363002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1507043004 .
|
|
BUG=pdfium:298
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1496703005 .
|
|
BUG=452793, 561478
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1511613005 .
|
|
BUG=452793,561478
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1512873002 .
Review URL: https://codereview.chromium.org/1508343004 .
|
|
I didn't go whole hog and replace these with std::vector,
but in the mean time, it is silly to cast a typedef for
a template instantiated against void* when we can just
instantiate the template against the actual type.
The ones that remain are actual heterogeneous arrays with
wacky casting.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1518593002 .
|
|
Broke chrome bindings.
This reverts commit c3e4ae5fe5067723b58a2029a95c6411c92bed15.
R=thestig@chromium.org, tsepez@chromium.org
BUG=567485
Review URL: https://codereview.chromium.org/1511773002 .
|
|
The root cause is that FXFONT_SUBST_EXACT is wrongly
set even no any subset font was found. It causes
m_bCIDIsGID to be wrongly set as TRUE in CPDF_CIDFont::_Load().
BUG=534945
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1502083002 .
|
|
Loosen a check for earlier version of PDF files. When the bytes with
specified length are followed by 'endstream' keyword, even if there is
no EOL marker before the keyword, it signals the end of stream.
BUG=551258
R=jun_fang@foxitsoftware.com, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1499433002 .
|
|
R=tsepez@chromium.org, jun_fang@foxitsoftware.com
BUG=566179
Review URL: https://codereview.chromium.org/1504513002 .
|
|
RebuildCrossRef function returns false when we can not find file trailer
or any indirect object. This serves as a basic file format checking.
BUG=pdfium:215
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1476163002 .
|
|
BUG=pdfium:288
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1476173003 .
|
|
(cherry picked from commit 8d89e65897d8b6cf7899e7a82d9d381c3ad327cb)
(cherry picked from commit c70b19aad245fb1ed39bf8c264d991555f4c5a58)
BUG=pdfium:275
TBR=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1473753004 .
|
|
Precursor to making fpdf_text_int.cpp match cleanly.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1477433006 .
|
|
- remove redundant alloc in fx_codec_jpx_unittest.cpp
- free memory allocated by HexDecode calls in fpdf_parser_decode_unittest.cpp
BUG=PDFium:239
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1467183006 .
|
|
It's not required on master, but it costs very little and
makes XFA line up more closely. Also make InitFTLibrary()
public for the same reasons.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1475643003 .
|
|
Also change the copy ctor to take a const ref.
BUG=560520
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1472113002 .
|
|
This matches the type of the corresponding |CFX_DIBSource::m_Pitch|,
where integer overflow is checked for FX_DWORD. This change is
propagated to many other places.
Also, check for integer overflow in |CCodec_RLScanlineDecoder::Create|
during the calculation of |m_Pitch| since it aligns to 4 bytes while
overflow was was previously checked without this alignment.
R=tsepez@chromium.org, thestig@chromium.org
BUG=555784
Review URL: https://codereview.chromium.org/1460033002 .
|
|
R=jun_fang@foxitsoftware.com, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1458633004 .
|
|
Using Chromium's clang + build options, there's more override warnings.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1453643002 .
|
|
If jpeg_read_scanlines() ends up calling the error callback, we longjmp
into some undefined state.
BUG=558840
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1463563003 .
|
|
It's unused on master, and on XFA, directly calling
SetIdentity() is clearer to the reader anyways.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1459243002 .
|
|
This weeks version, mostly whitespace.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1466503002 .
|
|
It was breaking the Windows Clang build.
BUG=82385
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1459723005 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1452843005 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1456823002 .
|
|
Instead of taking a const pointer, and then casting away the const-ness.
Also remove similar, but dead CPDF_InterForm methods.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1456763003 .
|