summaryrefslogtreecommitdiff
path: root/core
AgeCommit message (Collapse)Author
2016-01-14Loose checking for trailer's size fieldWei Li
Although trailer's size value is required by spec, other readers such as Acrobat or libpoppler can handle without it. Loose up the check to be more tolerant. BUG=pdfium:213 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1582193002 .
2016-01-14Correct the way to count pages and to avoid infinite loopWei Li
BUG=pdfium:360 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1585823003 .
2016-01-13Fix another invalidated iterator issue while traversing CPDF_Dictionary.Oliver Chang
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1582903004 .
2016-01-13Fix some iterator invalidation issues while traversing CPDF_Dictionary.Oliver Chang
Also fixes a potential issue in CPDF_Dictionary::ReplaceKey. R=thestig@chromium.org BUG=577030 Review URL: https://codereview.chromium.org/1582963003 .
2016-01-13Do not use invalidated std::map::iterators in PDF_ReplaceAbbr().Lei Zhang
Avoid invalidating iterators by deferring the std::map operations. Also remove unused PDF_ReplaceFull(). BUG=577030 R=ochang@chromium.org Review URL: https://codereview.chromium.org/1581963004 .
2016-01-13Fix out of bound access in CPDF_Parser::ParseIndirectObject().Lei Zhang
This regressed in commit f6dafc9. BUG=576915 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1582763002 .
2016-01-13Use the compiler to type check DocAvailStatus return values.Lei Zhang
R=jun_fang@foxitsoftware.com Review URL: https://codereview.chromium.org/1575363007 .
2016-01-12Use std::map in CPDF_IndirectObjectsTom Sepez
Rename to CPDF_IndirectObjectHolder R=thestig@chromium.org Review URL: https://codereview.chromium.org/1576113003 .
2016-01-11Fix an infinite loop parsing in CPDF_SyntaxParser::GetObject()Wei Li
CPDF_SyntaxParser::GetObject() may enter into an infinite loop when a signature dictionary doesn't have 'Contents' field. Add a check to avoid that. BUG=pdfium:344 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1575833004 .
2016-01-11Fix an uninitalized read in FPDFText_GetFontSize().Lei Zhang
BUG=pdfium:346 R=jun_fang@foxitsoftware.com Review URL: https://codereview.chromium.org/1578543002 .
2016-01-11Tidy up shading patternsTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1570873005 .
2016-01-11Use std::map as CPDF_Dictionary's underlying store.Oliver Chang
Replaces CFX_CMapByteStringToPtr. XFA still uses CFX_CMapByteStringToPtr so it's not completely removed just yet. Adds begin()/end() to CPDF_Dictionary and removes the GetStartPos()/GetNextElement() functions to traverse the dictionary. Callers are changed accordingly. AddValue() is also removed. R=tsepez@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/1541703003 .
2016-01-08Switch most min/max macros to std::min/max.Lei Zhang
Fix lint errors along the way. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1567343002 .
2016-01-08IWYU in core/src/fpdfapi/fpdf_page/pageint.h.Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1572733002 .
2016-01-08Use unique_ptr in fpdf_page/.Tom Sepez
Make m_InternalStage an enum. Use safe types to detect overflow. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1568373003 .
2016-01-08Remove a bunch of dead code.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1567333003 .
2016-01-08Fix infinite loop caused by parsing same indirect objectsWei Li
BUG=pdfium:343 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1569343002 .
2016-01-08IWYU fix after commit c5a8933.Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1570973002 .
2016-01-08Endless tidying in pageint.hTom Sepez
Remove unused enum. Don't begin struct names with underscore. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1570133004 .
2016-01-08Clean up misc nits found while fixing bugs.Lei Zhang
Some bits regressed in commit 338805f. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1544963002 .
2016-01-07Make m_pStockMap a real map.Tom Sepez
Remove unused m_pContrastRamps. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1564783003 .
2016-01-07Cleanup includes, comments, and unused codeWei Li
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1563673002 .
2016-01-06Change CPDF_SyntaxParser::GetNextWord() to not pass by non-const ref.Lei Zhang
Change the internal version to GetNextWordInternal(). R=weili@chromium.org Review URL: https://codereview.chromium.org/1558083002 .
2016-01-05Replace CPDF_SortObjNumArray with a std::set.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1566553002 .
2016-01-05Remove header files that only have includes.Lei Zhang
Also do some cleanups in affected files. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1552583002 .
2016-01-05Fix a few uses of default arguments.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1555293002 .
2016-01-05Fix an infinite loop in CPDF_Parser::RebuildCrossRef().Lei Zhang
BUG=pdfium:325 R=weili@chromium.org Review URL: https://codereview.chromium.org/1543043003 .
2016-01-05Make more CPDF_Parser method const.Lei Zhang
R=weili@chromium.org Review URL: https://codereview.chromium.org/1549103002 .
2016-01-05Exit infinite loops for cross reference loadingWei Li
When cross reference sections form a loop, our code will enter an infinite loop. Add detection and exit code for v4 cross reference loading. V5 loading was done previously. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1558093002 .
2016-01-04Remove CPDF_Creator::m_ObjectSize, it's never read from.chromium/2615chromium/2614chromium/2613Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1543413002 .
2015-12-29Fix partial information printed with blank window covering the centerchromium/2612chromium/2611chromium/2610chromium/2609chromium/2608chromium/2607Jun Fang
BUG=482206 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1551563002 .
2015-12-29Change the generation number from 65536 to 65535 in the free entry of ↵Jun Fang
cross-reference table BUG=pdfium:342 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1550753002 .
2015-12-24Fix another regression from commit f6dafc9.Lei Zhang
TBR=weili@chromium.org Review URL: https://codereview.chromium.org/1548963004 .
2015-12-24Switch from nonstd::unique_ptr to std::unique_ptr.Lei Zhang
R=thakis@chromium.org Review URL: https://codereview.chromium.org/1547833002 .
2015-12-24Call CheckLinearizedFirstPage() when loading the first linearized page.chromium/2602Lei Zhang
Otherwise CheckLinearizedFirstPage() has no other callers. BUG=pdfium:330 R=jun_fang@foxitsoftware.com Review URL: https://codereview.chromium.org/1543193002 .
2015-12-24Fix crash from commit f6dafc9.Lei Zhang
BUG=571752 TBR=weili@chromium.org Review URL: https://codereview.chromium.org/1549073002 .
2015-12-24Fix failed JPX image renderingJun Fang
BUG=pdfium:338 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1549043003 .
2015-12-22IWYU fix for commit ba2586d2c0a5.chromium/2601chromium/2600Lei Zhang
TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1545823002 .
2015-12-22Start using allowed C++11 features.Lei Zhang
R=dml@google.com, thakis@chromium.org Review URL: https://codereview.chromium.org/1544923002 .
2015-12-22Revert "Cleanup: Remove unused CFX_PSRenderer and various encoders it used."Lei Zhang
This reverts commit 2d63eaaa39bb3d402c658b2a6e0eae50a30f1d89. Broke the Windows build, though it is likely the code is unused on Windows too. Review URL: https://codereview.chromium.org/1540993004 .
2015-12-22Cleanup: Remove unused CFX_PSRenderer and various encoders it used.Lei Zhang
- Simplify remaining encoders. - Hook up more of the encoding paths so failures get returned. - Clean up code to not pass by non-const ref, use bools, etc. R=ochang@chromium.org Review URL: https://codereview.chromium.org/1545563003 .
2015-12-22Add ContainsKey() and ContainsValue() and use them where appropriate.Lei Zhang
R=ochang@chromium.org Review URL: https://codereview.chromium.org/1540263003 .
2015-12-22Convert CPDF_Parser::m_CrossRef to a std::map.Lei Zhang
This improvements memory usage in case PDFs have sparse object numbers. The map holds a struct that currently has only one member. The struct will contain more members as other internal data structures get converted. BUG=pdfium:111 R=weili@chromium.org Review URL: https://codereview.chromium.org/1539573003 .
2015-12-18Cleanup CJBig2_HuffmanTable and friends.chromium/2599chromium/2598chromium/2597Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1536923002 .
2015-12-18Get rid of a few CPDF_Object Create() methods and just use new instead.Lei Zhang
R=ochang@chromium.org Review URL: https://codereview.chromium.org/1540693002 .
2015-12-18Fix the JBIG2 decoding regressions from commit bc4b82e and 8a9ce57.Lei Zhang
BUG=566063 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1534323002 .
2015-12-18CPDF_ImageLoader::Load() unused.Tom Sepez
Rename a few other things along the way: CPDF_ProgressiveImageLoaderHandle becomes ImageLoaderHandle, since its the only kind, and stop casting it to void*. CPDF_ImageLoader::StartLoadImage() becomes Start(), since the rest is redundant. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1535243002 .
2015-12-18Merge to master: Remove CFX_MapPtrToPtr in CFX_PageRenderCacheTom Sepez
Orignal Review URL: https://codereview.chromium.org/1539983002 . (cherry picked from commit 0fa6fee0e48af8681f0cd50f6a9471ecc0a46c11) TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1536123002 .
2015-12-18CPDF_QuickStretcher unused.Tom Sepez
Apart from it never being initialized, note that m_status is never set to 1, so the only path that references this class can't be reached. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1537103002 .
2015-12-18Fix a memory leak in CPDF_DataAvail::CheckHintTablesOliver Chang
R=thestig@chromium.org, dml@google.com BUG=pdfium:327 Review URL: https://codereview.chromium.org/1536113002 .