Age | Commit message (Collapse) | Author |
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1412453005 .
|
|
This limit mirrors FX_MAX_PAGE_LEVEL in fpdf_parser_document.cpp
Clean merge.
TBR=thestig@chromium.org
BUG=544880
Review URL: https://codereview.chromium.org/1421743003 .
(cherry picked from commit 3bfb1dcf56f8470b693ad1126e24e65f9d17926c)
Review URL: https://codereview.chromium.org/1418173003 .
|
|
This Cl adds ToStream, CPDF_Object::AsStream and CPDF_Object::IsStream and
updates the src to use them as needed.
BUG=pdfium:201
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1402413004 .
(cherry picked from commit 338805f1366dcdf9a5b48cf591541cf98d7490f1)
Review URL: https://codereview.chromium.org/1422513004 .
|
|
This Cl adds ToArray, CPDF_Object::AsArray and CPDF_Object::IsArray and
updates the src to use them as needed.
BUG=pdfium:201
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1417893003 .
(cherry picked from commit c2bfc000e502c42c9a3017038fd9104c7997d126)
Review URL: https://codereview.chromium.org/1419643005 .
|
|
Also fixes a potential memory leak.
R=tsepez@chromium.org, thestig@chromium.org
BUG=pdfium:156
Review URL: https://codereview.chromium.org/1409973003 .
(cherry picked from commit de49cf173d12fe7a462168e2bf6c44971d7d28f8)
Review URL: https://codereview.chromium.org/1420103002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1412733011 .
(cherry picked from commit 5a5b6fb3759daf1201ffc9702f626f4b243922d0)
Review URL: https://codereview.chromium.org/1414463006 .
|
|
This Cl adds ToName, CPDF_Object::AsName and CPDF_Object::IsName and
updates the src to use them as needed.
BUG=pdfium:201
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1417823005 .
(cherry picked from commit 1c77edb7b34e03787605b7965784cea38ef9f1d7)
Review URL: https://codereview.chromium.org/1417033004 .
|
|
This Cl adds ToString, CPDF_Object::AsString and CPDF_Object::IsString and
updates the src to use them as needed.
BUG=pdfium:201
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1417933002 .
(cherry picked from commit 53d3ab125ef583be8cfac907b308a6551b93067a)
Review URL: https://codereview.chromium.org/1408323006 .
|
|
This Cl adds ToNumber, CPDF_Object::AsNumber and CPDF_Object::IsNumber and
updates the src to use them as needed.
BUG=pdfium:201
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1410673005 .
(cherry picked from commit 83bf02dfb860a66d756434d194118dae572d04d3)
Review URL: https://codereview.chromium.org/1422583002 .
|
|
This Removes the ctor that took a pointer to the data to store and copied it
into the union memory. Instead, the call sites look at the type and pass the
correct value.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1422473002 .
(cherry picked from commit 8430a5d04883fac4666d0c321fc679bcaf99cb71)
Review URL: https://codereview.chromium.org/1417113002 .
|
|
This CL adds ToBoolean, CPDF_Object::AsBoolean and CPDF_Object::IsBoolean and
updates the src to use them as needed.
BUG=pdfium:201
TBR=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1417623005 .
(cherry picked from commit ce4f95d61f5aa5fb9a5fc6cb8487999a9cf46458)
Review URL: https://codereview.chromium.org/1419663004 .
|
|
This reverts commit 937840e1722d1f2b77d80575d6e710d760662c9c.
Add type cast definitions for CPDF_Dictionary.
This CL adds ToCPDFDictionary type definitions and updates one file to use
instead of straight casts. I had to fix two places where we'd casted off the
constness of the original pointer.
BUG=pdfium:201
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1420583003 .
(cherry picked from commit 39869b641511c882d78e17548293cdb458c36f38)
Review URL: https://codereview.chromium.org/1410343003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1409323003 .
|
|
Hand-application of diffs from https://codereview.chromium.org/1233453014/.
This was an oversight, and was too old (pre-reformat) to apply cleanly.
Checked against origin/master, only diffs are xfa related.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1416793002 .
|
|
Review URL: https://codereview.chromium.org/1417483004 .
(cherry picked from commit ad0f4d9b371c1862a78046c2e3dea5d515043070)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1418543003 .
|
|
Get rid of cond ? TRUE : FALSE.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1405723003 .
(cherry picked from commit aff4635dad81bc319266d9d84b81552580cd2b65)
Review URL: https://codereview.chromium.org/1412793003 .
|
|
Also reduce nesting in if statements, remove CFX_SmartPointer, and
use more unique_ptrs.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1393303004 .
(cherry picked from commit 6101a5f98b27888f1736ae74982ed4d409d83be0)
Review URL: https://codereview.chromium.org/1413223002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1401493002 .
(cherry picked from commit 894d1cd3f56b1c8c33c5a60ebfec14384e5002d0)
Review URL: https://codereview.chromium.org/1413213002 .
|
|
Original patch by Evangelos Foutras.
Orignal Review URL: https://codereview.chromium.org/1409243004 .
(cherry picked from commit 1b5084321ed924ad3fcc437c3effc81baafd18ac)
BUG=505226
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1418493002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1406363002 .
(cherry picked from commit 316e482630d5f5d9084edd9725f98a0d89a5bbdf)
Review URL: https://codereview.chromium.org/1406303006 .
|
|
Also remove some gotos and move code into an anonymous namespace.
And then do the partial revert to avoid size_t going negative.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1356373003 .
Review URL: https://codereview.chromium.org/1400723002 .
(cherry picked from commit d03ba8d1a5928e8f3f6bd7da063b53b0bc40abfd)
(cherry picked from commit a398ca611d1925182ff6a4e8b2b43c277c364dc0)
Review URL: https://codereview.chromium.org/1406373002 .
|
|
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1410043003 .
(cherry picked from commit 3d7d1d2f29e5fb099367a40822684d31f684fd62)
Review URL: https://codereview.chromium.org/1415453002 .
|
|
Take extern tables portion only of fx_bidi change.
Take itoa fixes and corresponding unit test.
Merge typo in skia font mgr.
Kill some null checks after new.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1409223002 .
|
|
PDF specs say that end of line markers shall follow the
keyword "stream". But a white space before end of line
markers follows this keyword in the test pdf files.
BUG=543018
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1401923005 .
|
|
R=tsepez@chromium.org, thestig@chromium.org
BUG=pdfium:212
Review URL: https://codereview.chromium.org/1405203002 .
(cherry picked from commit fb3c41e5324671bce0b0ec025f4e94ae0b20906e)
Review URL: https://codereview.chromium.org/1406103002 .
|
|
Propagate the return value of GetRBG to the callers instead of forcing the
return of TRUE.
BUG=pdfium:44
TBR=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1398633008 .
(cherry picked from commit b456ba7f62fa416f456ef78750c18fd2bdf837be)
Review URL: https://codereview.chromium.org/1411443003 .
|
|
Original Review URL: https://codereview.chromium.org/1399983003 .
(cherry picked from commit 6eeffab789800e2afa1b9d10de70c9116db32355)
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1399893003 .
|
|
We did this with the other codecs in master, but these two are
XFA-only, and did not get the same treatment.
Remove some fx_ prefixes in the third-party file names.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1392373004 .
|
|
- Use std::vector<JBig2ArithCtx> instead of storing pointers to arrays.
- Make CJBig2_SymbolDict's members private with accessors.
- Use std::vector<JBig2ArithCtx> in related places.
- Steal Chromium's vector_as_array() and use it as an adaptor as needed.
BUG=514891
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1388203003 .
(cherry picked from commit 3acb1ef909a22368507ed13817c4988c818e3aee)
Review URL: https://codereview.chromium.org/1401533004 .
|
|
TBR=dml@google.com
Review URL: https://codereview.chromium.org/1390863002 .
(cherry picked from commit fb0334733cf4a541636128f77f9fe8067a8c70f6)
Review URL: https://codereview.chromium.org/1395213003 .
|
|
BUG=497357
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1395493003 .
|
|
It's a bug existing in the conversion from YUV420 to RGB.
For YUV 420 format, four pixels have 4 Y but only one U and
one V. In some cases, there are odd columns or lines in
some images. The pixels on last line or column may have Y
but no U or V data. For this case, We shall extend U or V
using the data on previous column or line.
BUG=497357
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1342683002 .
|
|
Just get rid of the malloc altogether and use CJBig2_List instead.
BUG=540873
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1394933002 .
(cherry picked from commit 06f255ca4040f3d73cf09f1dbd63a3b167f6a4c1)
Review URL: https://codereview.chromium.org/1400663003 .
|
|
- Makes the cache be per-document
- Keys the cache on ObjNum and stream offset instead of keying on a pointer to the data (which can result in false cache hits).
- Makes it so the cache is only used for the globals stream.
- Reenable the cache.
R=dml@google.com
TBR=dml@google.com
BUG=pdfium:207
Review URL: https://codereview.chromium.org/1380243004 .
(cherry picked from commit f1b88e76134808f36f16b9e53a2e9dd89b12c8fd)
Review URL: https://codereview.chromium.org/1394373002 .
|
|
Also mark it private.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1395613003 .
(cherry picked from commit 8793b4a071fad51a770b93838e0752505b020e43)
Review URL: https://codereview.chromium.org/1397853002 .
|
|
CPDF_SyntaxParser::ReadStream() originally created stream objects when
the length is 0. Commit 2526930 tightened the constraint and returned
NULL. This has some adverse affects, as seen in Chromium's print
preview of PDFs.
Instead, relax the constraint a little so when the length is 0, return a
CPDF_Stream with NULL data and size 0.
BUG=531835
Review URL: https://codereview.chromium.org/1394743002 .
(cherry picked from commit 4fa0e27ba39f49ba92fb4c160ab836a6f1dd2893)
Review URL: https://codereview.chromium.org/1400613002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1393823002 .
(cherry picked from commit a0f2b67bd659e3f1780edfac56d8754bca685d5f)
Review URL: https://codereview.chromium.org/1390883004 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1396533002 .
(cherry picked from commit 80aa8c26887d98f654a9eecf7298663656cfc40f)
Review URL: https://codereview.chromium.org/1396743002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1382613003 .
(cherry picked from commit 8a9ce5778e0789beb7ba15a62c592a353a51bcdd)
Review URL: https://codereview.chromium.org/1397683002 .
|
|
many callers can tolerate CJBig2_ArithIntDecoder::decode() OOB failure.
BUG=539749, pdfium:209
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1384663007 .
(cherry picked from commit 35902e725aa6cc83a317c3b6fdd1926b81b8e44b)
Review URL: https://codereview.chromium.org/1396663003 .
|
|
only ever set to false.
TBR=dml@google.com
Review URL: https://codereview.chromium.org/1393153002 .
(cherry picked from commit 1f439a7a3b7c44235ecdac9a411add8fb62b0d83)
Review URL: https://codereview.chromium.org/1392873003 .
|
|
Also change CJBig2_SymbolDict::DeepCopy() to return a unique_ptr to
prevent a potential leak if the cache size was 0.
BUG=pdfium:207
R=tsepez@chromium.org, jbreiden@google.com
Review URL: https://codereview.chromium.org/1374633004 .
(cherry picked from commit fd12ec5584d9a17f310a2c0c408a438ef3b1ce63)
Review URL: https://codereview.chromium.org/1390673002 .
|
|
(cherry picked from commit d7ba833df5c9dc70cb94dba2d0aae1339b345ae4)
Original Review URL: https://codereview.chromium.org/1306883002 .
TBR=forshaw@chromium.org
BUG=523278
Review URL: https://codereview.chromium.org/1383353002 .
|
|
BUG=537772
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1387703002 .
(cherry picked from commit 4f277fc8d41303cbf007335dfbbff60b81fffde0)
Review URL: https://codereview.chromium.org/1380603006 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1360103002 .
(cherry picked from commit b8a074711108baf04017d86207e08c19ff327d8e)
Review URL: https://codereview.chromium.org/1384123002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1386463003 .
(cherry picked from commit dcfa0ba2928072c962fe8835d1a2ccd309eafbbd)
Review URL: https://codereview.chromium.org/1379093003 .
|
|
Check the image size before attempting to decode.
BUG=538103
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1377493005 .
(cherry picked from commit 9fb70fbded5c0bf4f5313a49fd3496b4d4fa71ca)
Review URL: https://codereview.chromium.org/1379233003 .
|
|
Found using the test examples from https://crbug.com/537780
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1376413003 .
(cherry picked from commit 63d0a52a6af7d327fdb5792f520cc8d93fe2f1bb)
Review URL: https://codereview.chromium.org/1378303006 .
|
|
BUG=537790
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1379243002 .
(cherry picked from commit 095a83c59120c108d9ac6f0ab71fd3faa5eea810)
Review URL: https://codereview.chromium.org/1380563003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1378303002 .
|