Age | Commit message (Collapse) | Author |
|
This CL moves the two files and breaks fpdf_text.h apart into individual pieces.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1801973002 .
|
|
This CL adds the needed DEPS files to make checkdeps pass correctly. The
checkdeps PRESUBMIT method has been copied from Chromium and is enabled on
CL upload.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1801923002 .
|
|
This CL moves the files in fpdfsdk/src/ up one level to fpdfsdk/ and fixes
up the include paths, include guards and build files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1799773002 .
|
|
Alterntive to part of https://codereview.chromium.org/1785943002/
BUG=589724
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1802553004 .
|
|
This CL moves the core/src/ files up to core/ and fixes up the include guards,
includes and build files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1800523005 .
|
|
Mainly change the code to avoid the warnings; in a few cases we have
to use explicit casts.
BUG=pdfium:29
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1783023002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1776913007 .
|
|
Also remove unnecessary casts.
BUG=pdfium:29
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1783933002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1778173002 .
|
|
CPDF_CryptoHandler was always a pure-virtual class, now it
is named as IPDF_ to indicate this.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1782673002 .
|
|
Also move ScopedFileStream, since it isn't specific to the
parser, and belongs with the fxcrt object it manipulates.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1780063003 .
|
|
It's not used anywhere in fpdfapi, and can become restricted
to fpdfoc/.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1776713004 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1780703002 .
|
|
Move time.h inclusion to new file.
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1778893003 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1781593003 .
|
|
Missing explicit include of <vector>
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1783433004 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1773103003 .
|
|
This CL goes through the remaining list of list warnings and records why they
are currently blacklisted, or fixes and enables them.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1773733002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1780503002 .
|
|
This reverts commit 06fae28d307fe051f0c7e890344cd487c2260910.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1775023003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1775913003 .
|
|
This reverts commit d50095fb151688e119a7097aabce11e4b3d36244.
Reason for revert: build broken.
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1774293002 .
|
|
BUG=
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1774753002 .
|
|
This reverts commit 594912241cd7d409b5f58a48ccffdc1904d844b2.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1769273002 .
|
|
Since it is malloc'd, memset, and such, and clang-cl
notices this. Also delete unused function found by clang-cl.
BUG=pdfium:429
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1777573003 .
|
|
The current cast confused runtime/casting. Update to use static_cast and enable
the lint warning.
BUG=pdfium:426
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1770253003 .
|
|
The agg driver files are split into src/ and include/ directories. This CL
moves the source files up one level and removes the src/ and include/
directories.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1773593007 .
|
|
It isn't sub-classed. Making GetNextChar() non-virtual
may save a virtual fn call per character if the compilers
aren't able to do so themselves.
Make members private, not protected.
BUG=
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1772973002 .
|
|
This reverts commit c582c0ddfea8ba01c8449ed7841cdb33c12e0a98.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1769263002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1772543003 .
|
|
BUG=591137
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1769183002 .
|
|
This only directs paths to use Skia. Text and bitmaps
still use antigrain.
Clipping is disabled -- still figuring out pdfium's model
for saving and restoring clips.
Deleting the Skia canvas is disabled -- there's some build problem
where the pdfium and skia libraries are built with slightly
different options that I haven't tracked down. This is also why
for the moment SkDebugf is defined locally.
With this patch and pdf_use_skia=1 a modestly complicated PDF draws
(mostly) correctly with pdfium_test.
R=dsinclair@chromium.org, tsepez@chromium.org, dsinclair
BUG=
Review URL: https://codereview.chromium.org/1761453002 .
|
|
This Cl combines the two StrToInt implementations. In doing so I had to add
some more overrides to toDecimalDigit() and add a isDecimalDigit().
BUG=pdfium:423
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1757283002 .
|
|
This CL fixes up chromium-style warnings in fpdf_object.h Specifically, the
warnings fixed were:
* Complex constructor has an inlined body.
* Complex destructor has an inline body.
* virtual methods with non-empty bodies shouldn't be declared inline.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1764793002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1761993002 .
|
|
Despite what the c++11 spec says, std::list::size() is
still O(n), not O(1).
R=dsinclair@chromium.org, ochang@chromium.org
Review URL: https://codereview.chromium.org/1763443003 .
|
|
Currently, there is a check that an object number is <= 0x1000000. If that
check fails, we end up putting the parser into a bad state and fail to load
documents. The object does not need to be in the XRef table, or referenced
from the document, just be in the document.
This Cl removes the size check and updates the various atoi calls to use a
uint32_t instead of an int32_t so we don't end up getting strange values when
converting from a string.
BUG=455199
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1755273002 .
|
|
This is to fix an issue when win32k lockdown is enabled on PDF content
which can cause application crashes. If GDI is disabled then there's
little benefit to loading the GDI+ library.
BUG=583038
Patch by forshaw@
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1748163006 .
|
|
Due to implicit conversion if the names buffer is empty then nullptr will
be passed to GetNameFromTT which blindly dereferences it leading to a NPD
if an invalid font file is read.
BUG=583037
Patch by forshaw@
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1763493003 .
|
|
The CFX_GrowOnlyPool class is never used, removed.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1757043002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1751753002 .
|
|
This CL fixes and enables:
* readability/namespace
* readability/multiline_string
* readability/multiline_comment
* readability/inheritance
* readability/function
* readability/braces
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1747123002 .
|
|
Helps with transparency. Also remove default args and
use override consistently in the affected methods.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1751093002 .
|
|
and making bits of the code simpler.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1742273002 .
|
|
This does not appear to ever be defined, remove.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1753723002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1752543002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1748803002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1745243002 .
|
|
I'm guessing that |small| is #defined somewhere.
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1746243002 .
|
|
Put these first, so later on more complicated classes can
have constructors that take these as arguments.
Add better constructors, and call appropriately. Also don't
be afraid to return these from methods since RVO.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1745683002 .
|