Age | Commit message (Collapse) | Author |
|
Not just a simple merge, but changes to remove CFX_Object from XFA.
Original Review URL: https://codereview.chromium.org/1088733002
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1087053002
|
|
BUG=476107
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1080893002
|
|
TBR=tsepez@chromium.org
BUG=N/A
Review URL: https://codereview.chromium.org/1081663002
|
|
Add a check to make sure offset is less than the size of string in the function of GetNextChar().
BUG=471651
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1067073003
|
|
Three functions in fx_coordinates.h account for 60% of the warnings
when building with VS 2015, due to variable shadowing. Renaming the
function parameters is safe, resolves the warnings, and reduces
confusion.
From https://codereview.chromium.org/1077083003
TBR=tsepez@chromium.org
BUG=440500
Review URL: https://codereview.chromium.org/1077283002
|
|
TBR=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1073313003
|
|
A stack overflow was triggered by checked_cast due to
invalid index in pdf files like 'Index[45 -1661]'.
BUG=473400
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1054303005
|
|
Original Review URL: https://codereview.chromium.org/1071343002
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1079623002
|
|
GCPDF_CIDFont::_CharCodeFromUnicode
There is not a code page (CP) used for converting unicode to mutli-bytes
if the coding scheme is CID coding. Only return 0 if CID can't be retrieved.
The difference on Windows and other platforms should be the function used
for converting rather than others.
BUG=466790
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1074653002
|
|
BUG=469244
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1062983002
|
|
This incorporates class vs. struct fix in 34f5fc0f2a18
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1063283002
|
|
Note: new includes for XFA
Original Review URL: https://codereview.chromium.org/1064433005
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1062843003
|
|
chrome
BUG=N/A
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1059233005
|
|
Adds a comment and changes some whitespace.
TBR=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1059373002
|
|
BUG=N/A
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1057383002
|
|
When there is a wrong keyword like '??ze' in the dictionary
of the trailer, PDFium can't recognize it and aborts further
parsing. After this change, PDFium continues even it can't
get the right size at this moment. It will rebuild the cross
reference table later since the size of the table is missing.
BUG=459580
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1055323003
|
|
MSAN reported this issue when I tried to reproduce 460936 in the last version of freetype on Linux.
BUG=N/A
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1050333002
|
|
subsetting enabled
BUG=465322
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1045553004
|
|
Original Review URL: https://codereview.chromium.org/1026843002
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1025753002
|
|
Original Review URL: https://codereview.chromium.org/1016203002
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1027443002
|
|
In the process of opj_end_decompress, it will return fail when the end of coding stream is reached. However it returns true in the same scenario implemented in openJPEG. So the final solution is from openJPEG. Return true when the end of coding stream is reached.
BUG=452671
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/990683002
|
|
BUG=382661
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1007643002
|
|
BUG=466338
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/997273002
|
|
There is fx_codec_png.cpp that has a sprintf under XFA
that was not present in master.
Original Review URL: https://codereview.chromium.org/999543002
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/995993002
|
|
Original Review URL: https://codereview.chromium.org/985503005
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/985153002
|
|
Original Review URL: https://codereview.chromium.org/984703004
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/984143002
|
|
Original Review URL: https://codereview.chromium.org/984773002
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/984783002
|
|
Original Review URL: https://codereview.chromium.org/952423002
(cherry picked from commit 944ccad72d028ed5e37f53c5c8c0888866905bc3)
Review URL: https://codereview.chromium.org/970523002
|
|
fixes.
Original Review URL: https://codereview.chromium.org/892553002
(cherry picked from commit 254360730190cc6d6e3de325ee101948b78c1e32)
Review URL: https://codereview.chromium.org/967773002
|
|
Original Review URL: https://codereview.chromium.org/885223004
(cherry picked from commit 900d7bf46efc26e0588e1777759f7716ed4f8dbd)
Review URL: https://codereview.chromium.org/963413002
|
|
Original URL: https://codereview.chromium.org/891113002
(cherry picked from commit 44fc192f29a77c5864fabffe5ab63937dacdfd21)
Review URL: https://codereview.chromium.org/966023002
|
|
Original URL: https://codereview.chromium.org/890883006
(cherry picked from commit 3f41851972a18762164d7110a82da3baed564b80)
Review URL: https://codereview.chromium.org/966013002
|
|
Original URL: https://codereview.chromium.org/837093002
(cherry picked from commit f8105c665856863ad95da37fee6c12b98b953e2c)
Review URL: https://codereview.chromium.org/967033002
|
|
Original URL: https://codereview.chromium.org/837533003
(cherry picked from commit 256ef88a26cff56fc7c23119d2d9e1b41468bd1a)
Review URL: https://codereview.chromium.org/963403002
|
|
sizes.
Original URL: https://codereview.chromium.org/825983004
(cherry picked from commit dd132d8d1e9a27673e5357a657db2b97dda9bcdb)
Review URL: https://codereview.chromium.org/965033005
|
|
BUG=446057
Original Author: sebmarchand@chromium.org
Original CL: https://codereview.chromium.org/837523002/
Review URL: https://codereview.chromium.org/812843004
(cherry picked from commit f96404951bc1505887e2567088b59206316c9297)
Review URL: https://codereview.chromium.org/966003002
|
|
BUG=457493
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/960183004
|
|
Original Review URL: https://codereview.chromium.org/845313006
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/945793004
|
|
This issue was introduced in https://codereview.chromium.org/886953002/.
BUG=454280
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/869343008
|
|
Original Review URL: https://codereview.chromium.org/880233005
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/916953002
|
|
BUG=449845
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/911293002
|
|
This issue was caused by integer overflow in CPDF_SampledFunc::v_Call.
The root cause of this issue is that the content in the test pdf file
was damaged. The solution is to check whether an integer is overflow
before using it.
BUG=452455
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/886953002
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/889253003
|
|
Original Review URL: https://codereview.chromium.org/902943003
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/895903005
|
|
None of these are currently reachable because the IsSafeMode
method always returns true. This, in turn, will let us kill
off some file (as in fopen()) based parsing. That, in turn,
will let us kill of some more now-unreachable code.
In general, we don't want to have unsafe modes.
BUG=https://code.google.com/p/pdfium/issues/detail?id=116
R=jam@chromium.org
Review URL: https://codereview.chromium.org/883393007
|
|
Original Review URL: https://codereview.chromium.org/895933003
BUG=454695
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/901013003
|
|
Original revieww URL: https://codereview.chromium.org/900753002
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/880603004
|
|
Original review URL: https://codereview.chromium.org/896023003
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/897023005
|
|
Original Review URL: https://codereview.chromium.org/889673003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/900693003
|
|
Original Review URL: https://codereview.chromium.org/880043004
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/893333003
|