Age | Commit message (Collapse) | Author |
|
appropriate.
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1540263003 .
(cherry picked from commit 1fc92867ca53f0fba4272fbee3814d844f487495)
Review URL: https://codereview.chromium.org/1542193002 .
|
|
This improvements memory usage in case PDFs have sparse object numbers.
The map holds a struct that currently has only one member. The struct
will contain more members as other internal data structures get
converted.
BUG=pdfium:111
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1539573003 .
(cherry picked from commit f6dafc90ec1a0df8d618efc68c0223f0cdd80ffb)
Review URL: https://codereview.chromium.org/1544913002 .
|
|
instead.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1540693002 .
(cherry picked from commit d866ab0b44a571c884fdd8ba5a5319adaf607559)
Review URL: https://codereview.chromium.org/1541563002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1536923002 .
(cherry picked from commit 9c061e2dfb22a0e321728b73c8650eded8828d90)
Review URL: https://codereview.chromium.org/1539023002 .
|
|
8a9ce57.
BUG=566063
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1534323002 .
(cherry picked from commit 20c8a9a66ea710b96493c9048fb65753e68b48fc)
Review URL: https://codereview.chromium.org/1540673003 .
|
|
Original Review URL: https://codereview.chromium.org/1535243002 .
(cherry picked from commit b5385ba5d0c616cd4af994b2a9d674588086f75c)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1539003002 .
|
|
Rename CPDF_ImageCache to CPDF_ImageCacheEntry because it
represents a single entry, not the entire cache itself.
Delete unused ClearRenderCache method, and merge cache entry
clear() into its dtor.
Fix a broken size calculation.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1539983002 .
|
|
Original Review URL: https://codereview.chromium.org/1537103002 .
(cherry picked from commit f0f6a01ee3dcb592e4eeaadaa2ea52c2fce317ba)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1540683002 .
|
|
R=thestig@chromium.org
TBR=thestig@chromium.org
BUG=pdfium:327
Original Review URL: https://codereview.chromium.org/1536113002 .
(cherry picked from commit 6287ebc38e5aafc256b6248caae710ea09d0ede4)
Review URL: https://codereview.chromium.org/1537123002 .
|
|
BUG=pdfium:329
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1529173005 .
Review URL: https://codereview.chromium.org/1535753003 .
|
|
An email address contains user name part and host name part.
User name allows dash or underscore, but not leading/ending/double
period. Host name doesn't allow leading/ending/double
period either.
BUG=489107
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1530763005 .
(cherry picked from commit cc70b7b55c9edcd0ff038f59080699060fbbede1)
Review URL: https://codereview.chromium.org/1532303002 .
|
|
It looks like an key length of 0 was incorrectly assumed to
denote an free entry.
Fixes a memory leak in FPDFViewEmbeddertest.Crasher_451830 due to values with
empty keys being incorrectly overwritten.
TBR=tsepez@chromium.org
Original Review URL: https://codereview.chromium.org/1534953002 .
(cherry picked from commit 391783579c5a8aad346b56903b51e6551600550b)
Review URL: https://codereview.chromium.org/1532283002 .
|
|
Orignal Review URL: https://codereview.chromium.org/1534003002 .
(cherry picked from commit fed9dd90c086c854ef13440e6022602eb9f91cfc)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1537463003 .
|
|
Original Review URL: https://codereview.chromium.org/1536623004 .
(cherry picked from commit 761660c4074269ac806d06c9bef70e4e9fb0eb29)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1531423002 .
|
|
Also fix a newly introduced override warning.
Also define a host_clang GYP variable.
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1532723003 .
Review URL: https://codereview.chromium.org/1533763002 .
(cherry picked from commit e096ca507db9944aebc47d6c2cc1c6fab39498c5)
(cherry picked from commit 0a9158b99a2002fb82301ebec20dbc23b3fc084c)
Review URL: https://codereview.chromium.org/1535603003 .
|
|
While reading free entries in v4 cross reference table, changing the
start_objnum caused crossref table built wrong.
BUG=569795
TBR=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1527823003 .
(cherry picked from commit c89cd979fb8654d85b822909cba9263d5f13760c)
Review URL: https://codereview.chromium.org/1528153003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1525853003 .
(cherry picked from commit 4d4c61ea4e39135b126879dd6d7bc99a59a3a843)
Review URL: https://codereview.chromium.org/1524023002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1520063002 .
(cherry picked from commit e385244f8cd6ae376f6b3cf1265a0795d5d30eff)
Review URL: https://codereview.chromium.org/1528763003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1512763013 .
(cherry picked from commit e3c7c2b54348da4a6939f6672f6c6bff126815a7)
Review URL: https://codereview.chromium.org/1529553003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1521563002 .
(cherry picked from commit 1956a174020686f91cd3b34294e91f4560fe45aa)
Review URL: https://codereview.chromium.org/1526823002 .
|
|
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1514283002 .
(cherry picked from commit 1407c979a3ba8599546468d461f5403f317bddd3)
Review URL: https://codereview.chromium.org/1525013002 .
|
|
R=thestig@chromium.org
TBR=thestig@chromium.org
BUG=566179
Original Review URL: https://codereview.chromium.org/1524983002 .
(cherry picked from commit 1eb7477b3e7c5cb7c54ca364810ab9a24acad4f9)
Review URL: https://codereview.chromium.org/1525793003 .
|
|
BUG=566179
TBR=thestig@chromium.org
Original Review URL: https://codereview.chromium.org/1523523002 .
(cherry picked from commit be8408f43bcfd69a74007a340a4c034004146c60)
Review URL: https://codereview.chromium.org/1518403003 .
|
|
BUG=447331
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1514093002 .
Review URL: https://codereview.chromium.org/1515403003 .
|
|
strict.
BUG=pdfium:326
TBR=dml@google.com
Review URL: https://codereview.chromium.org/1521543002 .
(cherry picked from commit ebc7695c60fc3e4afbfa6d9db162a71b190bf685)
Review URL: https://codereview.chromium.org/1519323002 .
|
|
Also clean up while we're here.
BUG=557223
TBR=tsepez@chromium.org
Original Review URL: https://codereview.chromium.org/1512833008 .
(cherry picked from commit 08750d0400f1635ac33c3234cb11b192f31a1eeb)
Review URL: https://codereview.chromium.org/1521473003 .
|
|
Original Review URL: https://codereview.chromium.org/1520643002 .
(cherry picked from commit 7db2a535f163e7ce5995da12161ebd0214f0f75a)
Original Review URL: https://codereview.chromium.org/1511413008 .
(cherry picked from commit 168cfb7ee0f2abbd2bddb7e7d8b430a6d8c6c120)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1515613006 .
|
|
Review URL: https://codereview.chromium.org/1513363002 .
(cherry picked from commit f32c969bce6743fca1e7ff796b54a1692d26d7f0)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1519693002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1507043004 .
(cherry picked from commit d9324d8f7345d4546c06c4a9d6cd497b0f7f3ad2)
Review URL: https://codereview.chromium.org/1512203003 .
|
|
BUG=pdfium:298
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1496703005 .
(cherry picked from commit 93181f9a20db7ac706bb9405750303db93762a5b)
Review URL: https://codereview.chromium.org/1514783002 .
|
|
BUG=452793,561478
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1512873002 .
|
|
Original Review URL: https://codereview.chromium.org/1518593002 .
(cherry picked from commit 035359cd8ddb555fa33b6133db4fd405e4660712)
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1513103002 .
|
|
Revert "Fix embedder test failures introduced by commit c70b19aad245"
This reverts commit 8d89e65897d8b6cf7899e7a82d9d381c3ad327cb.
Revert "Fix invalid buffer length set in CFX_WideString::UTF16LE_Encode()"
This reverts commit c70b19aad245fb1ed39bf8c264d991555f4c5a58.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1516643002 .
|
|
The root cause is that FXFONT_SUBST_EXACT is wrongly
set even no any subset font was found. It causes
m_bCIDIsGID to be wrongly set as TRUE in CPDF_CIDFont::_Load().
BUG=534945
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1502083002 .
Review URL: https://codereview.chromium.org/1504263002 .
|
|
Loosen a check for earlier version of PDF files. When the bytes with
specified length are followed by 'endstream' keyword, even if there is
no EOL marker before the keyword, it signals the end of stream.
BUG=551258
TBR=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1499433002 .
(cherry picked from commit 0ff66089c87ab6e3adaaff0ec69728ce7a8d8299)
Review URL: https://codereview.chromium.org/1504723002 .
|
|
R=tsepez@chromium.org
TBR=tsepez@chromium.org
BUG=566179
Original Review URL: https://codereview.chromium.org/1504513002 .
(cherry picked from commit 2d16308298f236ae81aa11a53f2d4e25b502dfac)
Review URL: https://codereview.chromium.org/1501123002 .
|
|
RebuildCrossRef function returns false when we can not find file trailer
or any indirect object. This serves as a basic file format checking.
BUG=pdfium:215
TBR=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1476163002 .
(cherry picked from commit f14da1d58e8e12633c7a47e6efd5ffe43bb37b4b)
Review URL: https://codereview.chromium.org/1486383002 .
|
|
This first pass is GYP-only, will do GN in the next CL.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1480403002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1477663003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1471323004 .
|
|
- remove redundant alloc in fx_codec_jpx_unittest.cpp
- free memory allocated by HexDecode calls in fpdf_parser_decode_unittest.cpp
BUG=PDFium:239
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1467183006 .
(cherry picked from commit 6c2d736011c09266015d3e2a0b9c08aeba1bbf31)
Review URL: https://codereview.chromium.org/1477833002 .
|
|
BUG=pdfium:275
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1443603002 .
|
|
Also change the copy ctor to take a const ref.
BUG=560520
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1472113002 .
(cherry picked from commit d03bc01003ae2603dafdc07b901ffef0a509a2b9)
Review URL: https://codereview.chromium.org/1478473002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1463173003 .
|
|
Original Review URL: https://codereview.chromium.org/1459243002 .
(cherry picked from commit 6fc00fafcbac1fd5edd767fe2d4a8e4a9ef52806)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1461703008 .
|
|
This matches the type of the corresponding |CFX_DIBSource::m_Pitch|,
where integer overflow is checked for FX_DWORD. This change is
propagated to many other places.
Also, check for integer overflow in |CCodec_RLScanlineDecoder::Create|
during the calculation of |m_Pitch| since it aligns to 4 bytes while
overflow was was previously checked without this alignment.
TBR=tsepez@chromium.org
BUG=555784
Review URL: https://codereview.chromium.org/1460033002 .
(cherry picked from commit e7950df70a2fd658f466751b29483436cb31e829)
Review URL: https://codereview.chromium.org/1461363002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1465663002 .
|
|
This week's version. Mostly whitespace, but takes the
master version of core/src/fxge/ge/fx_ge_text.cpp
verbatim.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1462923004 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1458633004 .
(cherry picked from commit 0c8e6c1f39f20985a3efb17292e46c476194183a)
Review URL: https://codereview.chromium.org/1461693005 .
|
|
Using Chromium's clang + build options, there's more override warnings.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1453643002 .
(cherry picked from commit 126ba519bdd489ec6c285d1410dcae773e8ef673)
Review URL: https://codereview.chromium.org/1458373002 .
|