summaryrefslogtreecommitdiff
path: root/core
AgeCommit message (Collapse)Author
2015-08-10Merge to XFA: Cleanup: Mark methods with the override keyword.Lei Zhang
- Delete unneeded CFFL_ComboBox::CanCopy() and friends. - Delete unneeded CFFL_FormFiller::CanCopy() and friends. - Delete unneeded CFFL_TextField::CanCopy() and friends. - Delete unneeded FormFiller::DoCopy() and friends. - Rename CFFL_FormFiller::On{Set,Kill}Focus to avoid conflicts. BUG=pdfium:185 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1283493004 . (cherry picked from commit 3a3849176aa6e2db8baf2f9367b2d96c71815319) Review URL: https://codereview.chromium.org/1279123006 .
2015-08-06XFA: clang-format all pdfium code, again.Nico Weber
Also add a presubmit that checks for this so I don't have to keep doing it. No behavior change. Generated by: find . -name '*.cpp' -o -name '*.h' | \ grep -E -v 'third_party|thirdparties|lpng_v163|tiff_v403' | \ xargs ../../buildtools/mac/clang-format -i Then manually merged https://codereview.chromium.org/1269223002/ See thread "tabs vs spaces" on pdfium@googlegroups.com for discussion. BUG=none R=thestig@chromium.org Review URL: https://codereview.chromium.org/1277043002 .
2015-08-06Merge to XFA: Add CFX_FontFaceInfo constructor.Tom Sepez
(cherry picked from commit 905cc10ecd06bcacfefb747cc3370c72772f0e15) Original Review URL: https://codereview.chromium.org/1277883004 . TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1279873002 .
2015-08-05Merge to XFA: Early object closing in PDF via premature 'endobj' keywordJUN FANG
Adobe acrobat defines keywords "\nendstream\n" and "\nendobj\n" in object's stream. However, Pdfium searches "endstream" and "endobj" as the keywords in the streams of objects. Some words like "(endstream)" are wrongly treated as keywords in pdfium. This fix follows Adobe's solution. BUG=493126 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1219133005 .
2015-08-05Mert to XFA: Remove the unused IFX_StreamRead::SetRange() mechanism.Tom Sepez
(cherry picked from commit 8d8a99027d38e3b8d452e7ab8049c310b90e780d) Orignal Review URL: https://codereview.chromium.org/1274883002 . TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1273623003 .
2015-08-05Kill off last uses of FX_NEW in XFA.Tom Sepez
It would seem that this never merged completely. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1277583002 .
2015-08-05Merge to XFA: CPDF_Parser shouldnt be in the business of opening filesTom Sepez
(cherry picked from commit 2b9178181eb82a3611bee5c9435ea5956def24be) Orignal Review URL: https://codereview.chromium.org/1269073003 . TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1278533002 .
2015-08-05Merge to XFA: FPDF_Creator can only create file through callbacks.Tom Sepez
(cherry picked from commit 5cd398545141226f082b2f757f23c73303058a83) Original Review URL: https://codereview.chromium.org/1264423003 . TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1275623002 .
2015-08-04XFA: clang-format all pdfium code.Nico Weber
No behavior change. Generated by: find . -name '*.cpp' -o -name '*.h' | \ grep -E -v 'third_party|thirdparties|lpng_v163|tiff_v403' | \ xargs ../../buildtools/mac/clang-format -i Then manually merged https://codereview.chromium.org/1269223002/ See thread "tabs vs spaces" on pdfium@googlegroups.com for discussion. BUG=none
2015-07-31Merge to XFA: Kill FX_HFILETom Sepez
(cherry picked from commit c8eeed31f217d99a706b0cbf5e4ce0bcc12beb64) Review URL: https://codereview.chromium.org/1259123008 . R=thestig@chromium.org Review URL: https://codereview.chromium.org/1256103006 .
2015-07-31Merge to XFA: Name IFX_SysFontInfo subclasses consistently.Tom Sepez
(cherry picked from commit 4d2e494e38ffdeb0143fbe3f624743499ebcac80) Original Review URL: https://codereview.chromium.org/1257743005 . R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1258283004 .
2015-07-31Merge to XFA: Kill IFX_FontMapperTom Sepez
(cherry picked from commit 01fa1efb228acdcf5250804c670107133668e4b2) Orignal Review URL: https://codereview.chromium.org/1259123005 . conflicts: core/include/fxge/fx_font.h core/src/fxge/ge/fx_ge_fontmap.cpp R=thestig@chromium.org Review URL: https://codereview.chromium.org/1262723006 .
2015-07-30Merge to XFA: Fix return check in CFX_FolderFontInfo::ScanFile() fread.Tom Sepez
(cherry picked from commit 6fc1bf199833d6cb409e8134fe5d6894e8323673) Original Review URL: https://codereview.chromium.org/1262453006 . R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1263813004 .
2015-07-28Merge to XFA: Missing bExact -> iExact conversionsTom Sepez
(cherry picked from commit 452bafebc358d9a1d57266b31a5869584c0fbfb7) Original Review URL: https://codereview.chromium.org/1262683003 . R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1265543002 .
2015-07-27Merge to XFA: Fix FX_BOOL compilation errors under windowsTom Sepez
(cherry picked from commit a25b4bca69ab26d174edb8cefbdcfc1a0353915a) Original Review URL: https://codereview.chromium.org/1254973004 . TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1252943010 .
2015-07-23Merge to XFA: FX_BOOL combo patch.Tom Sepez
Original Review URL: https://codereview.chromium.org/1257503002 Original Review URL: https://codereview.chromium.org/1253603002 Manual merge for: core/include/fxge/fx_font.h core/src/fxcodec/codec/codec_int.h fpdfsdk/src/javascript/PublicMethods.cpp R=thestig@chromium.org Review URL: https://codereview.chromium.org/1248153004 .
2015-07-23Merge to XFA - else after returns.Tom Sepez
(cherry picked from commit 3c012fef2bb72c8ec1faa73e11ee35539b2559d6) Original Review URL: https://codereview.chromium.org/1243953004 . R=thestig@chromium.org Review URL: https://codereview.chromium.org/1239313005 .
2015-07-22Merge to XFA: Remove dead code found by Scythe.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1249643003 . (cherry picked from commit b05f1fd710496dea44b001bb905fa1c16a39bb28) Review URL: https://codereview.chromium.org/1250433003 .
2015-07-22_FETAL => _FATAL.Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1247213002 .
2015-07-21Merge to XFA: Move extern fpdf_font_charset.cpp function prototypes.Tom Sepez
(cherry picked from commit c5fa7f2a36ebd4c92c935e1332a2f7db4f3594d9) Orignal Review URL: https://codereview.chromium.org/1241173004 . TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1243243003 .
2015-07-16Merge to XFA: Cleanup: Do not check pointers before deleting them, part 2.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1195363002 . (cherry picked from commit 21bf242a31eff79f754c5e9c3b41c52e33483bb0) Review URL: https://codereview.chromium.org/1235753006 .
2015-07-15Merge to XFA: Make ContentStreamParser members private, fix constructorTom Sepez
(cherry picked from commit 5b4f57cdc0a279bd9b8e03b8f5714b9d39e642a8) Original Review URL: https://codereview.chromium.org/1219683007 . TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1235593004 .
2015-07-15Merge to XFA: Add a null pointer check to CPDF_CalRGB::v_Load().Lei Zhang
BUG=492055 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1241923005 . (cherry picked from commit bf4598870df6b1ebd511d61d46bc55e1d814ce2d) Review URL: https://codereview.chromium.org/1240843002 .
2015-07-14Merge to XFA: Move extern cmap declarations from .cpp files.Tom Sepez
(cherry picked from commit 759247991b5f1df71335294e6bfe3e3fe7aec7b4) Original Review URL: https://codereview.chromium.org/1221503005 . TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1235253004 .
2015-07-14Merge to XFA: Move FPDFAPI_FlateInit() prototype and friends to .h fileTom Sepez
(cherry picked from commit dacc22cdfea727a04bce086d9bfec9a4d1a29bd4) Orignal Review URL: https://codereview.chromium.org/1240713004 . TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1230373003 .
2015-07-14Merge to XFA: Tighten up DEPS include rules.Tom Sepez
Original Review URL: https://codereview.chromium.org/1233583004 . TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1234923006 .
2015-07-13Merge to XFA: Fix a crashier due to incorrect type conversionJUN FANG
BUG=issue179 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1217093006 .
2015-07-04Cherry-pick to XFA: Remove a superfluous qualifier. No behavior change.Nico Weber
BUG=505296 R=brucedawson@chromium.org Review URL: https://codereview.chromium.org/1221673007.
2015-07-02Cherry-pick to XFA: Add parentheses around && within ||.Nico Weber
BUG=504699 R=raymes@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/1213433005.
2015-07-01Merge to XFA: "Redo range check in CPDF_SampledFunc::v_Call().""Tom Sepez
Original Review URL: https://codereview.chromium.org/1214403002. (cherry picked from commit 0b0f2130e403aaa558a04ffa664e6f4f0f38d1b1) BUG=471990 TBR=jun_fang@foxitsoftware.com Review URL: https://codereview.chromium.org/1218273002.
2015-07-01Cherry-pick to XFA: Fix a clang warning about a dangling else.Tom Sepez
BUG=none R=brucedawson@chromium.org Review URL: https://codereview.chromium.org/1223433002.
2015-07-01Cherry-pick to XFA: Fix some clang warnings with -Wmissing-braces in pdfium.Nico Weber
Clang warns if there are missing braces around a subobject initializer. The most common idiom that triggers this is: STRUCT s = {0}; if the first field of STRUCT is itself a struct. This can be more simply written as: STRUCT s = {}; which also prevents the warning from firing. Other instances of the warning have been fixed by adding braces where appropriate. R=brucedawson@chromium.org Review URL: https://codereview.chromium.org/1213523004.
2015-06-19Merge to XFA: Replace some CFX_MapPtrTemplates with std::map.Lei Zhang
There are more CFX_MapPtrTemplate usage on the XFA branch, so it is not removed. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1181593003. (cherry picked from commit e8d3691c82d1be805ffdce3329d00313af7ce0ab) Review URL: https://codereview.chromium.org/1198663004.
2015-06-19Merge to XFA: Cleanup: Do not check pointers before deleting them.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1192743004. (cherry picked from commit cfac954abcab7caf47d3fa3d641c553cba998271) Review URL: https://codereview.chromium.org/1196783003.
2015-06-19Merge to XFA: Cleanup: Remove dead CPDF_InlineImages code.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1192413007. (cherry picked from commit 59d60a587180cb6bbd49d4e739fb6ccd2b15d4d2) Review URL: https://codereview.chromium.org/1192753008.
2015-06-19Merge to XFA: Small cleanup of CPDF_TextObject and other CPDF_PageObject ↵Lei Zhang
subclasses. - Add overrides - Remove empty overrides - Remove dead friends - Cleanup bad formatting R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1199563002. (cherry picked from commit df558514bf5cb5750d5a7000a843f45f4170d5a4) Review URL: https://codereview.chromium.org/1198713002.
2015-06-19Merge to XFA: Make CPDF_PageModuleDef and CPDF_RenderModuleDef pure virtual.Lei Zhang
Get rid of the dummy implementations, which are never used when the modules have been initialized. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1177383003. (cherry picked from commit 5fef754bc09e971f1bf1ba79da98c0a7ee1e1c8d) Review URL: https://codereview.chromium.org/1189413006.
2015-06-19Merge to XFA: Do some IWYU cleanups.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1176333002. (cherry picked from commit 0ef0de55657db8a83372ad8eb22d84c5893afc4c) Review URL: https://codereview.chromium.org/1195943005.
2015-06-19Merge to XFA: Fix -Winconsistent-missing-override warnings.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1187463003. (cherry picked from commit 8bd09648445aef8a9ae38d9f61618bd2013ac3f0) Review URL: https://codereview.chromium.org/1194173002.
2015-06-19Fix -Wnon-virtual-dtor warnings on the XFA branch.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1183483003.
2015-06-19Merge to XF: Disintermediation.Tom Sepez
(cherry picked from commit 012ada613a1462f109eb59790f8e5ee91aacdb7e) Review URL: https://codereview.chromium.org/1199553002. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1197893002.
2015-06-19Merge to XFA: Move zlib to third_party/Tom Sepez
(cherry picked from commit 959eb05140a8f5af7724a2da4cf5d04e2e50f4a6) Original Review URL: https://codereview.chromium.org/1197693003. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1197863002.
2015-06-18Merge to XFA: Move libopenjpeg to third_party/Tom Sepez
Original Review URL: https://codereview.chromium.org/1185373010. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1193773002.
2015-06-18Fix XFA builds under chromium checkoutsTom Sepez
This pulls in from origin/master: 94dd28e Update GN build files w/ cpu_arch -> current_cpu changes. 1e580a1 Fix multiply defined macro in zlib.h Add a missing file to BUILD.gn dropped at 1ed8a21. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1189133006.
2015-06-18Merge to XFA: Fix CPDF_ICCBasedCS::GetDefaultValue heap-buffer-overflow.Tom Sepez
Original Review URL: https://codereview.chromium.org/1179773007. BUG=501889 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1180843012.
2015-06-18Replace some Release() calls with virtual destructors.Tom Sepez
Required fixing xfa-specific code. Original Review URL: https://codereview.chromium.org/1192013002. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1176413004.
2015-06-17Merge to XFA: Move libjpeg to third_party/Tom Sepez
Original Review URL: https://codereview.chromium.org/1186113005. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1175193007.
2015-06-17Merge to XFA: Move lcms2 into third_partyTom Sepez
Original Review URL: https://codereview.chromium.org/1181943008. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1187273006.
2015-06-17Merge to XFA: Separate agg-authored code from fx-authored code.Tom Sepez
Original Review URL: https://codereview.chromium.org/1152743007. BUG=pdfium:166 R=brucedawson@chromium.org, thestig@chromium.org TBR=brucedawson@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/1186423003.
2015-06-16Merge to XF: Add constructor for CPDF_ColorSpace.Tom Sepez
Original review URL: https://codereview.chromium.org/1185903002. BUG=pdfium:170 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1182083004.
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-28 07:42:52 +0000