Age | Commit message (Collapse) | Author |
|
Original Review URL: https://codereview.chromium.org/1171733003
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1178613002.
|
|
Near-automatic merge, plus re-running scripts to update
additional usage.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1172793002
|
|
New manual edits in the following to fix compilation:
fx_bmp.h, fx_gif.h, fx_graphics.h
Original Review URL: https://codereview.chromium.org/1169963003
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1170103004
|
|
CPDF_DIBSource::LoadJpxBitmap().
Leaks can happen in several places. For this particular bug, it happens
when there is a colorspace component count mismatch.
BUG=497191
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1153633009
(cherry picked from commit 2a824f1c0ed786aed0dd15a0ea60dc90999e2b2c)
Review URL: https://codereview.chromium.org/1168833002
|
|
Remove dead code in CPDF_Annot as well.
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1157773012
(cherry picked from commit b7eb193dcec1594952cbc1dca356a40f66724159)
Review URL: https://codereview.chromium.org/1157323005
|
|
Original Review URL: https://codereview.chromium.org/1162203007
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1154023005
|
|
Original Review URL: https://codereview.chromium.org/1147353006
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1152693005
|
|
Original Review URL: https://codereview.chromium.org/1168503003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1153033009
|
|
Original Review URL: https://codereview.chromium.org/1165863003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1163113002
|
|
Original Review URL: https://codereview.chromium.org/1158053003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1156203004
|
|
Original Review URL: https://codereview.chromium.org/1160443004
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1162013003
|
|
Original Review URL: https://codereview.chromium.org/1162453003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1154613005
|
|
BUG=459215
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1160663002
|
|
Original Review URL: https://codereview.chromium.org/1148353002
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1150103002
|
|
This issue is trigged by the conversion from unsigned int to signed int.
A large unsigned int is converted to int. It's represented as a negative
int which is used in the condition of while later.
BUG=482639
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1146913003
|
|
1. New size should be larger than old size in JBig2_Realloc.
2. Arguments are integers but parameters are size_t in JBIG2_memset.
After integer overflows, it will be presented as a huge
unsigned number on 64 bits system.
BUG=483981
R=brucedawson@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1148643002
|
|
Original Review URL: https://codereview.chromium.org/1142713005
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1143663008
|
|
Integer overflow in CJBig2_Image::expand.
It causes the size of reallocated is not
expected.
BUG=483981
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1131023008
|
|
opj_j2k_copy_default_tcp_and_create_tcd().
Original Review URL: https://codereview.chromium.org/1138033007
BUG=486538
TBR=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1142133002
|
|
This CL is used for:
1. keeping the same logic as before (the behaviour
of FX_Alloc was changed for OOM).
2. fixing a potential integer overflow.
BUG=N/A
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1126013006
|
|
Original Review URL: https://codereview.chromium.org/1143663004
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1136673005
|
|
Original Review URL: https://codereview.chromium.org/1128043009
Original Review URL: https://codereview.chromium.org/1142463005
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1144683002
|
|
FlateEncode().
For FlateEncode(), error handling code leaked memory.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1144603002
(cherry picked from commit 1962d61b28df03284e3e5c6de6a19f397a066e68)
Review URL: https://codereview.chromium.org/1125413008
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1137933004
(cherry picked from commit acae9257203971ee1e34d8d7573b7ba9a50041af)
BUG=
Review URL: https://codereview.chromium.org/1135793003
|
|
Also change EmbedderTest::TearDown() to match the destruction order in
Chromium's PDF code.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1138143003
(cherry picked from commit 61ffad8df484ab9b3f7d2f5519ec470fbc023b88)
Review URL: https://codereview.chromium.org/1138973004
|
|
Original Review URL: https://codereview.chromium.org/1135273004
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1134003007
|
|
Original Review URL: https://codereview.chromium.org/1130763007
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1123333004
|
|
Original Review URL: https://codereview.chromium.org/1142533002
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1135673003
|
|
BUG=471991
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1141613002
|
|
Original Review URL: https://codereview.chromium.org/1141763002
BUG=pdfium:160
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1140093003
|
|
Original Review URL: https://codereview.chromium.org/1133323003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1130903005
|
|
Original Review URL: https://codereview.chromium.org/1135913002
BUG=pdfium:154
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1136703003
|
|
Also fix a few nits and other errors along the way.
Review URL: https://codereview.chromium.org/1098583002
Review URL: https://codereview.chromium.org/1135713004
(cherry picked from commit f0a169e6fd5718995fa6ef8749c8d16cdad84985)
(cherry picked from commit 470408c2ffe71e99cebad0d1d6887f1723f02cef)
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1133453006
|
|
Original Review URL: https://codereview.chromium.org/1128193004
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1137783002
|
|
Original Review URL: https://codereview.chromium.org/1132163002
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1128933004
|
|
- Check bounds when accessing array.
- Remove potential memory leak.
- Merge duplicate code.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1094763002
(cherry picked from commit ee2fe42f9bf3ac6afc4f05f79629a3e34179a2b9)
Review URL: https://codereview.chromium.org/1128803003
|
|
Original Review URL: https://codereview.chromium.org/1130053003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1124353002
|
|
Original Review URL: https://codereview.chromium.org/1124043003
BUG=pdfium:153
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1132443002
|
|
BUG=484002
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1124563002
(cherry picked from commit 6ab919ff310fb02bab8cf43d92a5553b11cbbb61)
Review URL: https://codereview.chromium.org/1130903002
|
|
Review URL: https://codereview.chromium.org/1084303002
(cherry picked from commit cfc1a654ef3e8b65bc447815d35932c185bf1422)
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1125363002
|
|
Very few places where a change is required, but remove FX_NEW to show
they've been audited.
Review URL: https://codereview.chromium.org/1075953004
(cherry picked from commit 5c357a5d3d873be6b0ab01d7bec82f79d0a09f0e)
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1125183006
|
|
This regressed in commit 3f41851 due to shadow variables.
BUG=478164
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1101443004
(cherry picked from commit 97d10aff654e42c1b7c3d2abf33fbcf8d341799e)
Review URL: https://codereview.chromium.org/1127163003
|
|
Original Review URL: https://codereview.chromium.org/1127043004
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1131553005
|
|
Besides the merge, there's one place where a wchar vs. wstring
comparison was being made that no longer compiled.
Original Review URL: https://codereview.chromium.org/1117263004
BUG=pdfium:151
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1116163003
|
|
Original Review URL: https://codereview.chromium.org/1127753002
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1119753004
|
|
Original Review URL: https://codereview.chromium.org/1129433002
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1122903002
|
|
Original Review URL: https://codereview.chromium.org/1125703004
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1126643003
|
|
Original Review URL: https://codereview.chromium.org/1118973005
Original Review URL: https://codereview.chromium.org/1122573002
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1126433002
|
|
Original Review URL: https://codereview.chromium.org/1117413002
Original Review URL: https://codereview.chromium.org/1118983003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1125493002
|
|
Original Review URL: https://codereview.chromium.org/1112423003
Original Review URL: https://codereview.chromium.org/1120703003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1120813003
|