Age | Commit message (Collapse) | Author |
|
Original Review URL: https://codereview.chromium.org/1133323003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1130903005
|
|
Original Review URL: https://codereview.chromium.org/1135913002
BUG=pdfium:154
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1136703003
|
|
Also fix a few nits and other errors along the way.
Review URL: https://codereview.chromium.org/1098583002
Review URL: https://codereview.chromium.org/1135713004
(cherry picked from commit f0a169e6fd5718995fa6ef8749c8d16cdad84985)
(cherry picked from commit 470408c2ffe71e99cebad0d1d6887f1723f02cef)
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1133453006
|
|
Original Review URL: https://codereview.chromium.org/1128193004
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1137783002
|
|
Original Review URL: https://codereview.chromium.org/1132163002
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1128933004
|
|
- Check bounds when accessing array.
- Remove potential memory leak.
- Merge duplicate code.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1094763002
(cherry picked from commit ee2fe42f9bf3ac6afc4f05f79629a3e34179a2b9)
Review URL: https://codereview.chromium.org/1128803003
|
|
Original Review URL: https://codereview.chromium.org/1130053003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1124353002
|
|
Original Review URL: https://codereview.chromium.org/1124043003
BUG=pdfium:153
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1132443002
|
|
BUG=484002
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1124563002
(cherry picked from commit 6ab919ff310fb02bab8cf43d92a5553b11cbbb61)
Review URL: https://codereview.chromium.org/1130903002
|
|
Review URL: https://codereview.chromium.org/1084303002
(cherry picked from commit cfc1a654ef3e8b65bc447815d35932c185bf1422)
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1125363002
|
|
Very few places where a change is required, but remove FX_NEW to show
they've been audited.
Review URL: https://codereview.chromium.org/1075953004
(cherry picked from commit 5c357a5d3d873be6b0ab01d7bec82f79d0a09f0e)
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1125183006
|
|
This regressed in commit 3f41851 due to shadow variables.
BUG=478164
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1101443004
(cherry picked from commit 97d10aff654e42c1b7c3d2abf33fbcf8d341799e)
Review URL: https://codereview.chromium.org/1127163003
|
|
Original Review URL: https://codereview.chromium.org/1127043004
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1131553005
|
|
Besides the merge, there's one place where a wchar vs. wstring
comparison was being made that no longer compiled.
Original Review URL: https://codereview.chromium.org/1117263004
BUG=pdfium:151
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1116163003
|
|
Original Review URL: https://codereview.chromium.org/1127753002
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1119753004
|
|
Original Review URL: https://codereview.chromium.org/1129433002
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1122903002
|
|
Original Review URL: https://codereview.chromium.org/1125703004
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1126643003
|
|
Original Review URL: https://codereview.chromium.org/1118973005
Original Review URL: https://codereview.chromium.org/1122573002
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1126433002
|
|
Original Review URL: https://codereview.chromium.org/1117413002
Original Review URL: https://codereview.chromium.org/1118983003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1125493002
|
|
Original Review URL: https://codereview.chromium.org/1112423003
Original Review URL: https://codereview.chromium.org/1120703003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1120813003
|
|
Original Review URL: https://codereview.chromium.org/1053613004
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1115493002
|
|
Original Review URL: https://codereview.chromium.org/1110653002
R=thestig@chromium.org
TBR=thestig@chromium.org
BUG=481363
Review URL: https://codereview.chromium.org/1110763002
|
|
Original Review URL: https://codereview.chromium.org/1103343002
R=brucedawson@chromium.org
TBR=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1105253002
|
|
Original Review URL: https://codereview.chromium.org/1101933003
TBR=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1108903002
|
|
BUG=467392
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1064713008
|
|
This pulls in:
Review URL: https://codereview.chromium.org/1099193002
Review URL: https://codereview.chromium.org/1090303003
Review URL: https://codereview.chromium.org/1084293003
Review URL: https://codereview.chromium.org/1099213002
Plus one fix to an XFA file to fix compilation.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1095893005
|
|
Original Review URL: https://codereview.chromium.org/1098203002
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1080633008
|
|
BUG=453553
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1093323003
|
|
Includes:
Original Review URL: https://codereview.chromium.org/1098043002
Original Review URL: https://codereview.chromium.org/1097843003
Original Review URL: https://codereview.chromium.org/1093213002
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1092033004
|
|
Original Review URL: https://codereview.chromium.org/1060813003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1060843005
|
|
BUG=N/A
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1092993002
|
|
This fix is for covering more scenarios. Some faces like Foxit defined faces and MM faces are managed in built-in manager. They are released in built-in manager not in fontMgr.
BUG=452793
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1095733003
|
|
Adjust the release order of resource to fix this issue.
BUG=452793
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1082023002
|
|
BUG=380476
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1061013003
|
|
Original Review URL: https://codereview.chromium.org/1082253003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1061843005
|
|
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1085963002
|
|
Not just a simple merge, but changes to remove CFX_Object from XFA.
Original Review URL: https://codereview.chromium.org/1088733002
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1087053002
|
|
BUG=476107
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1080893002
|
|
TBR=tsepez@chromium.org
BUG=N/A
Review URL: https://codereview.chromium.org/1081663002
|
|
Add a check to make sure offset is less than the size of string in the function of GetNextChar().
BUG=471651
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1067073003
|
|
Three functions in fx_coordinates.h account for 60% of the warnings
when building with VS 2015, due to variable shadowing. Renaming the
function parameters is safe, resolves the warnings, and reduces
confusion.
From https://codereview.chromium.org/1077083003
TBR=tsepez@chromium.org
BUG=440500
Review URL: https://codereview.chromium.org/1077283002
|
|
TBR=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1073313003
|
|
A stack overflow was triggered by checked_cast due to
invalid index in pdf files like 'Index[45 -1661]'.
BUG=473400
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1054303005
|
|
Original Review URL: https://codereview.chromium.org/1071343002
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1079623002
|
|
GCPDF_CIDFont::_CharCodeFromUnicode
There is not a code page (CP) used for converting unicode to mutli-bytes
if the coding scheme is CID coding. Only return 0 if CID can't be retrieved.
The difference on Windows and other platforms should be the function used
for converting rather than others.
BUG=466790
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1074653002
|
|
BUG=469244
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1062983002
|
|
This incorporates class vs. struct fix in 34f5fc0f2a18
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1063283002
|
|
Note: new includes for XFA
Original Review URL: https://codereview.chromium.org/1064433005
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1062843003
|
|
chrome
BUG=N/A
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1059233005
|
|
Adds a comment and changes some whitespace.
TBR=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1059373002
|