Age | Commit message (Collapse) | Author |
|
BUG=none
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1223433002.
|
|
Clang warns if there are missing braces around a subobject
initializer. The most common idiom that triggers this is:
STRUCT s = {0};
if the first field of STRUCT is itself a struct. This can
be more simply written as:
STRUCT s = {};
which also prevents the warning from firing.
Other instances of the warning have been fixed by adding
braces where appropriate.
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1213523004.
|
|
There are more CFX_MapPtrTemplate usage on the XFA branch, so it is
not removed.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1181593003.
(cherry picked from commit e8d3691c82d1be805ffdce3329d00313af7ce0ab)
Review URL: https://codereview.chromium.org/1198663004.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1192743004.
(cherry picked from commit cfac954abcab7caf47d3fa3d641c553cba998271)
Review URL: https://codereview.chromium.org/1196783003.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1192413007.
(cherry picked from commit 59d60a587180cb6bbd49d4e739fb6ccd2b15d4d2)
Review URL: https://codereview.chromium.org/1192753008.
|
|
subclasses.
- Add overrides
- Remove empty overrides
- Remove dead friends
- Cleanup bad formatting
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1199563002.
(cherry picked from commit df558514bf5cb5750d5a7000a843f45f4170d5a4)
Review URL: https://codereview.chromium.org/1198713002.
|
|
Get rid of the dummy implementations, which are never used when
the modules have been initialized.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1177383003.
(cherry picked from commit 5fef754bc09e971f1bf1ba79da98c0a7ee1e1c8d)
Review URL: https://codereview.chromium.org/1189413006.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1176333002.
(cherry picked from commit 0ef0de55657db8a83372ad8eb22d84c5893afc4c)
Review URL: https://codereview.chromium.org/1195943005.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1187463003.
(cherry picked from commit 8bd09648445aef8a9ae38d9f61618bd2013ac3f0)
Review URL: https://codereview.chromium.org/1194173002.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1183483003.
|
|
(cherry picked from commit 012ada613a1462f109eb59790f8e5ee91aacdb7e)
Review URL: https://codereview.chromium.org/1199553002.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1197893002.
|
|
(cherry picked from commit 959eb05140a8f5af7724a2da4cf5d04e2e50f4a6)
Original Review URL: https://codereview.chromium.org/1197693003.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1197863002.
|
|
Original Review URL: https://codereview.chromium.org/1185373010.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1193773002.
|
|
This pulls in from origin/master:
94dd28e Update GN build files w/ cpu_arch -> current_cpu changes.
1e580a1 Fix multiply defined macro in zlib.h
Add a missing file to BUILD.gn dropped at 1ed8a21.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1189133006.
|
|
Original Review URL: https://codereview.chromium.org/1179773007.
BUG=501889
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1180843012.
|
|
Required fixing xfa-specific code.
Original Review URL: https://codereview.chromium.org/1192013002.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1176413004.
|
|
Original Review URL: https://codereview.chromium.org/1186113005.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1175193007.
|
|
Original Review URL: https://codereview.chromium.org/1181943008.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1187273006.
|
|
Original Review URL: https://codereview.chromium.org/1152743007.
BUG=pdfium:166
R=brucedawson@chromium.org, thestig@chromium.org
TBR=brucedawson@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1186423003.
|
|
Original review URL: https://codereview.chromium.org/1185903002.
BUG=pdfium:170
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1182083004.
|
|
Original Review URL: https://codereview.chromium.org/1182903002.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1191553005.
|
|
CPDF_DocPageData::GetFontFileStreamAcc().
The input cannot be null. Same for CPDF_Document::LoadFontFile().
Also set the contract for CPDF_Document::LoadFont() and adjust callers
accordingly.
Also remove unused CPDF_Document::FindFont().
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1184673002.
(cherry picked from commit 1972b16849fedfda675eacd5c8594b54dbd1264d)
Review URL: https://codereview.chromium.org/1181393002.
|
|
Review URL: https://codereview.chromium.org/1180333002.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1181803002.
(cherry picked from commit f25db681003f0247e97bfef22be56a8aa02b7595)
Review URL: https://codereview.chromium.org/1182993002.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1173223002.
(cherry picked from commit 2b5e0d5b20654d116045484868c9e015ed698124)
Review URL: https://codereview.chromium.org/1186673004.
|
|
If the font is 'tricky', it needs to be hinted by default according to the description in freetype.
BUG=490814
TBR=jun_fang@foxitsoftware.com
Original Review URL: https://codereview.chromium.org/1170313003.
Review URL: https://codereview.chromium.org/1175243008.
|
|
Only manual merge was core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp
follwed by scripts.
Original Review URL: https://codereview.chromium.org/1179693003.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1179953002.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1144333008.
(cherry picked from commit f726c92cb2cf5739fd5b21e825e5bf510040c62f)
Review URL: https://codereview.chromium.org/1180653004.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1143133008.
(cherry picked from commit 77713645f64214b8d5e79f62a92bb03452ce232e)
Review URL: https://codereview.chromium.org/1179693004.
|
|
Also simplify CPDF_DocPageData::ReleaseIccProfile() since its first
argument is always null.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1149273004.
(cherry picked from commit a8a718c974210a919f2af0b099d540143cf330c6)
Review URL: https://codereview.chromium.org/1180613004.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1162123004.
(cherry picked from commit b3aa96cbee31e81d0a72a61027467a2713654499)
Review URL: https://codereview.chromium.org/1181573005.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1154963003.
(cherry picked from commit 22f429fc4875027b10ab071102c9ac8a88abf825)
Review URL: https://codereview.chromium.org/1179783002.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1151133004.
(cherry picked from commit 3c949d5d2b0d680839766ea99c86b263230b263d)
Review URL: https://codereview.chromium.org/1174173005.
|
|
Nearly automatic merge + re-run script on new files.
Original Review URL: https://codereview.chromium.org/1180593004.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1174303002.
|
|
BUG=495300
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1178513002.
(cherry picked from commit 7b2897c47245f04c806cfa8cee09458e31ba3777)
Review URL: https://codereview.chromium.org/1177003002.
|
|
Original Review URL: https://codereview.chromium.org/1171733003
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1178613002.
|
|
Near-automatic merge, plus re-running scripts to update
additional usage.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1172793002
|
|
New manual edits in the following to fix compilation:
fx_bmp.h, fx_gif.h, fx_graphics.h
Original Review URL: https://codereview.chromium.org/1169963003
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1170103004
|
|
CPDF_DIBSource::LoadJpxBitmap().
Leaks can happen in several places. For this particular bug, it happens
when there is a colorspace component count mismatch.
BUG=497191
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1153633009
(cherry picked from commit 2a824f1c0ed786aed0dd15a0ea60dc90999e2b2c)
Review URL: https://codereview.chromium.org/1168833002
|
|
Remove dead code in CPDF_Annot as well.
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1157773012
(cherry picked from commit b7eb193dcec1594952cbc1dca356a40f66724159)
Review URL: https://codereview.chromium.org/1157323005
|
|
Original Review URL: https://codereview.chromium.org/1162203007
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1154023005
|
|
Original Review URL: https://codereview.chromium.org/1147353006
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1152693005
|
|
Original Review URL: https://codereview.chromium.org/1168503003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1153033009
|
|
Original Review URL: https://codereview.chromium.org/1165863003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1163113002
|
|
Original Review URL: https://codereview.chromium.org/1158053003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1156203004
|
|
Original Review URL: https://codereview.chromium.org/1160443004
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1162013003
|
|
Original Review URL: https://codereview.chromium.org/1162453003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1154613005
|
|
BUG=459215
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1160663002
|
|
Original Review URL: https://codereview.chromium.org/1148353002
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1150103002
|
|
This issue is trigged by the conversion from unsigned int to signed int.
A large unsigned int is converted to int. It's represented as a negative
int which is used in the condition of while later.
BUG=482639
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1146913003
|