Age | Commit message (Collapse) | Author |
|
Move FX_XML_SplitQualifiedName() out of CXML_Parser, and add
CXML_Element::MatchesElement().
Change-Id: I34adc6f3b19e745ae33db0edf65184346cc1c13f
Reviewed-on: https://pdfium-review.googlesource.com/21073
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Change-Id: I9ebacd18252a837f1f5f13ccaec19b196bacc3ae
Reviewed-on: https://pdfium-review.googlesource.com/21072
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
It has an unused parameter.
Change-Id: Iae92b8f84bc560055cb0cd730a0fe52c8bd9dd79
Reviewed-on: https://pdfium-review.googlesource.com/21071
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Bug: 541
Change-Id: I43bb09312b0d7312207e5c235ba80a2593877d07
Reviewed-on: https://pdfium-review.googlesource.com/21070
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Move non-trivial implementations into the .cpp file as well.
Change-Id: Iebe7d7284e453c6405cddfe880e2c85aa0c804ab
Reviewed-on: https://pdfium-review.googlesource.com/21050
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Routine roll, with update for a removed API call.
https://chromium.googlesource.com/skia/+log/d6c04d9a..40ca2087
Change-Id: I938b214fbb79cea6fed99edb5ca7d90a779bb8e8
Reviewed-on: https://pdfium-review.googlesource.com/20930
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: I3ea13ace6290e8fab41a3f65c9ac047407a74e4d
Reviewed-on: https://pdfium-review.googlesource.com/20852
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Also add a GetUnicodeFromBytes() helper function and use
FX_INVALID_OFFSET more often.
Change-Id: I3b0954e0cad31a600b0a990360ab370186c792d6
Reviewed-on: https://pdfium-review.googlesource.com/20850
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: Ic3dbc07ac80ad48fd670c090027cc151afc61e7f
Reviewed-on: https://pdfium-review.googlesource.com/20890
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Add LoadAllDataFiltered() and LoadAllDataRaw() and update callers.
Change-Id: I9b80ee34a358db204968acdc8b1adc9db0b6b83f
Reviewed-on: https://pdfium-review.googlesource.com/20810
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
|
|
Also initialize members in the header.
Change-Id: Ic1cda7f9ef4c69e26604c706678aed24bf4e8ee3
Reviewed-on: https://pdfium-review.googlesource.com/20790
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: I13b297ddb080b478a30a959889941b46feb363b3
Reviewed-on: https://pdfium-review.googlesource.com/20770
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: I45bac6e1b3fb9ae90feff1dc65c716beb2cab4c4
Reviewed-on: https://pdfium-review.googlesource.com/20771
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Change-Id: Ia7ab625bcf802d0f6b15985065b7e0c3584bb2f1
Reviewed-on: https://pdfium-review.googlesource.com/20750
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Bug:
Change-Id: I4e25e96bbcade72115722ac7540d0d186cd2dc03
Reviewed-on: https://pdfium-review.googlesource.com/20631
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Bug:
Change-Id: I394fb3c6df95d5170302731fd33ef523a38f070c
Reviewed-on: https://pdfium-review.googlesource.com/20630
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Bug:
Change-Id: I86b4c72343288d83d51f493d3d888aad45baed5a
Reviewed-on: https://pdfium-review.googlesource.com/20610
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Also fixes some usages that were not working as intended after the
conversion to static.
Change-Id: I18c18369754f6ca165f98999b5b80eecf6c76973
Reviewed-on: https://pdfium-review.googlesource.com/20590
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
Change-Id: I0caba99cb8e99ea5af49d906b576f580275620bb
Reviewed-on: https://pdfium-review.googlesource.com/20570
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
BUG=pdfium:951
Change-Id: I4b82ce81c8db3f00fa2341c6fb853ed84814e5e5
Reviewed-on: https://pdfium-review.googlesource.com/20510
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
|
|
m_CharCodes is getting corrupted and it's difficult to tell why. This
moves it to a local variable before it is destroyed so that the
corruption - which should be copied over - will be stored in the crash
dump.
Bug: 782215
Change-Id: Ifd09b21396bf28bca69f2b4082c61cbc4782e209
Reviewed-on: https://pdfium-review.googlesource.com/20530
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Also fix other occurrences that were missed.
Bug:pdfium:947
Change-Id: Ic7e909ff9ce3abdf91e8e9ba108c84ad28b2fd65
Reviewed-on: https://pdfium-review.googlesource.com/20472
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
Change-Id: I80be0de1a7d9ba502b4468bc13a4595566f8fb30
Reviewed-on: https://pdfium-review.googlesource.com/20432
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Either switch to std::lower_bound(), or brute force when the search
space is very small.
Change-Id: I54db346aeb6f2e8000e95a6a9c8fbdd512df500a
Reviewed-on: https://pdfium-review.googlesource.com/20431
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Use std::lower_bound() instead.
Change-Id: I0bed2a90f3aa427a283cd86a050a027ec7a64358
Reviewed-on: https://pdfium-review.googlesource.com/20430
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Change-Id: Ibac6398b5849820562830bb8ed95c3428496f7ef
Reviewed-on: https://pdfium-review.googlesource.com/20410
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Use floating point math and saturated_cast to calculate the transform.
Refactor CFX_BilinearMatrix::Transform() to share common code, instead
of using integer math and CheckedNumerics.
BUG=chromium:791048
Change-Id: Ib3812b3b3b9373a8eb3b1dde12cb28d424e0bb3e
Reviewed-on: https://pdfium-review.googlesource.com/20390
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Also add a comment about the various CFX_FloatRect to FX_RECT conversion
methods.
Change-Id: Ia9984797dc513cdc487fe9972b32c216c9f99ec1
Reviewed-on: https://pdfium-review.googlesource.com/20217
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
|
|
Change-Id: I14e614dbd0b7c1187b686bf574d14b94f04a3e7e
Reviewed-on: https://pdfium-review.googlesource.com/20271
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Also fix lint errors.
Change-Id: Iaf5fb440fd43d5c36b00630e16d700827c09fc7f
Reviewed-on: https://pdfium-review.googlesource.com/20270
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Change-Id: Ib3aa0b6ce2fa7b2a643068cb9ffcaca9fe18d3de
Reviewed-on: https://pdfium-review.googlesource.com/20258
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Change-Id: I47c0ae6dbdf339ab7ade36b141c220b8a3fb2274
Reviewed-on: https://pdfium-review.googlesource.com/20257
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Change-Id: Ia38329bf5622c0ae6f5c4173332d2140de08c567
Reviewed-on: https://pdfium-review.googlesource.com/20256
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Change-Id: I5d3a01310bd5fcddbb8c39025b07a2e83ddae84f
Reviewed-on: https://pdfium-review.googlesource.com/20255
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Change-Id: Ibd9ca20e902bbd2b62af12d25836497413912b1b
Reviewed-on: https://pdfium-review.googlesource.com/20254
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Use it in type 3 font code.
Change-Id: I8b0eb462cc0308f1700d21a62efc929babae8e20
Reviewed-on: https://pdfium-review.googlesource.com/20215
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: I4f221d5d6c17e8507f87d9c63b87431cc2b8f45e
Reviewed-on: https://pdfium-review.googlesource.com/20253
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Change-Id: Ib922184ee844e66a0b29f49025e83e13eb81fdb8
Reviewed-on: https://pdfium-review.googlesource.com/20214
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
|
|
Change-Id: Iab7ff29c2ce9ed56715b5897e89da2d9d693583c
Reviewed-on: https://pdfium-review.googlesource.com/20252
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Change-Id: I556934f61f24883e684865e4a8fc5e0519248cee
Reviewed-on: https://pdfium-review.googlesource.com/20251
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Change-Id: I3efc57cd7325d16e3ca8ebdeeaec06012b2c56e3
Reviewed-on: https://pdfium-review.googlesource.com/20110
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Bug: 790693
Change-Id: I9b1d87e024229d8b01f55ec554e2cc544db6ac06
Reviewed-on: https://pdfium-review.googlesource.com/20230
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
|
|
Unlike ToFxRect(), which floors the LBRT values. Also fix some nits.
Change-Id: I0680eebb09031807a14402ca30b13558ea5b56d9
Reviewed-on: https://pdfium-review.googlesource.com/20213
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
|
|
Unlike ScaleFromCenterPoint(), Scale() just scales the LBRT values.
Also add unit tests for CFX_FloatRect::Normalize().
Change-Id: Iebf48fa9adcf47adff3255b157d3e3056f3687fc
Reviewed-on: https://pdfium-review.googlesource.com/20212
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
|
|
Change-Id: I6baab14c989e8ae692ed1c846b135af95c09ce37
Reviewed-on: https://pdfium-review.googlesource.com/20210
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
|
|
Change-Id: I08706f53bf3960cbea60b09a1702bf0ba371f1ce
Reviewed-on: https://pdfium-review.googlesource.com/20211
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: I32cc3cb0a8a987980b900a5650cc051cb50dd1cc
Reviewed-on: https://pdfium-review.googlesource.com/20190
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
|
|
This CL continues removing structs from CFX_CTTGSUBTable
Change-Id: I1ede1e3e736f87292b6119406fd5f12a0bb7e7cb
Reviewed-on: https://pdfium-review.googlesource.com/20170
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
|
|
Change-Id: Iec4e999d76dabc9b6cd00323881c5c87afc5f629
Reviewed-on: https://pdfium-review.googlesource.com/19930
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
The current implementation of text extraction was difficult to
understand, duplicated logic that existed in other methods, and wasn't
clear about the units the inputs were in. It also didn't handle
control characters correctly.
The new implementation leans on the methods for converting indices
between the text buffer index and character list index spaces to avoid
duplication of code. It also makes it clear to the reader that inputs
are in the character list index space. Finally, it fixes issues being
seen in Chrome with respect of ranges being slightly off.
This CL also adds a test for extracting text that has control
characters.
BUG=pdfium:942,chromium:654578
Change-Id: Id9d1f360c2d7492c7b5a48d6c9ae29f530892742
Reviewed-on: https://pdfium-review.googlesource.com/20014
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
|