Age | Commit message (Collapse) | Author |
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1572523002 .
|
|
Also remove a bunch of dead code.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1565803003 .
(cherry picked from commit cbed99098ad4cdc3f9f260cc1e8521f67c12d35d)
Review URL: https://codereview.chromium.org/1569483004 .
|
|
R=jun_fang@foxitsoftware.com, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1566903002 .
|
|
BUG=572871
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1564773003 .
(cherry picked from commit dcac57bc8b64fdc870d79d11a498ae7021cf8ae7)
Review URL: https://codereview.chromium.org/1569663002 .
|
|
Also do some cleanups in affected files.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1552583002 .
(cherry picked from commit d794d34b5deb6ad691c19af758090f9ce46015a3)
Review URL: https://codereview.chromium.org/1566583002 .
|
|
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1549103002 .
(cherry picked from commit a3235d0f5ca92c89b1de0f135a05e9891e499fb9)
Review URL: https://codereview.chromium.org/1560183003 .
|
|
BUG=546744
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1542373002 .
(cherry picked from commit ae58ed8bccc56dd78c12d89972b19d58de94f790)
Review URL: https://codereview.chromium.org/1548093002 .
|
|
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1547833002 .
(cherry picked from commit d20dfba2ae10e8aeb328328f09da79ff904110a8)
Review URL: https://codereview.chromium.org/1545183002 .
|
|
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1544953002 .
(cherry picked from commit cd0ade6f77b1a3e7c340a05bc6cb448f52e9bb96)
Review URL: https://codereview.chromium.org/1547843003 .
|
|
Review URL: https://codereview.chromium.org/1513363002 .
(cherry picked from commit f32c969bce6743fca1e7ff796b54a1692d26d7f0)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1519693002 .
|
|
-- label matching #endifs
-- prefer #ifdef over #ifndef
-- consolidate some blocks.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1484843002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1477583002 .
|
|
Precursor to https://codereview.chromium.org/1477583002/
Also:
whitespace in fxjs_v8.h
Merge where possible.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1472363003 .
|
|
The incorrect page index may cause a crasher in the following
procedure.
BUG=pdfium:285
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1466423004 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1474663004 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1469413002 .
|
|
See the comment in fsdk_define.h. Also tidy up a bit,
and remove dead DeletePages(). This should help us
match master more closely (given corresponding changes
on the master side).
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1473503002 .
|
|
Bumping this one line from 6 to 7 in XFA saves a bunch of diffs.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1458363005 .
(cherry picked from commit 7711b60efc62db14748711727560367d948745f1)
BUG=
Review URL: https://codereview.chromium.org/1470563002 .
|
|
Original Review URL: https://codereview.chromium.org/1467653002 .
(cherry picked from commit 54bc568bb41c5c258e95c24ef9d7355dcdc20f9e)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1466743003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1463973002 .
|
|
Using Chromium's clang + build options, there's more override warnings.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1453643002 .
(cherry picked from commit 126ba519bdd489ec6c285d1410dcae773e8ef673)
Review URL: https://codereview.chromium.org/1458373002 .
|
|
That refer to parent directories.
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1434223002 .
(cherry picked from commit 22bc4227fbbda5a5e9abad2a2c0a98c04fe7f228)
Review URL: https://codereview.chromium.org/1439223003 .
|
|
Original Review URL: https://codereview.chromium.org/1424933013 .
(cherry picked from commit 7d4c74d1b96d82681d49519c129262a1568e87d4)
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/1407063012 .
|
|
The PDF-side native objects require that the current v8 context
has been set-up to point at the state (via CJS_Runtime) for the
getters, setters, and methods to operate against. XFA doesn't
supply a context with that state, so at the first opportunity for
a PDF-side object to be leaked to XFA, set up the context to mimic
the PDF side.
Changed FXJS_GetRuntimeFromIsolate() to FXJS_GetRuntimeFromV8Context()
for consistency with the newly added method.
BUG=pdfium:266
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1412103010 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1430213002 .
(cherry picked from commit 8deeacd23872ecc132a0a678e344a018b5114a3a)
Review URL: https://codereview.chromium.org/1416113010 .
|
|
Do some IWYU to fix build errors due to files that have no #includes but
just happened to work previously because the #includes were in the right
order.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1407423004 .
(cherry picked from commit 9e7cd8ffb81c564e1102f6c6459ec0942a0b11ea)
Review URL: https://codereview.chromium.org/1425163004 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1415803007 .
(cherry picked from commit 5899671184d01b74989d181363066379ef3e4051)
Review URL: https://codereview.chromium.org/1431593007 .
|
|
- In non-standalone builds, use the provided jpeg library.
- Run gn format over all the GN files.
- Also roll DEPS for buildtools to c2f2598.
- And fix XFA's lack of #includes.
BUG=541704
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1425153006 .
(cherry picked from commit 34bb6c58fe60206a08dc0a1f37b7cfe83e8c762c)
Review URL: https://codereview.chromium.org/1434543003 .
|
|
Original Review URL: https://codereview.chromium.org/1413733004 .
(cherry picked from commit 93f191bb011508a8d4e66746135e8ba8e9583870)
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/1435493002 .
|
|
This cleans up various things after syncing BAAnnot to master.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1418043007 .
(cherry picked from commit 110650e68e519e8cf14fe1119b77cf3309ed2d0b)
Review URL: https://codereview.chromium.org/1415933007 .
|
|
The clip parameter is never NULL.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1417983006 .
|
|
Mainly:
volatile/override/method shadowing.
unused variables.
intialization list init order.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1422113003 .
|
|
- Remove dead code
- Stop using CFX_PtrArray
- Mark more things const
- Fix style nits
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1425093003 .
(cherry picked from commit c88c42f317c0e94c4c7b98949bfe1a495aef07a9)
Review URL: https://codereview.chromium.org/1430803003 .
|
|
Conflicts in both files.
R=tsepez@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1425233002 .
(cherry picked from commit 34c509e0e0fbd64d4380f130c48434b07f60b69e)
Review URL: https://codereview.chromium.org/1421983008 .
|
|
The original XFA version was correct, and the master version here is
wrong. The two versions are now in sync, but incorrect.
So we need to fix this here and then merge to XFA again.
Also fix what are now incorrect uses of CountAnnots() and do some
cleanups.
BUG=543049
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1413973011 .
(cherry picked from commit c91d5c276b6b986f645d34a0e583fbe4f73e74bc)
Review URL: https://codereview.chromium.org/1422503012 .
|
|
Previously, blur event actions could potentially touch deleted PageViews
as CPDFSDK_Document deletes the PageViews one by one.
This also fixes a related issue: CPDFSDK_Document::SetFocusAnnot no
longer does anything if the document is being destroyed. Otherwise, it
eventually tries to use m_pEnv->GetSDKDocument() at which point has
already been set to NULL by FPDFDOC_ExitFormFillEnvironment.
TBR=tsepez@chromium.org
BUG=512445
Clean merge.
Review URL: https://codereview.chromium.org/1414353007 .
(cherry picked from commit a548b1d3e2444f256bcbf6c2fa2165798e33ba8d)
Review URL: https://codereview.chromium.org/1423343004 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1411203007 .
(cherry picked from commit 9b2741829b8a8c511ef0f2f313ff53d77ac96307)
Review URL: https://codereview.chromium.org/1408263005 .
|
|
This method isn't used anywhere and the implementation doesn't really do
anything.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1405163003 .
(cherry picked from commit 162f227af9c5e28885a36e6ca06a09c12c6223e0)
Review URL: https://codereview.chromium.org/1416283002 .
|
|
Abstracts away that master returns CPDF_Documents directly,
but XFA wraps them with a CPDFXFA_Document.
Tidy dead code along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1415803002 .
|
|
None of the methods in this file are used and it is not included anywhere. Removing.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1417783004 .
(cherry picked from commit 704da531215c4f81279eb763192de398f7d03748)
Review URL: https://codereview.chromium.org/1413943004 .
|
|
Review URL: https://codereview.chromium.org/1412123004 .
(cherry picked from commit b5dd65f31408dc8c15d202cbb3e8d9ec2afd4520)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1415433006 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1411963002 .
(cherry picked from commit 8b8dfd7934d669b2c74a0502f82387e5df0f573b)
Review URL: https://codereview.chromium.org/1415513004 .
|
|
BUG=pdfium:205
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1409743004 .
(cherry picked from commit 9ddafc82bddb984ae46ee0df801ba20b446d5158)
Review URL: https://codereview.chromium.org/1411423002 .
|
|
Original Review URL: https://codereview.chromium.org/1406543004 .
(cherry picked from commit 943ea142b6a7e6edc91fe3c307013129e6eb0ef3)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1411623002 .
|
|
Manual merges everywhere.
Original Review URL: https://codereview.chromium.org/1395493007 .
(cherry picked from commit bb51c4fb6bc6095984c303c95e5336f83e66bc67)
Original Review URL: https://codereview.chromium.org/1396283006 .
(cherry picked from commit 86adb658843658969041a13bf6cf0cc950ffe8ed)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1395353004 .
|
|
This contains a missed merge of the Document:delay fixes.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1398703009 .
|
|
These files should change in XFA in order to reduce the number of
"noise diffs" between master and XFA as seen in
https://codereview.chromium.org/1399273003/
These include: blank lines and missed merges:
3c012fe else-after-returns (partial)
fb07e28 Tidy up CPDFDOC_Environment (partial, consts missing).
624b166 Allow FPDFBookmark_GetFirstChild to return the top level bookmark
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1403063003 .
|
|
Original Review URL: https://codereview.chromium.org/1389163007 .
(cherry picked from commit 848a13b6777cbff8cc4aea3ab3d69eaa0b82ae6c)
Merge conflics in:
fpdfsdk/src/javascript/JS_Runtime.cpp
fpdfsdk/src/javascript/JS_Runtime_Stub.cpp
fpdfsdk/src/jsapi/fxjs_v8.cpp
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1394993006 .
|
|
Original Review URL: https://codereview.chromium.org/1395733006 .
(cherry picked from commit f1c713663192368d26031a4caed1f9705f4510af)
Conflicts:
BUILD.gn
fpdfsdk/src/fpdfview.cpp
fpdfsdk/src/javascript/JS_Runtime.cpp
pdfium.gyp
samples/BUILD.gn
samples/samples.gyp
BUG=pdfium:211
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1393833006 .
|
|
BUG=539106
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1386823002 .
(cherry picked from commit 7dfe5929282cb6d78d7b5e32e1d72e9db99d3066)
Review URL: https://codereview.chromium.org/1400503003 .
|