Age | Commit message (Collapse) | Author |
|
Mainly change the code to avoid the warnings; in a few cases we have
to use explicit casts.
BUG=pdfium:29
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1783023002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1778173002 .
|
|
Move some of the xfa/ includes in fpdfsdk from the header files to the .cpp
files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1771353006 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1773103003 .
|
|
Fixup some includes so we can still build non-xfa.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1781643002 .
|
|
This CL goes through the remaining list of list warnings and records why they
are currently blacklisted, or fixes and enables them.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1773733002 .
|
|
Missing include in fsdk_mgr.h
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1774303002 .
|
|
This reverts commit 1a35d55dd6b0d1ea1918e2d6a6c25faf599ba168.
Prevent handles from being destructed after v8 is gone.
BUG=pdfium:419
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1761073006 .
|
|
This reverts commit 3e44a7bd2b60ace1ee8bc8f48c709056f65c3dc1.
R=ochang@chromium.org
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1767793002 .
|
|
Kill some crummy comments along the way.
BUG=pdfium:419
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1759893002 .
|
|
* FIELDFLAG_DONOTSPELLCHECK is defined on line 20.
* 1 << 25 is used by FIELDFLAG_RICHTEXT already.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1745263002 .
|
|
This CL removes duplicate forward declarations, removes extraneous declarations
and adds a couple of missing declarations.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1741003002 .
|
|
Grepping for FX_BOOL and |==| on the same line gives
a very strong clue that the expression won't be out
of range of the |bool| type iteself.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1736323003 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1737593006 .
|
|
This reverts commit 3b8fdd34bdf57ec45291b77008a43249f838efcb.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1743753002 .
|
|
Too many rectangle types. Remove CPDF_Rect #define, and
make an equivalent point type in CFX, but stop short of
consolidating the N different forms of rectangles in CFX.
Also banish PDF_ClipFloat to the one .cpp file that needs it,
since it was in the vicinity of the .h file changes.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1740923003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1725303003 .
|
|
This CL enables several of the diabled whitelist/* lint checks.
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1730553002 .
|
|
They're technically not allowed because they are reserved
for the preprocessor.
Also get rid of LPC* typedefs along the way.
Also provide a header for a data file containing many
instance of these found along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1722873002 .
|
|
This update fixes all include guards so cpplint build/header_guard completes
without error.
A presubmit check is added to make sure the guards stay clean.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1719083002 .
|
|
BUG=pdfium:401
R=jun_fang@foxitsoftware.com, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1712763003 .
|
|
This CL updates include guards throughout the code base to be in the
chromium style.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1707893004 .
|
|
This CL runs the chromium sort-headers.py script over the non-xfa code.
XFA will be done after the includes have been updated to full paths.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1711793002 .
|
|
Exposes an iterator over the object list, but not the object
holder, since pages and forms inherit from object holder, and
we don't want to imply that there's only one thing that might
be iterated over for those classes.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1700183002 .
|
|
This CL runs a script over the source and updates the include files to be
a full path from the pdfium/ directory.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1707923002 .
|
|
Fix IWYU and include paths as we go.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1701883004 .
|
|
Eventually, we're going to expose an iterator over
CPDF_PageObjectList that we don't want to be inherited by
the CPDF_PageObjectHolder sub-classes: page and form.
Also, the operations that the object holder performs dealing
with inquiring about masks and such seem beyond the scope of
what a list would provide. Hence the "Holder" name.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1701073002 .
|
|
One less Bezier.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1692413002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1676913004 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1664543005 .
|
|
BUG=pdfium:373
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1652873003 .
|
|
Original Review URL: https://codereview.chromium.org/1660633003 .
(cherry picked from commit e8ea737bf9ef95b406c74fc3b1120f3fa6c4e227)
Conflicts:
fpdfsdk/include/fsdk_baseform.h
fpdfsdk/src/fsdk_baseform.cpp
TBR=thestig@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1668483004 .
|
|
BUG=pdfium:374
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1640233004 .
|
|
One trivial edit in fx_basic.h
Includes both fixes for build breakage.
Review URL: https://codereview.chromium.org/1653253002 .
(cherry picked from commit 9b0a59d659d8083802385649ba74370d65c41e36)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1655423002 .
|
|
One trivial conflict in fsdk_mgr.h
Review URL: https://codereview.chromium.org/1658853002 .
(cherry picked from commit 1654972e0c81f1841653f803903cc48b93f1738e)
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1651313002 .
|
|
Original Review URL: https://codereview.chromium.org/1652613002 .
(cherry picked from commit 0841b0f37678ba4962247f5636e9390718fc027e)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1657663003 .
|
|
Original Review URL: https://codereview.chromium.org/1652533002 .
(cherry picked from commit 1bce5f62f3292a6baf35491bf4c9b4fde2fb73e3)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1652543003 .
|
|
BUG=pdfium:348
R=jochen@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1633083002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1641963002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1640033002 .
|
|
Introduce CPDF_Parser::Error.
Introduce CPDF_Color::Type.
Unused XFA_DATASETS and XFA_FORMS defines.
Move FPDF_CreateStandardSecurityHandler() prototype to header.
Delete prototype for nonexistent FPDF_CreatePubKeyHandler().
Make PBS_* defines local to .cpp file.
Tidy whitespace.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1634123004 .
|
|
Orignal Review URL: https://codereview.chromium.org/1612113003 .
(cherry picked from commit 9ebc84109d7d2f7b81f06f19e5db20888e026c3b)
R=ochang@chromium.org
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1612243002 .
|
|
Original Review URL: https://codereview.chromium.org/1610303002 .
(cherry picked from commit f409da4b8a3e6a3885605a47bed4f8798c4703b9)
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1611733002 .
|
|
BUG=pdfium:332
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1539193003 .
|
|
Fix lint errors along the way.
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567343002 .
(cherry picked from commit 9adfbb0920a258e916003b1ee9515e97879db82a)
Review URL: https://codereview.chromium.org/1577503002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567333003 .
(cherry picked from commit 4a24ad858484ecdf9b49481e63060e4d476cf1c7)
Review URL: https://codereview.chromium.org/1569783007 .
|
|
Some bits regressed in commit 338805f.
Also merge: IWYU fix after commit c5a8933.
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1544963002 .
Review URL: https://codereview.chromium.org/1570973002 .
(cherry picked from commit c5a8933f260ca1034fde902058442984e55c0f7a)
(cherry picked from commit e6bd31873c3dba3f79c5ebbbefed636948629cc9)
Review URL: https://codereview.chromium.org/1577453002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1572523002 .
|
|
Also remove a bunch of dead code.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1565803003 .
(cherry picked from commit cbed99098ad4cdc3f9f260cc1e8521f67c12d35d)
Review URL: https://codereview.chromium.org/1569483004 .
|
|
R=jun_fang@foxitsoftware.com, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1566903002 .
|