Age | Commit message (Collapse) | Author |
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1780503002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1745243002 .
|
|
Otherwise ASSERT() is useless.
BUG=pdfium:136
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1712053003 .
|
|
BUG=pdfium:373
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1652873003 .
|
|
This is needed by Cl 1634373003 as the name collision with virtual functions
will be shown as warnings on Linux. Also, it is better to use
different names for different cases.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1644633003 .
(cherry picked from commit d45e7a51904164fb22049f0a7a80d2a94c06936b)
Review URL: https://codereview.chromium.org/1648233002 .
|
|
Introduce CPDF_Parser::Error.
Introduce CPDF_Color::Type.
Unused XFA_DATASETS and XFA_FORMS defines.
Move FPDF_CreateStandardSecurityHandler() prototype to header.
Delete prototype for nonexistent FPDF_CreatePubKeyHandler().
Make PBS_* defines local to .cpp file.
Tidy whitespace.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1634123004 .
|
|
Original Review URL: https://codereview.chromium.org/1620523002 .
(cherry picked from commit d5712ac571f3487fe3f74617fdab007a11a09052)
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1624553004 .
|
|
Original Review URL: https://codereview.chromium.org/1601093009 .
(cherry picked from commit da9355139b5dce270be02af31db326d60f488e8c)
Trivial conflicts/changes in fpdfeditpage.cpp and fpdfxfa_page.cpp.
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1613823003 .
|
|
Replaces CFX_CMapByteStringToPtr. XFA still uses CFX_CMapByteStringToPtr
so it's not completely removed just yet.
Adds begin()/end() to CPDF_Dictionary and removes the
GetStartPos()/GetNextElement() functions to traverse the dictionary.
Callers are changed accordingly. AddValue() is also removed.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1541703003 .
(cherry picked from commit 14f39950451bb9c2a11fbc7173fd47367410f80f)
Review URL: https://codereview.chromium.org/1576033002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1572523002 .
|
|
center
BUG=482206
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1551563002 .
Review URL: https://codereview.chromium.org/1552643002 .
|
|
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1547833002 .
(cherry picked from commit d20dfba2ae10e8aeb328328f09da79ff904110a8)
Review URL: https://codereview.chromium.org/1545183002 .
|
|
Original Review URL: https://codereview.chromium.org/1536623004 .
(cherry picked from commit 761660c4074269ac806d06c9bef70e4e9fb0eb29)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1531423002 .
|
|
BUG=pdfium:245
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1526873006 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1520063002 .
(cherry picked from commit e385244f8cd6ae376f6b3cf1265a0795d5d30eff)
Review URL: https://codereview.chromium.org/1528763003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1521563002 .
(cherry picked from commit 1956a174020686f91cd3b34294e91f4560fe45aa)
Review URL: https://codereview.chromium.org/1526823002 .
|
|
Review URL: https://codereview.chromium.org/1513363002 .
(cherry picked from commit f32c969bce6743fca1e7ff796b54a1692d26d7f0)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1519693002 .
|
|
-- label matching #endifs
-- prefer #ifdef over #ifndef
-- consolidate some blocks.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1484843002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1477583002 .
|
|
Precursor to https://codereview.chromium.org/1477583002/
Also:
whitespace in fxjs_v8.h
Merge where possible.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1472363003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1473053003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1474663004 .
|
|
See the comment in fsdk_define.h. Also tidy up a bit,
and remove dead DeletePages(). This should help us
match master more closely (given corresponding changes
on the master side).
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1473503002 .
|
|
In FPDF_GetPageCount(), 'document' is converted to a non-XFA
document pointer (CPDF_Document*). So it only returns non-XFA
or static XFA page count. If XFA files include dynamic XFA fields
on some pages, the returned value doesn't reflect these pages.
BUG=pdfium:278
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1442753005 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1465663002 .
|
|
That refer to parent directories.
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1434223002 .
(cherry picked from commit 22bc4227fbbda5a5e9abad2a2c0a98c04fe7f228)
Review URL: https://codereview.chromium.org/1439223003 .
|
|
Do some IWYU to fix build errors due to files that have no #includes but
just happened to work previously because the #includes were in the right
order.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1407423004 .
(cherry picked from commit 9e7cd8ffb81c564e1102f6c6459ec0942a0b11ea)
Review URL: https://codereview.chromium.org/1425163004 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1415803007 .
(cherry picked from commit 5899671184d01b74989d181363066379ef3e4051)
Review URL: https://codereview.chromium.org/1431593007 .
|
|
- In non-standalone builds, use the provided jpeg library.
- Run gn format over all the GN files.
- Also roll DEPS for buildtools to c2f2598.
- And fix XFA's lack of #includes.
BUG=541704
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1425153006 .
(cherry picked from commit 34bb6c58fe60206a08dc0a1f37b7cfe83e8c762c)
Review URL: https://codereview.chromium.org/1434543003 .
|
|
This Cl adds ToArray, CPDF_Object::AsArray and CPDF_Object::IsArray and
updates the src to use them as needed.
BUG=pdfium:201
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1417893003 .
(cherry picked from commit c2bfc000e502c42c9a3017038fd9104c7997d126)
Review URL: https://codereview.chromium.org/1419643005 .
|
|
Abstracts away that master returns CPDF_Documents directly,
but XFA wraps them with a CPDFXFA_Document.
Tidy dead code along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1415803002 .
|
|
The unittests had a case where we added an abort() call to
the code, but left the case. And one of the expected results
was not updated with the code.
The fpdfview.cpp got broken by a recent change, and was not
caught due to all the void* returns. Also, the tests now
clean up the page automatically.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1403373006 .
|
|
This reverts commit 937840e1722d1f2b77d80575d6e710d760662c9c.
Add type cast definitions for CPDF_Dictionary.
This CL adds ToCPDFDictionary type definitions and updates one file to use
instead of straight casts. I had to fix two places where we'd casted off the
constness of the original pointer.
BUG=pdfium:201
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1420583003 .
(cherry picked from commit 39869b641511c882d78e17548293cdb458c36f38)
Review URL: https://codereview.chromium.org/1410343003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1410733004 .
(cherry picked from commit 0f2736742f5f9841447a4bd505dcadda22e2f574)
Review URL: https://codereview.chromium.org/1409853003 .
|
|
Hand-application of diffs from https://codereview.chromium.org/1233453014/.
This was an oversight, and was too old (pre-reformat) to apply cleanly.
Checked against origin/master, only diffs are xfa related.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1416793002 .
|
|
Get rid of cond ? TRUE : FALSE.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1405723003 .
(cherry picked from commit aff4635dad81bc319266d9d84b81552580cd2b65)
Review URL: https://codereview.chromium.org/1412793003 .
|
|
Original Review URL: https://codereview.chromium.org/1406543004 .
(cherry picked from commit 943ea142b6a7e6edc91fe3c307013129e6eb0ef3)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1411623002 .
|
|
Manual merges everywhere.
Original Review URL: https://codereview.chromium.org/1395493007 .
(cherry picked from commit bb51c4fb6bc6095984c303c95e5336f83e66bc67)
Original Review URL: https://codereview.chromium.org/1396283006 .
(cherry picked from commit 86adb658843658969041a13bf6cf0cc950ffe8ed)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1395353004 .
|
|
This contains a missed merge of the Document:delay fixes.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1398703009 .
|
|
Original Review URL: https://codereview.chromium.org/1395733006 .
(cherry picked from commit f1c713663192368d26031a4caed1f9705f4510af)
Conflicts:
BUILD.gn
fpdfsdk/src/fpdfview.cpp
fpdfsdk/src/javascript/JS_Runtime.cpp
pdfium.gyp
samples/BUILD.gn
samples/samples.gyp
BUG=pdfium:211
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1393833006 .
|
|
New code changes in JS_Runtime.cpp.
(cherry picked from commit 3dedace9623fef6161a8666e53a4ab2b9be61e4c)
Original Review URL: https://codereview.chromium.org/1367033002 .
Also merge to XFA: Run FXJS_V8 embedder tests against a shared isolate,
since the two go together.
(cherry picked from commit 4ea721cb7954898a9722c389dae86c62957352d0)
Original Review URL: https://codereview.chromium.org/1377293004 .
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1381633008 .
|
|
Based on parts of https://codereview.chromium.org/1089823004
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1383933003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1268323004 .
(cherry picked from commit 9311163b564785a3a3ccdcb09bd3b7d0b2976d1a)
Review URL: https://codereview.chromium.org/1368513002 .
|
|
(cherry picked from commit 71c15a5e6652952a94ba3a3ef7ac0392e3a06962)
Original Review URL: https://codereview.chromium.org/1299963002 .
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1301073003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1287193005 .
(cherry picked from commit 0f6b51c0fdd14f5762bf3c7412ac59c825443cc3)
Review URL: https://codereview.chromium.org/1288393004 .
|
|
Also add a presubmit that checks for this so I don't have to keep doing it.
No behavior change.
Generated by:
find . -name '*.cpp' -o -name '*.h' | \
grep -E -v 'third_party|thirdparties|lpng_v163|tiff_v403' | \
xargs ../../buildtools/mac/clang-format -i
Then manually merged https://codereview.chromium.org/1269223002/
See thread "tabs vs spaces" on pdfium@googlegroups.com for discussion.
BUG=none
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1277043002 .
|
|
It would seem that this never merged completely.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1277583002 .
|
|
(cherry picked from commit 2b9178181eb82a3611bee5c9435ea5956def24be)
Orignal Review URL: https://codereview.chromium.org/1269073003 .
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1278533002 .
|
|
No behavior change.
Generated by:
find . -name '*.cpp' -o -name '*.h' | \
grep -E -v 'third_party|thirdparties|lpng_v163|tiff_v403' | \
xargs ../../buildtools/mac/clang-format -i
Then manually merged https://codereview.chromium.org/1269223002/
See thread "tabs vs spaces" on pdfium@googlegroups.com for discussion.
BUG=none
|
|
Precursor to automatic FX_BOOL deprecation.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1260743002 .
|