Age | Commit message (Collapse) | Author |
|
Also do some cleanups in affected files.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1552583002 .
(cherry picked from commit d794d34b5deb6ad691c19af758090f9ce46015a3)
Review URL: https://codereview.chromium.org/1566583002 .
|
|
Original Review URL: https://codereview.chromium.org/1566433003 .
(cherry picked from commit cc3727f88e48f4d26a589131dc03adca4eaac301)
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1560333002 .
|
|
Original Review URL: https://codereview.chromium.org/1556033002 .
(cherry picked from commit 603533fb0e5968923d67c1d8f2e00a640f41b5e5)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1563483003 .
|
|
When cross reference sections form a loop, our code will enter an
infinite loop. Add detection and exit code for v4 cross reference loading.
V5 loading was done previously.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1558093002 .
(cherry picked from commit aab8f462ea3368ed4825172231131e1a10db978d)
Review URL: https://codereview.chromium.org/1556423002 .
|
|
Original Review URL: https://codereview.chromium.org/1554363002 .
(cherry picked from commit ed34cdf99d5a4b33e57f81f9244a311f6fb86db3)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1559373002 .
|
|
Original Review URL: https://codereview.chromium.org/1559043006 .
(cherry picked from commit 5dac8047f02c937a5a3546a8cc5b352db2188d97)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1553313002 .
|
|
Original Review URL: https://codereview.chromium.org/1557173002 .
(cherry picked from commit 14fdb1d40741912e430db4318a9033764429659f)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1556983003 .
|
|
center
BUG=482206
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1551563002 .
Review URL: https://codereview.chromium.org/1552643002 .
|
|
Found with Clang's -Wimplicit-fallthrough option by tzik@chromium.org.
TBR=tzik@chromium.org
Review URL: https://codereview.chromium.org/1549283002 .
(cherry picked from commit de0387c3690ca147482ed943c70eeb828b6dd732)
Review URL: https://codereview.chromium.org/1554453002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1546133002 .
(cherry picked from commit 1f1c1970259b696a9b1e5ca1a3c199f221846409)
Review URL: https://codereview.chromium.org/1542403002 .
|
|
BUG=546744
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1542373002 .
(cherry picked from commit ae58ed8bccc56dd78c12d89972b19d58de94f790)
Review URL: https://codereview.chromium.org/1548093002 .
|
|
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1547833002 .
(cherry picked from commit d20dfba2ae10e8aeb328328f09da79ff904110a8)
Review URL: https://codereview.chromium.org/1545183002 .
|
|
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1544953002 .
(cherry picked from commit cd0ade6f77b1a3e7c340a05bc6cb448f52e9bb96)
Review URL: https://codereview.chromium.org/1547843003 .
|
|
appropriate.
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1540263003 .
(cherry picked from commit 1fc92867ca53f0fba4272fbee3814d844f487495)
Review URL: https://codereview.chromium.org/1542193002 .
|
|
- Use FXSYS_iswdigit() instead of CJS_PublicMethods::IsDigit().
- Ditto for FXSYS_iswalpha() and FXSYS_iswalnum().
- Change CJS_PublicMethods::ParseNormalDate() and
CJS_PublicMethods::MakeRegularDate() to take an out parameter by ptr.
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1539113002 .
(cherry picked from commit f84fd2b1dac1fcca41db84d162995c38af650614)
Review URL: https://codereview.chromium.org/1542693002 .
|
|
BUG=515137,564736
TBR=ochang@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1533233002 .
Review URL: https://codereview.chromium.org/1544493003 .
(cherry picked from commit b426e3edde040089b70d1a223c83b90957aa571d)
(cherry picked from commit bd35d484a4027775f19ff93e9143e0b270133d42)
Review URL: https://codereview.chromium.org/1546443002 .
|
|
instead.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1540693002 .
(cherry picked from commit d866ab0b44a571c884fdd8ba5a5319adaf607559)
Review URL: https://codereview.chromium.org/1541563002 .
|
|
Original Review URL: https://codereview.chromium.org/1536623004 .
(cherry picked from commit 761660c4074269ac806d06c9bef70e4e9fb0eb29)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1531423002 .
|
|
BUG=pdfium:245
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1526873006 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1520063002 .
(cherry picked from commit e385244f8cd6ae376f6b3cf1265a0795d5d30eff)
Review URL: https://codereview.chromium.org/1528763003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1512763013 .
(cherry picked from commit e3c7c2b54348da4a6939f6672f6c6bff126815a7)
Review URL: https://codereview.chromium.org/1529553003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1521563002 .
(cherry picked from commit 1956a174020686f91cd3b34294e91f4560fe45aa)
Review URL: https://codereview.chromium.org/1526823002 .
|
|
Review URL: https://codereview.chromium.org/1513363002 .
(cherry picked from commit f32c969bce6743fca1e7ff796b54a1692d26d7f0)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1519693002 .
|
|
BUG=pdfium:298
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1496703005 .
(cherry picked from commit 93181f9a20db7ac706bb9405750303db93762a5b)
Review URL: https://codereview.chromium.org/1514783002 .
|
|
Revert "Fix embedder test failures introduced by commit c70b19aad245"
This reverts commit 8d89e65897d8b6cf7899e7a82d9d381c3ad327cb.
Revert "Fix invalid buffer length set in CFX_WideString::UTF16LE_Encode()"
This reverts commit c70b19aad245fb1ed39bf8c264d991555f4c5a58.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1516643002 .
|
|
Broken at 487d1a9/a0217b6.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1504413002 .
|
|
BUG=pdfium:294
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1487573002 .
|
|
BUG=pdfium:293
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1486583002 .
|
|
BUG=pdfium:295
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1482253002 .
|
|
BUG=pdfium:291
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1487553003 .
|
|
This first pass is GYP-only, will do GN in the next CL.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1480403002 .
|
|
-- label matching #endifs
-- prefer #ifdef over #ifndef
-- consolidate some blocks.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1484843002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1477583002 .
|
|
Review URL: https://codereview.chromium.org/1465183009 .
|
|
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1477983002 .
|
|
Precursor to https://codereview.chromium.org/1477583002/
Also:
whitespace in fxjs_v8.h
Merge where possible.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1472363003 .
|
|
Review URL: https://codereview.chromium.org/1468423004 .
(cherry picked from commit 628f7053cc646c58c61add247c75bc65ac135327)
BUG=561184
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/1473943002 .
|
|
BUG=pdfium:275
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1443603002.
Review URL: https://codereview.chromium.org/1477693002 .
|
|
BUG=pdfium:275
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1443603002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1473053003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1474663004 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1477483002 .
|
|
See the comment in fsdk_define.h. Also tidy up a bit,
and remove dead DeletePages(). This should help us
match master more closely (given corresponding changes
on the master side).
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1473503002 .
|
|
In FPDF_GetPageCount(), 'document' is converted to a non-XFA
document pointer (CPDF_Document*). So it only returns non-XFA
or static XFA page count. If XFA files include dynamic XFA fields
on some pages, the returned value doesn't reflect these pages.
BUG=pdfium:278
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1442753005 .
|
|
Bumping this one line from 6 to 7 in XFA saves a bunch of diffs.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1458363005 .
(cherry picked from commit 7711b60efc62db14748711727560367d948745f1)
BUG=
Review URL: https://codereview.chromium.org/1470563002 .
|
|
Original Review URL: https://codereview.chromium.org/1467653002 .
(cherry picked from commit 54bc568bb41c5c258e95c24ef9d7355dcdc20f9e)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1466743003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1463973002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1465663002 .
|
|
This reverts commit 0569ab0b11b723d9bca4ddd642b0cf8828c4bdd1.
This changes the various comparisons of char >= '0' && char <= '9' and
char < '0' || char > '9' to use std::isdigit checks. It also cleans up
a handful of hex to digit conversions to call one common method.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1449873003 .
(cherry picked from commit 3f148915d12f54a946a0c0bf526162b79c39d650)
Review URL: https://codereview.chromium.org/1452673002 .
|
|
That refer to parent directories.
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1434223002 .
(cherry picked from commit 22bc4227fbbda5a5e9abad2a2c0a98c04fe7f228)
Review URL: https://codereview.chromium.org/1439223003 .
|