Age | Commit message (Collapse) | Author |
|
BUG=482206
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1551563002 .
|
|
Found with Clang's -Wimplicit-fallthrough option by tzik@chromium.org.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1549283002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1546133002 .
|
|
BUG=546744
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1542373002 .
|
|
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1547833002 .
|
|
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1544953002 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1540263003 .
|
|
- Use FXSYS_iswdigit() instead of CJS_PublicMethods::IsDigit().
- Ditto for FXSYS_iswalpha() and FXSYS_iswalnum().
- Change CJS_PublicMethods::ParseNormalDate() and
CJS_PublicMethods::MakeRegularDate() to take an out parameter by ptr.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1539113002 .
|
|
BUG=515137,564736
R=ochang@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1533233002 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1540693002 .
|
|
- Remove unused Clear() method.
- Replace Create() with actual ctors.
- Avoid const casts.
- Protect members.
- Add missing const in adjacent code.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1536623004 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1520063002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1512763013 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1521563002 .
|
|
These are synonyms for CFX_Matrix.
Nothing but sed and manual deletion of 2 #defines in
fpdf_parser.h and fx_coordinates.h
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1513363002 .
|
|
BUG=pdfium:298
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1496703005 .
|
|
Broke chrome bindings.
This reverts commit c3e4ae5fe5067723b58a2029a95c6411c92bed15.
R=thestig@chromium.org, tsepez@chromium.org
BUG=567485
Review URL: https://codereview.chromium.org/1511773002 .
|
|
Master side change for https://codereview.chromium.org/1504413002
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1508133003 .
|
|
(cherry picked from commit 8d89e65897d8b6cf7899e7a82d9d381c3ad327cb)
(cherry picked from commit c70b19aad245fb1ed39bf8c264d991555f4c5a58)
BUG=pdfium:275
TBR=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1473753004 .
|
|
Precursor to https://codereview.chromium.org/1477583002/
Also:
merge where possible.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1481523004 .
|
|
Introduced at https://codereview.chromium.org/1424933013/
The v8 objects are 1:1 with the context being destroyed in
FXJS_ReleaseRuntime, but the CFXJS_ObjDefinitions are still
1:1 with the isolate, so they can't be destroyed until the
refcounts hit zero.
BUG=561184
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1468423004 .
|
|
Change some master code to line up better with XFA, so
that the XFA changes are additive when possible, rather
than replacements.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1468253005 .
|
|
Bumping this one line from 6 to 7 in XFA saves a bunch of diffs.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1458363005 .
|
|
More casts go away.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1467653002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1458853005 .
|
|
Using Chromium's clang + build options, there's more override warnings.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1453643002 .
|
|
This reverts commit 0569ab0b11b723d9bca4ddd642b0cf8828c4bdd1.
This changes the various comparisons of char >= '0' && char <= '9' and
char < '0' || char > '9' to use std::isdigit checks. It also cleans up
a handful of hex to digit conversions to call one common method.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1449873003 .
|
|
That refer to parent directories.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1434223002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1437713003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1432863004 .
|
|
Every time we initialize a new v8::Context, we make a new set of
pre-existing native objects, and overwrite the v8::Global
handles to those in the previous set. Thus, we may be
theoretically releasing some v8::Globals early.
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1424933013 .
|
|
This reverts commit b27902b8995bb3e003daed6b0811ed746763c68d.
Cleanup some numeric code.
This changes the various comparisons of char >= '0' && char <= '9' and
char < '0' || char > '9' to use std::isdigit checks. It also cleans up
a handful of hex to digit conversions to call one common method.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1432973003 .
|
|
This reverts commit da06e60fb5a095a91c9a4f509466667878624cb3.
Cleanup some numeric code.
This changes the various comparisons of char >= '0' && char <= '9' and
char < '0' || char > '9' to use std::isdigit checks. It also cleans up
a handful of hex to digit conversions to call one common method.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1433513002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1430213002 .
|
|
-Wunused-variable triggers for PODs, but not for CFX_WideString.
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1412423013 .
|
|
run from any directory.
Previously the tests which read test files assume the current directory is under pdfium. Running from any other directory will break the build.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1408003014 .
|
|
Do some IWYU to fix build errors due to files that have no #includes but
just happened to work previously because the #includes were in the right
order.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1407423004 .
|
|
Use m_ naming convention for its members.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1424933012 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1415803007 .
|
|
Its pointless to have a function that gets the isolate
given a v8::object, since v8 gives us that directly.
Also remove some CreationContext() calls, since they are only
used to get the isolate, and we can do so directly.
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1413733004 .
|
|
- In non-standalone builds, use the provided jpeg library.
- Run gn format over all the GN files.
- Also roll DEPS for buildtools to c2f2598.
BUG=541704
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1425153006 .
|
|
And simplify code.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1411663013 .
|
|
Do not store raw wide string pointers.
BUG=551248
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1411043008 .
|
|
This regressed in commit 794c9b6.
BUG=551248
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1424743006 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1419373005 .
|
|
Renames one local variable.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1424713005 .
|
|
No functional change, just rename for consistency.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1419273009 .
|
|
This cleans up various things after syncing BAAnnot to master.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1418043007 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1411133006 .
|
|
On the XFA branch the CPDFSDK_Annot class has been turned into a base class
with CPDFSDK_BAAnnot serving the purpose that was served by CPDFSDK_Annot.
This CL pulls those changes into master to put it more in line with the XFA
branch. (This removes ~600 lines from the fpdfsdk/ diff).
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1408073009 .
|