Age | Commit message (Collapse) | Author |
|
CPDF_SyntaxParser::GetObject() may enter into an infinite loop when a
signature dictionary doesn't have 'Contents' field. Add a check to
avoid that.
BUG=pdfium:344
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1575833004 .
|
|
BUG=pdfium:346
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1578543002 .
|
|
Replaces CFX_CMapByteStringToPtr. XFA still uses CFX_CMapByteStringToPtr
so it's not completely removed just yet.
Adds begin()/end() to CPDF_Dictionary and removes the
GetStartPos()/GetNextElement() functions to traverse the dictionary.
Callers are changed accordingly. AddValue() is also removed.
R=tsepez@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1541703003 .
|
|
Fix lint errors along the way.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567343002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567333003 .
|
|
BUG=pdfium:343
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1569343002 .
|
|
Some bits regressed in commit 338805f.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1544963002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1561303002 .
|
|
Also remove a bunch of dead code.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1565803003 .
|
|
BUG=572871
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1564773003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1563513002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1554133003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1565613002 .
|
|
Also do some cleanups in affected files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1552583002 .
|
|
Remove some O(n^2) behaviour when iterating across the thing.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1566433003 .
|
|
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1549103002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1556033002 .
|
|
When cross reference sections form a loop, our code will enter an
infinite loop. Add detection and exit code for v4 cross reference loading.
V5 loading was done previously.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1558093002 .
|
|
Given the helper routines, use it in the find bookmark test
instead of just trusting another bookmarks title.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1554363002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1559043006 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1557173002 .
|
|
BUG=482206
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1551563002 .
|
|
Found with Clang's -Wimplicit-fallthrough option by tzik@chromium.org.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1549283002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1546133002 .
|
|
BUG=546744
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1542373002 .
|
|
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1547833002 .
|
|
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1544953002 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1540263003 .
|
|
- Use FXSYS_iswdigit() instead of CJS_PublicMethods::IsDigit().
- Ditto for FXSYS_iswalpha() and FXSYS_iswalnum().
- Change CJS_PublicMethods::ParseNormalDate() and
CJS_PublicMethods::MakeRegularDate() to take an out parameter by ptr.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1539113002 .
|
|
BUG=515137,564736
R=ochang@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1533233002 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1540693002 .
|
|
- Remove unused Clear() method.
- Replace Create() with actual ctors.
- Avoid const casts.
- Protect members.
- Add missing const in adjacent code.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1536623004 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1520063002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1512763013 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1521563002 .
|
|
These are synonyms for CFX_Matrix.
Nothing but sed and manual deletion of 2 #defines in
fpdf_parser.h and fx_coordinates.h
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1513363002 .
|
|
BUG=pdfium:298
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1496703005 .
|
|
Broke chrome bindings.
This reverts commit c3e4ae5fe5067723b58a2029a95c6411c92bed15.
R=thestig@chromium.org, tsepez@chromium.org
BUG=567485
Review URL: https://codereview.chromium.org/1511773002 .
|
|
Master side change for https://codereview.chromium.org/1504413002
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1508133003 .
|
|
(cherry picked from commit 8d89e65897d8b6cf7899e7a82d9d381c3ad327cb)
(cherry picked from commit c70b19aad245fb1ed39bf8c264d991555f4c5a58)
BUG=pdfium:275
TBR=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1473753004 .
|
|
Precursor to https://codereview.chromium.org/1477583002/
Also:
merge where possible.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1481523004 .
|
|
Introduced at https://codereview.chromium.org/1424933013/
The v8 objects are 1:1 with the context being destroyed in
FXJS_ReleaseRuntime, but the CFXJS_ObjDefinitions are still
1:1 with the isolate, so they can't be destroyed until the
refcounts hit zero.
BUG=561184
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1468423004 .
|
|
Change some master code to line up better with XFA, so
that the XFA changes are additive when possible, rather
than replacements.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1468253005 .
|
|
Bumping this one line from 6 to 7 in XFA saves a bunch of diffs.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1458363005 .
|
|
More casts go away.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1467653002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1458853005 .
|
|
Using Chromium's clang + build options, there's more override warnings.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1453643002 .
|
|
This reverts commit 0569ab0b11b723d9bca4ddd642b0cf8828c4bdd1.
This changes the various comparisons of char >= '0' && char <= '9' and
char < '0' || char > '9' to use std::isdigit checks. It also cleans up
a handful of hex to digit conversions to call one common method.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1449873003 .
|
|
That refer to parent directories.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1434223002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1437713003 .
|