Age | Commit message (Collapse) | Author |
|
Eventually, we're going to expose an iterator over
CPDF_PageObjectList that we don't want to be inherited by
the CPDF_PageObjectHolder sub-classes: page and form.
Also, the operations that the object holder performs dealing
with inquiring about masks and such seem beyond the scope of
what a list would provide. Hence the "Holder" name.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1701073002 .
|
|
Remove unused member functions and simplify calls to find tag parameters.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1681403007 .
|
|
One less Bezier.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1692413002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1676913004 .
|
|
Remove CFX_PtrArray filelist.
Promote ScopedFileStream to .h file and use it.
Fix _CAPS names, bool returns, and put in anonymous namespace.
FX_CreateMemoryStream() can't return null, so remove checks.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1672153002 .
|
|
BUG=pdfium:369
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1667643002 .
Review URL: https://codereview.chromium.org/1668283003 .
|
|
TBR=thestig@chromium.org
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1670843002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1664543005 .
|
|
BUG=pdfium:373
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1652873003 .
|
|
Original Review URL: https://codereview.chromium.org/1660633003 .
(cherry picked from commit e8ea737bf9ef95b406c74fc3b1120f3fa6c4e227)
Conflicts:
fpdfsdk/include/fsdk_baseform.h
fpdfsdk/src/fsdk_baseform.cpp
TBR=thestig@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1668483004 .
|
|
BUG=pdfium:374
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1640233004 .
|
|
BUG=pdfium:376
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1651193005 .
|
|
BUG=pdfium:377
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1658163002 .
|
|
One trivial edit in fx_basic.h
Includes both fixes for build breakage.
Review URL: https://codereview.chromium.org/1653253002 .
(cherry picked from commit 9b0a59d659d8083802385649ba74370d65c41e36)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1655423002 .
|
|
This reverts commit 1be28d1b037de32c75632e10e7d2fc758fe7f962.
BUG=pdfium:369
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1659463006 .
|
|
XFA document should be released before SDK document is
released.
BUG=pdfium:369
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1652883002 .
|
|
One trivial conflict in fsdk_mgr.h
Review URL: https://codereview.chromium.org/1658853002 .
(cherry picked from commit 1654972e0c81f1841653f803903cc48b93f1738e)
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1651313002 .
|
|
Original Review URL: https://codereview.chromium.org/1652613002 .
(cherry picked from commit 0841b0f37678ba4962247f5636e9390718fc027e)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1657663003 .
|
|
Original Review URL: https://codereview.chromium.org/1654523002 .
(cherry picked from commit 3859258ebe9e81e1f766b57e7f78c786ae4ed495)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1658753002 .
|
|
- Remove dead code.
- Add more public methods and remove friends.
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1566133002 .
(cherry picked from commit 9e8185948f7631515951770ca8778f42cc9fd2fc)
Review URL: https://codereview.chromium.org/1649233002 .
|
|
Original Review URL: https://codereview.chromium.org/1645413002 .
(cherry picked from commit 6902db5cbaf0afb8f2cb4df325e1a4e7d6acd53f)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1648793006 .
|
|
Original Review URL: https://codereview.chromium.org/1652533002 .
(cherry picked from commit 1bce5f62f3292a6baf35491bf4c9b4fde2fb73e3)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1652543003 .
|
|
This is needed by Cl 1634373003 as the name collision with virtual functions
will be shown as warnings on Linux. Also, it is better to use
different names for different cases.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1644633003 .
(cherry picked from commit d45e7a51904164fb22049f0a7a80d2a94c06936b)
Review URL: https://codereview.chromium.org/1648233002 .
|
|
Original Review URL: https://codereview.chromium.org/1641693003 .
(cherry picked from commit 66519af52b61ca158044651d0507d47efb364f87)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1639253008 .
|
|
BUG=pdfium:348
R=jochen@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1633083002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1641963002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1640033002 .
|
|
Introduce CPDF_Parser::Error.
Introduce CPDF_Color::Type.
Unused XFA_DATASETS and XFA_FORMS defines.
Move FPDF_CreateStandardSecurityHandler() prototype to header.
Delete prototype for nonexistent FPDF_CreatePubKeyHandler().
Make PBS_* defines local to .cpp file.
Tidy whitespace.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1634123004 .
|
|
Contains additional XFA-specific changes.
Original Review URL: https://codereview.chromium.org/1632143002 .
(cherry picked from commit 66a9dc9dd65ed2b9c7ede448d046b770140f16d5)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1636503006 .
|
|
And a few other nits.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1635853002 .
|
|
Original Review URL: https://codereview.chromium.org/1620523002 .
(cherry picked from commit d5712ac571f3487fe3f74617fdab007a11a09052)
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1624553004 .
|
|
Orignal Review URL: https://codereview.chromium.org/1612113003 .
(cherry picked from commit 9ebc84109d7d2f7b81f06f19e5db20888e026c3b)
R=ochang@chromium.org
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1612243002 .
|
|
Original Review URL: https://codereview.chromium.org/1601093009 .
(cherry picked from commit da9355139b5dce270be02af31db326d60f488e8c)
Trivial conflicts/changes in fpdfeditpage.cpp and fpdfxfa_page.cpp.
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1613823003 .
|
|
Original Review URL: https://codereview.chromium.org/1611193003 .
(cherry picked from commit ca6d98f4dfe7d4fc506b72c91f122f471a53c878)
R=ochang@chromium.org
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1613163003 .
|
|
Original Review URL: https://codereview.chromium.org/1610303002 .
(cherry picked from commit f409da4b8a3e6a3885605a47bed4f8798c4703b9)
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1611733002 .
|
|
Original Review URL: https://codereview.chromium.org/1586203006 .
(cherry picked from commit f13d510cf267c27f4c123494de67670ec201cedc)
BUG=pdfium:361
R=ochang@chromium.org
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1603173004 .
|
|
BUG=pdfium:332
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1539193003 .
|
|
There are multiple functions in CPDF_Object class which can cause infinite loop due to recursively calling circular indirect objects. Fix them by deference indirect object first.
BUG=pdfium:355
TBR=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1585533002 .
(cherry picked from commit 90853cb1dfd1bf3803ec21cfae3e93948137be61)
Review URL: https://codereview.chromium.org/1602103004 .
|
|
Although trailer's size value is required by spec, other readers such as
Acrobat or libpoppler can handle without it. Loose up the check to be
more tolerant.
BUG=pdfium:213
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1582193002 .
(cherry picked from commit 34291b900ad0472eef582215cfce0d942a40fd16)
Review URL: https://codereview.chromium.org/1589783004 .
|
|
BUG=pdfium:360
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1585823003 .
(cherry picked from commit 5d5d9fe7bd1c9566b9d6570015b7c60894d9fc0c)
Review URL: https://codereview.chromium.org/1583073004 .
|
|
CPDF_Dictionary.
Also fixes a potential issue in CPDF_Dictionary::ReplaceKey.
TBR=thestig@chromium.org
BUG=577030
Original Review URL: https://codereview.chromium.org/1582963003 .
(cherry picked from commit cae57daaa0f7ed4c92e22c4e7ef30392393d1128)
Review URL: https://codereview.chromium.org/1587703003 .
|
|
BUG=pdfium:348
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1579503002 .
|
|
CPDF_SyntaxParser::GetObject() may enter into an infinite loop when a
signature dictionary doesn't have 'Contents' field. Add a check to
avoid that.
BUG=pdfium:344
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1575833004 .
(cherry picked from commit d3ab0f383f6736657480a8bb418c5e715a1aed3b)
Review URL: https://codereview.chromium.org/1571333004 .
|
|
BUG=pdfium:346
TBR=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1578543002 .
(cherry picked from commit 401cd2dbaaa10790077de2fd70e8101b0bdd0f36)
Review URL: https://codereview.chromium.org/1578873002 .
|
|
Fix lint errors along the way.
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567343002 .
(cherry picked from commit 9adfbb0920a258e916003b1ee9515e97879db82a)
Review URL: https://codereview.chromium.org/1577503002 .
|
|
Replaces CFX_CMapByteStringToPtr. XFA still uses CFX_CMapByteStringToPtr
so it's not completely removed just yet.
Adds begin()/end() to CPDF_Dictionary and removes the
GetStartPos()/GetNextElement() functions to traverse the dictionary.
Callers are changed accordingly. AddValue() is also removed.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1541703003 .
(cherry picked from commit 14f39950451bb9c2a11fbc7173fd47367410f80f)
Review URL: https://codereview.chromium.org/1576033002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567333003 .
(cherry picked from commit 4a24ad858484ecdf9b49481e63060e4d476cf1c7)
Review URL: https://codereview.chromium.org/1569783007 .
|
|
BUG=pdfium:343
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1569343002 .
(cherry picked from commit 149f1db8bba85bdf2b40d330c38f2478695ca0d5)
Review URL: https://codereview.chromium.org/1575663002 .
|
|
Some bits regressed in commit 338805f.
Also merge: IWYU fix after commit c5a8933.
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1544963002 .
Review URL: https://codereview.chromium.org/1570973002 .
(cherry picked from commit c5a8933f260ca1034fde902058442984e55c0f7a)
(cherry picked from commit e6bd31873c3dba3f79c5ebbbefed636948629cc9)
Review URL: https://codereview.chromium.org/1577453002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1572523002 .
|