| Age | Commit message (Collapse) | Author |
|---|
|
This CL changes CountKids to not used CollectionSize and returns size_t
directly. Callers updated as needed.
Bug: pdfium:774
Change-Id: I8862218e62cd13be9473fa8116afd29cd3afde04
Reviewed-on: https://pdfium-review.googlesource.com/19510
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
This CL updates the various call sites to use size_t instead of other
types.
Bug: pdfium:774
Change-Id: Id8b75728b61c0ca1b15bc815831c885d33374f7b
Reviewed-on: https://pdfium-review.googlesource.com/19410
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
This CL cleans up return values, out-params and changes simple methods
to boolean checks where possible in CXFA_WidgetData.
Change-Id: I29daa67993730f3e9d61cb6fdf918a886cc9120e
Reviewed-on: https://pdfium-review.googlesource.com/19230
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
Or change them to clear().
Change-Id: Ia9e3e1f0d74b948cec3f8df85d205f830ac9216c
Reviewed-on: https://pdfium-review.googlesource.com/19172
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
This CL cleans up the CXFA_SubmitData methods by using returns instead
of out-params, sets the correct return types and makes the methods
const.
Change-Id: I41fe8f59e450ca444b64c291ac4a0a199c7ad0cf
Reviewed-on: https://pdfium-review.googlesource.com/19111
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
So callers no longer have to call str.TrimLeft(); str.TrimRight();
Change-Id: If931eaa8d891f487b9618ebbeee5ee294e807846
Reviewed-on: https://pdfium-review.googlesource.com/18990
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
There was a regression due to a refactor, where the public API was no
longer removing soft hyphens for line broken words. This was causing
issues with find and copy/paste operations that depend on selecting a
region of text. This change is covered by
FPDFTextEmbeddertest.GetTextWithHyphen.
FPDFTextEmbeddertest.bug_782596 is a regression test for a bug that was
introduced by the original fix. It only fails when running the test under
ASAN.
BUG=pdfium:935
Change-Id: I26096583c35f9246a3662e702f89b742f1146780
Reviewed-on: https://pdfium-review.googlesource.com/18610
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
|
|
Add checks for matrix and clipRect in function
FPDFPage_TransFormWithClip. If both are null,
abort transformation. If either is null, skip
that particular transaction.
Change-Id: I65611508c064c0b929a11eace99ad532d3402138
Reviewed-on: https://pdfium-review.googlesource.com/18710
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
This CL converts the CFX_DateTime::Now method to be a static and updates
the callers.
Change-Id: I26052c6194ed2d43bca5fee2542787ce166eda85
Reviewed-on: https://pdfium-review.googlesource.com/18670
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
This CL moves the Format and FormatV methods of ByteString to be static.
Bug: pdfium:934
Change-Id: I9c30455a789aff9f619b9d5bf89c0712644f2d9a
Reviewed-on: https://pdfium-review.googlesource.com/18650
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
This CL adds helper methods to CXFA_Node to retrieve the default values
for attributes with the correct data types.
Change-Id: I644435b4b430819f1060a95fa4fffe4ba2826cfe
Reviewed-on: https://pdfium-review.googlesource.com/18450
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
Bug: pdfium:614
Change-Id: I3c6cd16dfe0ac5db66cc9e996d3f4e74a5d9d716
Reviewed-on: https://pdfium-review.googlesource.com/18251
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: Id53f57085fecfe331c8cbfa6bb372b5ea5044442
Reviewed-on: https://pdfium-review.googlesource.com/18332
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
This CL converts SavePackage to accept the CXFA_Node to export instead
of the HASHCODE of the object to retrieve. This simplifies the code in
SavePackage as we don't have to detect if this is the Xfa hashcode.
Change-Id: I73ef9c4aa3d16f433e2d4568fab5f6d34c214635
Reviewed-on: https://pdfium-review.googlesource.com/18111
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
This CL renames CXFA_Submit to CXFA_SubmitData to show it's part of the
data hierarchy.
Change-Id: I6f580a28e41e54ffa1f1c7b799d97f079303463f
Reviewed-on: https://pdfium-review.googlesource.com/18014
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
This CL removes the single use case from |m_bFlagExact|. This flag
allows the PDF viewer to treat a substitute font with a matching name as
if it was actually an embedded font, which is wrong. For all substitute
fonts, it is important to follow the longer process of first obtaining
the unicode from the charcode to then obtain the glyph in the substitute
font that corresponds to that unicode.
Bug: chromium:781785
Change-Id: Ie5958b43914e0e46334b89b7c2c55c02d0da0c11
Reviewed-on: https://pdfium-review.googlesource.com/17859
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
|
|
None of the methods on this class are ever called. We check it once
to make sure it exists, but the call to get it will create it so
it will always exist.
Change-Id: I5b53567c4835f4bb4fe52c42baf28d4290ea517f
Reviewed-on: https://pdfium-review.googlesource.com/17852
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
Change-Id: Iacae9723e88eeae52154276b2478e4fd8c309c2d
Reviewed-on: https://pdfium-review.googlesource.com/15512
Commit-Queue: Art Snake <art-snake@yandex-team.ru>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Fix a mismatched parameter name in cpdf_renderstatus.h too.
Change-Id: I9765838e6ab93db37791fc282e553b6cb9c51ec5
Reviewed-on: https://pdfium-review.googlesource.com/17050
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: I4785dd277b9da072ee3c55e2aaeb688bbf02852e
Reviewed-on: https://pdfium-review.googlesource.com/17391
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: I1c34886a9e33fb16ef121c0aa0b16c139517a940
Reviewed-on: https://pdfium-review.googlesource.com/17392
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: I87fb109fdd121716a170df15c4762496c1ccb88c
Reviewed-on: https://pdfium-review.googlesource.com/17210
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Change-Id: I4a33ad52bf5d0710a44f784da9f50123771b8416
Reviewed-on: https://pdfium-review.googlesource.com/17150
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Art Snake <art-snake@yandex-team.ru>
|
|
Change-Id: I521be6b6548518487ba4eef93d72f29b26809cb5
Reviewed-on: https://pdfium-review.googlesource.com/17110
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
This CL moves all of the CJS files into fxjs. The :javascript build rule
is removed and :fxjs is used instead.
Change-Id: I1701b308f51317d0346c7401b43812c3f43a27bf
Reviewed-on: https://pdfium-review.googlesource.com/17047
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
Change-Id: I50311794b6fb4ef3c38420838ec6c3bb157b06a7
Reviewed-on: https://pdfium-review.googlesource.com/17071
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
This CL renames util.{cpp|h} to cjs_util.{cpp|h} to match the file
contents.
Change-Id: Ia1bcbced0d817e2334310a25b09f9ec56822d600
Reviewed-on: https://pdfium-review.googlesource.com/17046
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
This CL moves the resource.{cpp|h} files to js_resources.{cpp|h}.
Change-Id: I6a9ccb7e0819f40edf4a91e7839a92657d5d39d7
Reviewed-on: https://pdfium-review.googlesource.com/17045
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
This Cl renames report.{cpp|h} to cjs_report.{cpp|h} to match the
contents.
Change-Id: Ifb8846bff5423417f7543e47a45a7e50e18c72c6
Reviewed-on: https://pdfium-review.googlesource.com/17044
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
This CL renames the event.{cpp|h} files to cjs_event.{cpp|h} to match
the internal class.
Change-Id: I0e41a7ee068829f2bc8d94ff926edcf49b3a3c9f
Reviewed-on: https://pdfium-review.googlesource.com/17043
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
This CL renames the console.{cpp|h} files to cjs_console.{cpp|h}.
Change-Id: Icc4f70e9653cd7e11bab305e47c03af07f4e56b0
Reviewed-on: https://pdfium-review.googlesource.com/17042
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
This CL renames color.{cpp|h} to cjs_color.{cpp|h}.
Change-Id: I141435da9e4f6ac38bda85126975fca02e12b17c
Reviewed-on: https://pdfium-review.googlesource.com/17041
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
This CL renames the app.{cpp|h} files to cjs_app.{cpp|h}. The
CJS_TimerObj and GlobalTimer objects have been moved to their own files.
Change-Id: I7a4063b212f1051b1517ec8902a0ee215854feaf
Reviewed-on: https://pdfium-review.googlesource.com/17040
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
This CL renames the PublicMethods.{cpp|h} files to match the internal
class name.
Change-Id: I530f4ce5b53dd74cbef447faf0875782bfe27b70
Reviewed-on: https://pdfium-review.googlesource.com/17039
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
This CL moves CJS_Return to its own files and moves the remaining
function definitions from JS_Value to JS_Define.
Change-Id: Ic7058a02330153f22d1fff9fc6cdebd9167c498b
Reviewed-on: https://pdfium-review.googlesource.com/17038
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
This CL renames JS_Runtime_Stub.cpp to cjs_runtimestub.cpp to match the
contents. The event context stub is moved to to
cjs_event_context_stub.cpp.
Change-Id: I1b231b10aaedd1fe484e55736b0fb562d0a0df88
Reviewed-on: https://pdfium-review.googlesource.com/17037
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
This CL moves JS_Object.{cpp|h} to cjs_object.{cpp|h} and splits the
cjs_embedobj out to its own files.
Change-Id: I8eced9c613455638f4adeefd60e67f38c0c3c1a6
Reviewed-on: https://pdfium-review.googlesource.com/17036
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
This CL renames Icon.{cpp|h} to cjs_icon.{cpp|h}.
Change-Id: Ie0554771441cfa7011205e0c4f461bb7526bb068
Reviewed-on: https://pdfium-review.googlesource.com/17034
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
This CL renames Field.{cpp|h} to cjs_field.{cpp|h}. The CJS_DelayData is
split out into cjs_delaydata.{cpp|h}
Change-Id: If1e3cbbc0d65cbb5cc69ee9862db3fc78ee652e2
Reviewed-on: https://pdfium-review.googlesource.com/17033
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
This CL renames fpdfsdk/javascript/Document.{cpp|h} to
fpdfsdk/javascript/cjs_document.{cpp|h}. The CJS_PrintParamsObj is split
out into cjs_printparamsobj.{cpp|h}.
Change-Id: I29377e7e60b576790fab01e4293c0c1f86339a56
Reviewed-on: https://pdfium-review.googlesource.com/17032
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
This reverts commit 978ba20ffd0d2b37bf02b9d86828fa701c0c02fa.
Reason for revert: I now have the new expected files for the
chrome test ready in
https://chromium-review.googlesource.com/c/chromium/src/+/742061
Landing this again and will immediately add a manual pdfium roll to
cl 742061 to unblock the deps roller.
Original change's description:
> Revert "Reland "Remove ContrastAdjust().""
>
> This reverts commit d5ec7ab0cd0663184d6056bc6fc87c86ec345342.
>
> Reason for revert: Did not mean to reland, just create the reland CL.
>
> Original change's description:
> > Reland "Remove ContrastAdjust()."
> >
> > Original change's description:
> > > Revert "Remove ContrastAdjust()."
> > >
> > > This reverts commit 53d443f042b590ae2d920def16bc9daf66f8427d.
> > >
> > > Reason for revert: Breaks PDFToPWGRasterBrowserTest
> > >
> > > Original change's description:
> > > > Remove ContrastAdjust().
> > > >
> > > > This post-processing increased the contrast of scaled-down features -
> > > > mainly lines and fonts, relative to the background. The effect does not
> > > > improved readability and in some cases makes the scaled-down version
> > > > look like a different document at a glance. Text that is normal
> > > > weight appears bold when scaled down in these cases.
> > > >
> > > > Change-Id: I2544d45e2bcec25d6742d2a60c1316d8df08cce1
> > > > Reviewed-on: https://pdfium-review.googlesource.com/15471
> > > > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> > > > Reviewed-by: dsinclair <dsinclair@chromium.org>
> > >
> > > TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Change-Id: I7f61650bc6d917b3c6640da60f3f740ef4498de0
> > > Reviewed-on: https://pdfium-review.googlesource.com/16970
> > > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> > > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> >
> > TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
> >
> > Change-Id: I77d4377d30908d1e2d4dc842300a761072a5fbd4
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://pdfium-review.googlesource.com/16990
> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
>
> TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
>
> Change-Id: Ie2e91662a1e82c0a793952aab47c2acbde1596d4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://pdfium-review.googlesource.com/16991
> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
Change-Id: Iaae451131043ee69052809680922fdac06a69458
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://pdfium-review.googlesource.com/16992
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
This reverts commit d5ec7ab0cd0663184d6056bc6fc87c86ec345342.
Reason for revert: Did not mean to reland, just create the reland CL.
Original change's description:
> Reland "Remove ContrastAdjust()."
>
> Original change's description:
> > Revert "Remove ContrastAdjust()."
> >
> > This reverts commit 53d443f042b590ae2d920def16bc9daf66f8427d.
> >
> > Reason for revert: Breaks PDFToPWGRasterBrowserTest
> >
> > Original change's description:
> > > Remove ContrastAdjust().
> > >
> > > This post-processing increased the contrast of scaled-down features -
> > > mainly lines and fonts, relative to the background. The effect does not
> > > improved readability and in some cases makes the scaled-down version
> > > look like a different document at a glance. Text that is normal
> > > weight appears bold when scaled down in these cases.
> > >
> > > Change-Id: I2544d45e2bcec25d6742d2a60c1316d8df08cce1
> > > Reviewed-on: https://pdfium-review.googlesource.com/15471
> > > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> > > Reviewed-by: dsinclair <dsinclair@chromium.org>
> >
> > TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Change-Id: I7f61650bc6d917b3c6640da60f3f740ef4498de0
> > Reviewed-on: https://pdfium-review.googlesource.com/16970
> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
>
> TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
>
> Change-Id: I77d4377d30908d1e2d4dc842300a761072a5fbd4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://pdfium-review.googlesource.com/16990
> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
Change-Id: Ie2e91662a1e82c0a793952aab47c2acbde1596d4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://pdfium-review.googlesource.com/16991
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
Original change's description:
> Revert "Remove ContrastAdjust()."
>
> This reverts commit 53d443f042b590ae2d920def16bc9daf66f8427d.
>
> Reason for revert: Breaks PDFToPWGRasterBrowserTest
>
> Original change's description:
> > Remove ContrastAdjust().
> >
> > This post-processing increased the contrast of scaled-down features -
> > mainly lines and fonts, relative to the background. The effect does not
> > improved readability and in some cases makes the scaled-down version
> > look like a different document at a glance. Text that is normal
> > weight appears bold when scaled down in these cases.
> >
> > Change-Id: I2544d45e2bcec25d6742d2a60c1316d8df08cce1
> > Reviewed-on: https://pdfium-review.googlesource.com/15471
> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> > Reviewed-by: dsinclair <dsinclair@chromium.org>
>
> TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Change-Id: I7f61650bc6d917b3c6640da60f3f740ef4498de0
> Reviewed-on: https://pdfium-review.googlesource.com/16970
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
Change-Id: I77d4377d30908d1e2d4dc842300a761072a5fbd4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://pdfium-review.googlesource.com/16990
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
This reverts commit 53d443f042b590ae2d920def16bc9daf66f8427d.
Reason for revert: Breaks PDFToPWGRasterBrowserTest
Original change's description:
> Remove ContrastAdjust().
>
> This post-processing increased the contrast of scaled-down features -
> mainly lines and fonts, relative to the background. The effect does not
> improved readability and in some cases makes the scaled-down version
> look like a different document at a glance. Text that is normal
> weight appears bold when scaled down in these cases.
>
> Change-Id: I2544d45e2bcec25d6742d2a60c1316d8df08cce1
> Reviewed-on: https://pdfium-review.googlesource.com/15471
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: dsinclair <dsinclair@chromium.org>
TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I7f61650bc6d917b3c6640da60f3f740ef4498de0
Reviewed-on: https://pdfium-review.googlesource.com/16970
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
|
|
The second parameter to DefineJSObject is always set the same for each
object type. Remove and put the value directly into the DefineObj calls.
Change-Id: If939c57fe6ea3b985ab2337eb30f472c668cdc42
Reviewed-on: https://pdfium-review.googlesource.com/16911
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
This CL marks all of the Spec arrays as const.
Change-Id: Ie36f670a4230fcac2cba5544b9c6e5179b0c7073
Reviewed-on: https://pdfium-review.googlesource.com/16951
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
This CL removes the static object IDs from each of the CJS_Object
subclasses and moves them to anonymous namespaces. The Spec arrays are
moved to private members of the object classes.
Change-Id: I5dcdb87ef57e4b374b5431580fb55cb75023f8fb
Reviewed-on: https://pdfium-review.googlesource.com/16950
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
This CL removes the g_pClassName static member and uses the string
directly where needed.
Change-Id: I47f61442ced2ee1d6a607fb1a7d9bcaf000b8ee2
Reviewed-on: https://pdfium-review.googlesource.com/16931
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
This CL moves DefineProps, DefineMethods and DefineConsts to the
CJS_Object and removes from the subclasses. The JSConstructor and
JSDestructor are moved to be templated static methods in JS_Defines.
Change-Id: Ibe5ee063a32ae2332b8affc843d97ee6da21f4ee
Reviewed-on: https://pdfium-review.googlesource.com/16930
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
This CL cleans up the methods and arrays for constants, methods and
property definitions which are empty.
Change-Id: I4a4d85cc139075de77d84a40182bd00341c31818
Reviewed-on: https://pdfium-review.googlesource.com/16910
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
