Age | Commit message (Collapse) | Author |
|
BUG=chromium:625823
TBR=haraken@chromium.org,thestig@chromium.org
Review-Url: https://codereview.chromium.org/2128793002
(cherry picked from commit 3c27a84d15c06f85cc7f455f96dc124673f9f9d2)
Review URL: https://codereview.chromium.org/2149763005 .
|
|
BUG=chromium:625823
TBR=haraken@chromium.org,thestig@chromium.org
Review-Url: https://codereview.chromium.org/2123153002
(cherry picked from commit c4dedf32b1f5c71740df5be2a9b1446a01df304c)
Review URL: https://codereview.chromium.org/2148793006 .
|
|
Since PDFium is compiled as C++ code, the void keyword is not needed.
BUG=pdfium:519
Review-Url: https://codereview.chromium.org/2084603003
|
|
This change mainly contains files in xfa/ and fxjse/ directories
which were not covered by previous changes.
This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins. After this change, PDFium can be
compiled with "clang_use_chrome_plugin=true" for GN build. Since
clang_use_chrome_plugin is true by default, we no longer need to
set this parameter explicitly.
The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups;
BUG=pdfium:469
Review-Url: https://codereview.chromium.org/2072803002
|
|
The V8_INLINE tag is for internal V8 usage only and should not be used by
embedders. I've removed it to let the compiler decide on the inlining, if we
determine in the future things need to be force inlined we can add our own
inlining wrapper.
BUG=pdfium:514
Review-Url: https://codereview.chromium.org/2063723002
|
|
This makes it clear that fxjse/ is a standalone component and should not be
entangled with other xfa/ components.
BUG=pdfium:506
Review-Url: https://codereview.chromium.org/2056663004
|