Age | Commit message (Collapse) | Author |
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1783933003 .
|
|
Make .h/.cpp filenames match.
Add header for unicodenormalization.cpp
Remove dead code.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1796303002 .
|
|
This CL moves the two files and breaks fpdf_text.h apart into individual pieces.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1801973002 .
|
|
This CL moves the xfa/src files up to the xfa/ directory and fixes the includes,
include guards, and build files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1803723002 .
|
|
This CL moves the files in fpdfsdk/src/ up one level to fpdfsdk/ and fixes
up the include paths, include guards and build files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1799773002 .
|
|
This CL moves the core/src/ files up to core/ and fixes up the include guards,
includes and build files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1800523005 .
|
|
Mainly change the code to avoid the warnings; in a few cases we have
to use explicit casts.
BUG=pdfium:29
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1783023002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1776913007 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1778173002 .
|
|
CPDF_CryptoHandler was always a pure-virtual class, now it
is named as IPDF_ to indicate this.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1782673002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1781593003 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1773103003 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1780503002 .
|
|
This reverts commit 06fae28d307fe051f0c7e890344cd487c2260910.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1775023003 .
|
|
This reverts commit d50095fb151688e119a7097aabce11e4b3d36244.
Reason for revert: build broken.
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1774293002 .
|
|
BUG=
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1774753002 .
|
|
This reverts commit 594912241cd7d409b5f58a48ccffdc1904d844b2.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1769273002 .
|
|
This Cl moves the code in xfa/src/fxfa/src/common to the diretory which
contains the respective implementations and removes the xfa/src/fxfa/src/common
directory. It them moves all of the code in xfa/src/fxfa/src up one level and
removes the xfa/src/fxfa/src
directory.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1770073003 .
|
|
The agg driver files are split into src/ and include/ directories. This CL
moves the source files up one level and removes the src/ and include/
directories.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1773593007 .
|
|
This reverts commit 5ad8474335798295a9c502999324635845d28ff7.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1772713002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1761233002 .
|
|
This reverts commit 44beca7313284a60c21b4973d42f993b8c248ec9.
Reason: broken build on chromium bots.
R=ochang@chromium.org
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1766823002 .
|
|
This only directs paths to use Skia. Text and bitmaps
still use antigrain.
Clipping is disabled -- still figuring out pdfium's model
for saving and restoring clips.
Deleting the Skia canvas is disabled -- there's some build problem
where the pdfium and skia libraries are built with slightly
different options that I haven't tracked down. This is also why
for the moment SkDebugf is defined locally.
With this patch and pdf_use_skia=1 a modestly complicated PDF draws
(mostly) correctly with pdfium_test.
R=dsinclair@chromium.org, tsepez@chromium.org, dsinclair
BUG=
Review URL: https://codereview.chromium.org/1761453002 .
|
|
This CL will enable the chromium-style checks when building. It is currently
disabled by default as there are a lot of warnings.
I only added this to GYP because there is no standalone GN build, so I have
no way to test.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1760213002 .
|
|
Currently, there is a check that an object number is <= 0x1000000. If that
check fails, we end up putting the parser into a bad state and fail to load
documents. The object does not need to be in the XRef table, or referenced
from the document, just be in the document.
This Cl removes the size check and updates the various atoi calls to use a
uint32_t instead of an int32_t so we don't end up getting strange values when
converting from a string.
BUG=455199
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1755273002 .
|
|
Part of the work required to ship XFA with chrome.
BUG=pdfium:396
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1763493002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1748803002 .
|
|
Renaming these files will allow them to be picked up by git cl format and the
linter.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1733653002 .
|
|
Change implicit conversion to accessor function, remove unused function
and unused parameter, add a couple checks for null pointers, and some
cleanup.
BUG=pdfium:247
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1703183002 .
|
|
Remove unused member functions and simplify calls to find tag parameters.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1681403007 .
|
|
- NormalizeString() has 1 caller:
- CTextBaseLine::WriteOutput(), which has only 1 caller:
- CTextPage::WriteOutput(), which has only 1 caller:
- PDF_GetPageText_Unicode(), which has only 1 caller:
- PDF_GetPageText(), which has no callers.
Removing this also makes CheckRotate(), NormalizeCompositeChar(),
and CTextPage unused.
Removing those makes CTextBaseline() unused.
Removing that makes txtproc.h unused.
PDF_GetTextStream_Unicode also unused.
... and so on until entire files can be removed.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1689843002 .
|
|
Also, use full path to include "text_int.h", as there are
two of them; I suspect that fpdf_text_search was including
the wrong one as the compiler didn't complain about a
signature mismatch I had overlooked.
In fact, rename the fxge file to avoid collision completely.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1679743003 .
|
|
Original Review URL: https://codereview.chromium.org/1652533002 .
(cherry picked from commit 1bce5f62f3292a6baf35491bf4c9b4fde2fb73e3)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1652543003 .
|
|
This is a regression from commit 90853cb.
BUG=pdfium:365
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1617043004 .
(cherry picked from commit 7671d304ca4d3aec658c0ac8d5eea4c64e23b144)
Review URL: https://codereview.chromium.org/1628643002 .
|
|
Original Review URL: https://codereview.chromium.org/1580573002 .
(cherry picked from commit a505d9d3e13485e090e50d5d83f882fb707d3f48)
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1610163003 .
|
|
Original Review URL: https://codereview.chromium.org/1554133003 .
(cherry picked from commit d368261cc8d604286e29ca6358700e6bb051dcaa)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1567643002 .
|
|
Also do some cleanups in affected files.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1552583002 .
(cherry picked from commit d794d34b5deb6ad691c19af758090f9ce46015a3)
Review URL: https://codereview.chromium.org/1566583002 .
|
|
Original Review URL: https://codereview.chromium.org/1556033002 .
(cherry picked from commit 603533fb0e5968923d67c1d8f2e00a640f41b5e5)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1563483003 .
|
|
Original Review URL: https://codereview.chromium.org/1557173002 .
(cherry picked from commit 14fdb1d40741912e430db4318a9033764429659f)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1556983003 .
|
|
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1547833002 .
(cherry picked from commit d20dfba2ae10e8aeb328328f09da79ff904110a8)
Review URL: https://codereview.chromium.org/1545183002 .
|
|
BUG=515137,564736
TBR=ochang@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1533233002 .
Review URL: https://codereview.chromium.org/1544493003 .
(cherry picked from commit b426e3edde040089b70d1a223c83b90957aa571d)
(cherry picked from commit bd35d484a4027775f19ff93e9143e0b270133d42)
Review URL: https://codereview.chromium.org/1546443002 .
|
|
An email address contains user name part and host name part.
User name allows dash or underscore, but not leading/ending/double
period. Host name doesn't allow leading/ending/double
period either.
BUG=489107
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1530763005 .
(cherry picked from commit cc70b7b55c9edcd0ff038f59080699060fbbede1)
Review URL: https://codereview.chromium.org/1532303002 .
|
|
Allows "all" to include pdfium:* once again, since targets
that don't exist except under xfa are hidden.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1502343007 .
|
|
This allows standalone pdfium builds to build with XFA, but
makes a chromium checkout revert to non-xfa even on this
branch. GN implies a chromium checkout at the moment, so
disable XFA there, too.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1508003003 .
|
|
This first pass is GYP-only, will do GN in the next CL.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1480403002 .
|
|
This reverts commit 0569ab0b11b723d9bca4ddd642b0cf8828c4bdd1.
This changes the various comparisons of char >= '0' && char <= '9' and
char < '0' || char > '9' to use std::isdigit checks. It also cleans up
a handful of hex to digit conversions to call one common method.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1449873003 .
(cherry picked from commit 3f148915d12f54a946a0c0bf526162b79c39d650)
Review URL: https://codereview.chromium.org/1452673002 .
|
|
CPDF_DIBSource::DownSampleScanline32Bit
Previously, if |m_bpc| was < 8 (e.g. 4), this function may still try to
access the source components as if |m_bpc| == 8. Even when it fell into
the codepath that tried to do the right thing in this case, it was
wrong.
BUG=554151
TBR=tsepez@chromium.org
Committed: https://pdfium.googlesource.com/pdfium/+/9b99615806e358fdb396d1cb162ee2e69c2a20ec
Review URL: https://codereview.chromium.org/1433423002 .
(cherry picked from commit e21fe98d5b5da7da01503b985b07b90c8e811689)
Review URL: https://codereview.chromium.org/1441563002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1437603002 .
(cherry picked from commit 21e079dd982f57daa9d5af0d9e48d58189ce35da)
Review URL: https://codereview.chromium.org/1421303006 .
|
|
BUG=446715
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1353093003 .
Conflicts:
core/include/fpdfapi/fpdf_parser.h
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp
samples/pdfium_test.cc
testing/embedder_test.cpp
testing/embedder_test.h
Review URL: https://codereview.chromium.org/1412083010 .
|
|
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1420693004 .
(cherry picked from commit 37e4a11e58257b757bec2700bc53facc59d0b845)
Review URL: https://codereview.chromium.org/1423583005 .
|