Age | Commit message (Collapse) | Author |
|
This allows standalone pdfium builds to build with XFA, but
makes a chromium checkout revert to non-xfa even on this
branch. GN implies a chromium checkout at the moment, so
disable XFA there, too.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1508003003 .
|
|
This first pass is GYP-only, will do GN in the next CL.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1480403002 .
|
|
This reverts commit 0569ab0b11b723d9bca4ddd642b0cf8828c4bdd1.
This changes the various comparisons of char >= '0' && char <= '9' and
char < '0' || char > '9' to use std::isdigit checks. It also cleans up
a handful of hex to digit conversions to call one common method.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1449873003 .
(cherry picked from commit 3f148915d12f54a946a0c0bf526162b79c39d650)
Review URL: https://codereview.chromium.org/1452673002 .
|
|
CPDF_DIBSource::DownSampleScanline32Bit
Previously, if |m_bpc| was < 8 (e.g. 4), this function may still try to
access the source components as if |m_bpc| == 8. Even when it fell into
the codepath that tried to do the right thing in this case, it was
wrong.
BUG=554151
TBR=tsepez@chromium.org
Committed: https://pdfium.googlesource.com/pdfium/+/9b99615806e358fdb396d1cb162ee2e69c2a20ec
Review URL: https://codereview.chromium.org/1433423002 .
(cherry picked from commit e21fe98d5b5da7da01503b985b07b90c8e811689)
Review URL: https://codereview.chromium.org/1441563002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1437603002 .
(cherry picked from commit 21e079dd982f57daa9d5af0d9e48d58189ce35da)
Review URL: https://codereview.chromium.org/1421303006 .
|
|
BUG=446715
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1353093003 .
Conflicts:
core/include/fpdfapi/fpdf_parser.h
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp
samples/pdfium_test.cc
testing/embedder_test.cpp
testing/embedder_test.h
Review URL: https://codereview.chromium.org/1412083010 .
|
|
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1420693004 .
(cherry picked from commit 37e4a11e58257b757bec2700bc53facc59d0b845)
Review URL: https://codereview.chromium.org/1423583005 .
|
|
so tests can be run from any directory.
Previously the tests which read test files assume the current directory is under pdfium. Running from any other directory will break the build.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1408003014 .
(cherry picked from commit c0e93a9a942fe7d99800502a61d2fbb58cf9276f)
Conflicts:
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp
fpdfsdk/src/fpdfdoc_embeddertest.cpp
testing/embedder_test.cpp
testing/embedder_test.h
Review URL: https://codereview.chromium.org/1411403012 .
|
|
- In non-standalone builds, use the provided jpeg library.
- Run gn format over all the GN files.
- Also roll DEPS for buildtools to c2f2598.
- And fix XFA's lack of #includes.
BUG=541704
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1425153006 .
(cherry picked from commit 34bb6c58fe60206a08dc0a1f37b7cfe83e8c762c)
Review URL: https://codereview.chromium.org/1434543003 .
|
|
Forgot to do so in commit 461b634b8b45bf022412b364fac37f6ad3cafb69.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1431073003 .
|
|
BUG=pdfium:29
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1411583005 .
Review URL: https://codereview.chromium.org/1431563002 .
Review URL: https://codereview.chromium.org/1419943006 .
Review URL: https://codereview.chromium.org/1415483003 .
Review URL: https://codereview.chromium.org/1414073005 .
Review URL: https://codereview.chromium.org/1415883010 .
(cherry picked from commit 9f4def68601ec75b85b92077c521b9423b4f7f00)
(cherry picked from commit 23e20f2d3ce5b416e1c7f7f1c2d68c90ddf2d4ad)
(cherry picked from commit a6e2a4eca1be4daf14fae4e2427a6ca76269db43)
(cherry picked from commit bfba4cb7f22fc19a5e71559f09f2cde19fbb6a79)
(cherry picked from commit 81edc51ef8242205c5a1192bc33bf16d8c96120b)
(cherry picked from commit 1630dffdc1d554d8f2319e83cdbd7b12f480362d)
Review URL: https://codereview.chromium.org/1421963005 .
|
|
Also adds a README.pdfium and 0000-include.patch that
details the local modifications made.
Also rolls testing/corpus to 45f88c6914fcac26ad930bb0ebbfa468c21db0a5
which includes regenerated corpus expectations.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1413673003 .
(cherry picked from commit 87ee069d05ca06f60d6cfacd9e426739d8f2053d)
Review URL: https://codereview.chromium.org/1416993005 .
|
|
Also cleans up some places in the relevant functions since we're here.
BUG=551460
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1421783004 .
Clean merge.
(cherry picked from commit 4f85605cbc652a17bc833f883186e0a68af6006d)
Review URL: https://codereview.chromium.org/1405383009 .
|
|
This CL adds tests for the ReadHexString method of the syntax parser.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1433503002 .
(cherry picked from commit 71ad9a0028a183605fba734c48b4756d6caa7754)
Review URL: https://codereview.chromium.org/1424923007 .
|
|
This CL adds a unit test for the ReadHexString method.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1408213008 .
(cherry picked from commit c89c6195373b63e99b9cd432c5a181bfb3ad8dbe)
Review URL: https://codereview.chromium.org/1417713003 .
|
|
This CL adds tests for the CMap_GetCode and CMap_GetCodeRange methods. To do
so, it moves the methods to be static private members of CPDF_CMapParser and
makes the test class a friend.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1414013005 .
(cherry picked from commit afca65ac019d2ad4cb8ac8f585809cc1a519ac2b)
Review URL: https://codereview.chromium.org/1429943002 .
|
|
I moved the declaration to be public, instead of having it implicit in one
file and defined in a seperate cpp file.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1410873009 .
(cherry picked from commit e948a4ee08b78e27da37bc12244fa1b66d927dc7)
Review URL: https://codereview.chromium.org/1432513002 .
|
|
This CL adds a test case for the StringToCode and
StringToWideString methods in fpdf_font.cpp. In order
to do so, it moves the methods to be private methods of CPDF_ToUnicodeMap and
make the tests friends of the class.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1428593005 .
(cherry picked from commit 52b0b525dca3d982a04b77fa6d0913aff1e5fd9c)
Review URL: https://codereview.chromium.org/1425233004 .
|
|
(cherry picked from commit 3d59bd9d66d01eb39c30742bce67fa0376cb4ea8)
Review URL: https://codereview.chromium.org/1407903005 .
Conflicts:
core/include/fxcodec/fx_codec_provider.h
core/src/fxcodec/codec/codec_int.h
core/src/fxcodec/codec/fx_codec_jpeg.cpp
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1412713009 .
|
|
-L isn't used for creating static libraries. This flag isn't present on
non-Linux or in the gn file either.
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1425213003 .
(cherry picked from commit b0337e68fb84c807e0d898aecaad0074444d62e0)
Review URL: https://codereview.chromium.org/1432453002 .
|
|
- Replace IFX_BidiChar with just CFX_BidiChar
- Document implementation
- Change out parameters to pointers
- Remove dead code
- Add an enum for bidi directions
- Move several externs to a header
- Add unit tests
Original CL: https://codereview.chromium.org/1197643002
This version does not remove fx_arb.h and fx_arabic.h, as there is code
on the XFA branch that still uses parts of it.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1423103002 .
|
|
A template node is mandatory in XFA file. Pdfium should
ignore processing it when no template node is found in
XFA file.
BUG=pdfium:216
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1423903002 .
|
|
The m_pShadingObj can be a stream or a dictionary depending on how it's used.
This CL adds some simple type checking to make sure that the type of the
object matches what we expect.
BUG=chromium:547706
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1421973004 .
(cherry picked from commit 4ef782ab57979add3e3910d6bcfde6ef59f65724)
Review URL: https://codereview.chromium.org/1422253002 .
|
|
Revert "Add an embedded test case"
This reverts commit ec44186fdbca423eddf432be8b5c38914674023a.
Revert "Update the format"
This reverts commit 1df068061b5bb5e768a623318186523ffd251aaa.
Revert "Update .in file"
This reverts commit c13090439e1fbfd8a18c358058f137f897a7477b.
Revert "Address review comments"
This reverts commit 24967515b8be77a79aa1599f8fbf5d3ecbcd1769.
TBR=jun_fang@foxitsoftware.com
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1414033007 .
|
|
|
|
BUG=pdfium:241
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1422193002 .
(cherry picked from commit 24b2eab6351920dd60210b6dcd350c9921e7b3b5)
Review URL: https://codereview.chromium.org/1421343004 .
|
|
Cloning a CPDF_Stream actually happens via CPDF_Object::Clone().
Transitively, remove:
- GetStreamFilter()
-- all the filters.
Also remove CXFA_FileRead.
R=jam@chromium.org
Review URL: https://codereview.chromium.org/1288543002 .
(cherry picked from commit c9a05f1c90860a97dbe4b8014bc4584bfa3a4580)
Review URL: https://codereview.chromium.org/1297463002 .
|
|
This Cl syncs the AUTHORS, and README.md and build scripts in XFA to match master where possible.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1415423002 .
|
|
None of the methods in this file are used and it is not included anywhere. Removing.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1417783004 .
(cherry picked from commit 704da531215c4f81279eb763192de398f7d03748)
Review URL: https://codereview.chromium.org/1413943004 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1411963002 .
(cherry picked from commit 8b8dfd7934d669b2c74a0502f82387e5df0f573b)
Review URL: https://codereview.chromium.org/1415513004 .
|
|
Original Review URL: https://codereview.chromium.org/1416713002 .
(cherry picked from commit 6d34d056a7188b7ae9800fe3ceb68645e0442879)
Conflicts:
BUILD.gn
samples/BUILD.gn
samples/pdfium_test.cc
samples/samples.gyp
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1413593003 .
|
|
Take extern tables portion only of fx_bidi change.
Take itoa fixes and corresponding unit test.
Merge typo in skia font mgr.
Kill some null checks after new.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1409223002 .
|
|
Original Review URL: https://codereview.chromium.org/1395733006 .
(cherry picked from commit f1c713663192368d26031a4caed1f9705f4510af)
Conflicts:
BUILD.gn
fpdfsdk/src/fpdfview.cpp
fpdfsdk/src/javascript/JS_Runtime.cpp
pdfium.gyp
samples/BUILD.gn
samples/samples.gyp
BUG=pdfium:211
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1393833006 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1399833002 .
|
|
We did this with the other codecs in master, but these two are
XFA-only, and did not get the same treatment.
Remove some fx_ prefixes in the third-party file names.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1392373004 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1393823002 .
(cherry picked from commit a0f2b67bd659e3f1780edfac56d8754bca685d5f)
Review URL: https://codereview.chromium.org/1390883004 .
|
|
(cherry picked from commit 5b3d0208723f21c50b9922bdc500c9d78c359a25)
Original Review URL: https://codereview.chromium.org/1389783002 .
New changes to fix IWYU in:
fpdfsdk/include/fpdfxfa/fpdfxfa_app.h
xfa/include/fxfa/fxfa.h
xfa/include/fxfa/fxfa_objectacc.h
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1388023003 .
|
|
Small manaul merge in JS_Object.cpp
(cherry picked from commit 5e8b7356d68e35d7d631a2a917e651a4e7c73b65)
Original Review URL: https://codereview.chromium.org/1385983002 .
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1381233005 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1359233002 .
(cherry picked from commit 630a28442364f03c1d3d9b48873da42755e1fddf)
Review URL: https://codereview.chromium.org/1364083004 .
|
|
(cherry picked from commit dd7a7f012424ec8505830710ac0dd0183203c189)
Original Review URL: https://codereview.chromium.org/1358163002 .
TBR=jyasskin@chromium.org
Review URL: https://codereview.chromium.org/1362763002 .
|
|
(cherry picked from commit b17d62601b21dfce85718e08cfd0ffce3a45d74e)
(cherry picked from commit 09ed30750282bf56a92d0e646ab22c64bea81a36)
Manual edits:
fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp - add lockers.
fppdfsdk/src/javascript/JS_Runtime.cpp - rework XFA init path.
Original Review URL: https://codereview.chromium.org/1338073002 .
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1348433002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1326953006 .
(cherry picked from commit 70f4404e9a9e69afdfdd07715aa946f6561ce0cb)
Review URL: https://codereview.chromium.org/1336783002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1297593005 .
(cherry picked from commit bcfcc4619017b7f70c84a582196763894cc72d24)
Review URL: https://codereview.chromium.org/1306673002 .
|
|
(cherry picked from commit 71c15a5e6652952a94ba3a3ef7ac0392e3a06962)
Original Review URL: https://codereview.chromium.org/1299963002 .
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1301073003 .
|
|
(cherry picked from commit dacc22cdfea727a04bce086d9bfec9a4d1a29bd4)
Orignal Review URL: https://codereview.chromium.org/1240713004 .
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1230373003 .
|
|
(cherry picked from commit 012ada613a1462f109eb59790f8e5ee91aacdb7e)
Review URL: https://codereview.chromium.org/1199553002.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1197893002.
|
|
(cherry picked from commit 959eb05140a8f5af7724a2da4cf5d04e2e50f4a6)
Original Review URL: https://codereview.chromium.org/1197693003.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1197863002.
|
|
Original Review URL: https://codereview.chromium.org/1185373010.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1193773002.
|
|
Original Review URL: https://codereview.chromium.org/1186113005.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1175193007.
|
|
Original Review URL: https://codereview.chromium.org/1181943008.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1187273006.
|