Age | Commit message (Collapse) | Author |
|
Orignal Review URL: https://codereview.chromium.org/1563513002 .
(cherry picked from commit aa326bd6b169dc1b5b9b83048c71799799ab34c6)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1564583004 .
|
|
Original Review URL: https://codereview.chromium.org/1554363002 .
(cherry picked from commit ed34cdf99d5a4b33e57f81f9244a311f6fb86db3)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1559373002 .
|
|
This reverts commit 054fc955c153eb5c581fd14946848b8b2a77136a.
Additionally, this rolls DEPS for the testing corpus to update test
expectations.
BUG=pdfium:336
TBR=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1555833002 .
(cherry picked from commit 5594538fcc96c38db34f336223140cf703e3cca0)
Review URL: https://codereview.chromium.org/1553013002 .
|
|
This first pass is GYP-only, will do GN in the next CL.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1480403002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1476683002 .
|
|
That refer to parent directories.
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1434223002 .
(cherry picked from commit 22bc4227fbbda5a5e9abad2a2c0a98c04fe7f228)
Review URL: https://codereview.chromium.org/1439223003 .
|
|
pdfium_test
BUG=446715
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1410073009 .
Review URL: https://codereview.chromium.org/1413103007 .
|
|
BUG=446715
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1353093003 .
Conflicts:
core/include/fpdfapi/fpdf_parser.h
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp
samples/pdfium_test.cc
testing/embedder_test.cpp
testing/embedder_test.h
Review URL: https://codereview.chromium.org/1412083010 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1415803007 .
(cherry picked from commit 5899671184d01b74989d181363066379ef3e4051)
Review URL: https://codereview.chromium.org/1431593007 .
|
|
- In non-standalone builds, use the provided jpeg library.
- Run gn format over all the GN files.
- Also roll DEPS for buildtools to c2f2598.
- And fix XFA's lack of #includes.
BUG=541704
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1425153006 .
(cherry picked from commit 34bb6c58fe60206a08dc0a1f37b7cfe83e8c762c)
Review URL: https://codereview.chromium.org/1434543003 .
|
|
This regressed in commit 794c9b6.
BUG=551248
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1424743006 .
(cherry picked from commit 8cadf995e9a0fec8da19f69edac9d10fccca7eed)
(cherry picked from commit 955930dce7e4b5c764cdd34b134baea4207de523)
Review URL: https://codereview.chromium.org/1416663008 .
|
|
This CL makes the pdfium_test app a little less chatty by removing the print
statements around linearized paths.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1415333007 .
(cherry picked from commit 0bbb2d855b938c7dda3dd56baf7131b1861ae850)
Review URL: https://codereview.chromium.org/1415373003 .
|
|
Currently if pdfium_test fails to load the document it just says it failed. This
CL adds some extra context by looking at the error set by the load and reporting
it to the user.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1413923006 .
(cherry picked from commit e6eae266a48cdcfd464f52df68c97183a4f7987a)
Review URL: https://codereview.chromium.org/1423123002 .
|
|
- add FPDFAvail_Destroy(pdf_avail) on the early return path in RenderPdf
TBR=thestig@chromium.org
BUG=pdfium:236
Review URL: https://codereview.chromium.org/1410333007 .
(cherry picked from commit 0223be82e0afcfee7c501ad2754230353bff79ff)
Review URL: https://codereview.chromium.org/1414913003 .
|
|
Original Review URL: https://codereview.chromium.org/1416713002 .
(cherry picked from commit 6d34d056a7188b7ae9800fe3ceb68645e0442879)
Conflicts:
BUILD.gn
samples/BUILD.gn
samples/pdfium_test.cc
samples/samples.gyp
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1413593003 .
|
|
Original Review URL: https://codereview.chromium.org/1395733006 .
(cherry picked from commit f1c713663192368d26031a4caed1f9705f4510af)
Conflicts:
BUILD.gn
fpdfsdk/src/fpdfview.cpp
fpdfsdk/src/javascript/JS_Runtime.cpp
pdfium.gyp
samples/BUILD.gn
samples/samples.gyp
BUG=pdfium:211
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1393833006 .
|
|
New code changes in JS_Runtime.cpp.
(cherry picked from commit 3dedace9623fef6161a8666e53a4ab2b9be61e4c)
Original Review URL: https://codereview.chromium.org/1367033002 .
Also merge to XFA: Run FXJS_V8 embedder tests against a shared isolate,
since the two go together.
(cherry picked from commit 4ea721cb7954898a9722c389dae86c62957352d0)
Original Review URL: https://codereview.chromium.org/1377293004 .
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1381633008 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1362143002 .
(cherry picked from commit c4e940d803113552a146cd059b1ca793a1f72a22)
Review URL: https://codereview.chromium.org/1362953006 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1268323004 .
(cherry picked from commit 9311163b564785a3a3ccdcb09bd3b7d0b2976d1a)
Review URL: https://codereview.chromium.org/1368513002 .
|
|
Fix lint issues / git cl format.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1357423006 .
(cherry picked from commit 155345e2c47188fa65da1603b7f06c986707bb69)
Review URL: https://codereview.chromium.org/1367633004 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1287863002 .
(cherry picked from commit 388a3b0b8d6f75d47978c08299300f121f04884c)
Review URL: https://codereview.chromium.org/1292653002 .
|
|
Origin Review URL:
- https://codereview.chromium.org/1234053003
- https://codereview.chromium.org/1241863004
- https://codereview.chromium.org/1235303003
R=tsepez@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1263963002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1234323003 .
|
|
Clang warns if there are missing braces around a subobject
initializer. The most common idiom that triggers this is:
STRUCT s = {0};
if the first field of STRUCT is itself a struct. This can
be more simply written as:
STRUCT s = {};
which also prevents the warning from firing.
Other instances of the warning have been fixed by adding
braces where appropriate.
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1213523004.
|
|
The following files needed adjustment beyond a mechanical merge:
fpdfsdk/src/fpdfview.cpp
public/fpdf_formfill.h
samples/pdfium_test.cc
testing/embedder_test.cpp
Original Review URL: https://codereview.chromium.org/1130843003
BUG=pdfium:158
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1137233002
|
|
Original Review URL: https://codereview.chromium.org/1135913002
BUG=pdfium:154
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1136703003
|
|
Original Review URL: https://codereview.chromium.org/1124423006
BUG=pdfium:114
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1137753003
|
|
BUG=452793
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/973673002
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/946103003
|
|
This pulls in:
7435e8e Run pixel tests via automated script.
83c87e5 run_javascript_tests.py: Be more flexible about directory layout.
5898509 Test top-level Document JS properties.
9f93baf Create run_javascript_tests.py
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/923293002
|
|
https://codereview.chromium.org/902753002/ to XFA branch
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/887073005
|
|
Original Review URL: https://codereview.chromium.org/872103003
TBR=jam@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/901403004
|
|
Lays the groundwork for pixel-diffing tests in pdfium.
This is a port of chromium's tools/image_diff/image_diff_png.cc onto the
top of the fxcodec-provided version of libpng. pdfium_test is modified
to support the new format, and the tools/image_diff.cc image comparison
utility is provided, stripped of its base/ dependencies.
Unfortunately, this can't be back-ported to origin/main, since the
underlying PNG support isn't present inside pdfium.
BUG=https://code.google.com/p/pdfium/issues/detail?id=62
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/870203005
|
|
It turns out that pdfium rendering takes some significantly different paths
when the output bitmap size is the same as the document size, since it can
avoid work in that case. For example, to reproduce the referenced bug, a scale
factor less than 1.0 is required, so we add a parameter to let pdfium_test
cover that case.
BUG=451265
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/861203003
|
|
Fix a few windows compile warnings
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/817753002
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/814903002
|
|
This is a quick patch to fix the segv which occurs in pdfium_test when
the v8 external data is not provided. Fixing the full-up initialization
is left as a follow-on exercise.
Path manipulations remain a nuisance since we don't want to depend on a
particular /base library.
BUG=439793
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/810793004
|
|
Simplify PDFium by removing code that's not used in the open source repo.
-remove parameter from FPDF_InitLibrary
-remove a bunch of ifdefs that are unused
Fix build after previous commit.
TBR=tsepez@chromium.org
BUG=
Review URL: https://codereview.chromium.org/809513002
|
|
This is needed as an aid to testing.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/788433002
|
|
A minor change to make it obvious when generated/test XFA files are not
being fully processed.
R=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/732173003
|
|
BUG=https://code.google.com/p/pdfium/issues/detail?id=82
R=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/743493004
|
|
Review URL: https://codereview.chromium.org/738433003
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/741473003
|
|
|
|
|
|
|
|
See http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/9542/steps/compile%20%28with%20patch%29/logs/stdio
TBR=jun_fang@foxitsoftware.com,
Review URL: https://codereview.chromium.org/506053003
|
|
Pdfium reads the page number from the field of '/Count' but it can't
load the number assigned by this field due to the damaged data. Add a
check to ensure that the required page should be one of loaded pages.
BUG=406090
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/477873003
|
|
R=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/477173003
|
|
R=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/492523002
|
|
BUG=179413
R=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/408403002
|