Age | Commit message (Collapse) | Author |
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1654523002 .
|
|
Moved onto JS_ExpandKeywordParams(), and added a test which
showed the failure to pass all the data back to the embedder.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1645413002 .
|
|
Centralize the "arguments in an object" logic. See the section
"Method Arguments" in the js_api_reference.pdf. Add some tests
to hit the ambiguous cases this section implies, and test that
all parameters are passed end-to-end to our callbacks.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1641693003 .
|
|
Prerequisite for suppressing tests based on build options.
We explicitly delimit everything with [x] so as to make
substring matching trivial in the .py down the road.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1587023005 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1589223002 .
|
|
This was causing pdfium_diff to fail to link on ARM/linux
due to missing neon-specifc symbols. Ideally we could
add the missing symbols (and update the latest version
of libpng), but that can happen in a separate CL.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1581193007 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1563513002 .
|
|
Given the helper routines, use it in the find bookmark test
instead of just trusting another bookmarks title.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1554363002 .
|
|
This reverts commit 054fc955c153eb5c581fd14946848b8b2a77136a.
Additionally, this rolls DEPS for the testing corpus to update test
expectations.
BUG=pdfium:336
TBR=jun_fang@foxitsoftware.com
Original Review URL: https://codereview.chromium.org/1555773003
Review URL: https://codereview.chromium.org/1555833002 .
|
|
This reverts commit 84f6a5616be0a1988d361a4b54eb83fff8b8c59f.
BUG=pdfium:336
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1554883002 .
|
|
This reverts commit e67f618a7c31c1746cba590482e59d5a8849ff73.
BUG=pdfium:336
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1553893002 .
|
|
BUG=pdfium:336
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1554773004 .
|
|
BUG=pdfium:336
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1555773003 .
|
|
R=dml@google.com, thakis@chromium.org
Review URL: https://codereview.chromium.org/1544923002 .
|
|
BUG=pdfium:299
R=kcc@chromium.org
Review URL: https://codereview.chromium.org/1520443002 .
|
|
BUG=
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1477603002 .
|
|
R=thestig@chromium.org, thakis@chromium.org
BUG=556808
Review URL: https://codereview.chromium.org/1452013004 .
|
|
That refer to parent directories.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1434223002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1415803007 .
|
|
- In non-standalone builds, use the provided jpeg library.
- Run gn format over all the GN files.
- Also roll DEPS for buildtools to c2f2598.
BUG=541704
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1425153006 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1433543005 .
|
|
This regressed in commit 794c9b6.
BUG=551248
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1424743006 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1419373005 .
|
|
BUG=446715
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1410073009 .
|
|
BUG=446715
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1353093003 .
|
|
This CL makes the pdfium_test app a little less chatty by removing the print
statements around linearized paths.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1415333007 .
|
|
Currently if pdfium_test fails to load the document it just says it failed. This
CL adds some extra context by looking at the error set by the load and reporting
it to the user.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1413923006 .
|
|
- add FPDFAvail_Destroy(pdf_avail) on the early return path in RenderPdf
R=thestig@chromium.org
BUG=pdfium:236
Review URL: https://codereview.chromium.org/1410333007 .
|
|
Removes duplication between pdfium_test and pdfium_embeddertest
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1416713002 .
|
|
Adds the following new violations:
ERROR in core/include/fpdfapi/fpdf_parser.h
Illegal include: "public/fpdfview.h"
ERROR in core/include/fpdfapi/fpdf_render.h
Illegal include: "public/fpdf_progressive.h"
ERROR in core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_embeddertest.cpp
Illegal include: "public/fpdfview.h"
BUG=pdfium:217
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1411493002 .
|
|
Original patch from issue 1391843004 at patchset 1
(http://crrev.com/1391843004#ps1)
Introduce a pdf_enable_v8 GYP variable, which controls a
corresponding PDF_ENABLE_V8 #define, and bring in the real
JS library when set. Otherwise, link against a stub JS
runtime.
BUG=pdfium:211
R=dml@google.com, jochen@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1395733006 .
|
|
Move the external isolate and embedder slot from the
IPDF_JSPlatforms struct supplied at the
FPDFDOC_InitFormFillEnvironment() call time to arguments to
the FPDF_InitLibraryWithConfig() call.
This has several benefits:
-- Avoids the crash that could happen if multiple
FPDFDOC_InitFormFillEnvironmen() calls should happen to be
made by an embedder with different slot values.
-- Down the road, for XFA, there may be XFA but no FormFill
environment.
We support both forms for the time being, until the chrome
side catches up, at which point we will deprecate the old
way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1367033002 .
|
|
Also merge a check for failed document loads from XFA.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1362143002 .
|
|
Fix lint issues / git cl format.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1357423006 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1287863002 .
|
|
R=thestig@chromium.org
Committed: https://pdfium.googlesource.com/pdfium/+/d8b5e73d8609b74e6a995ee1768d20d47bd4b089
Review URL: https://codereview.chromium.org/1268323004 .
|
|
This reverts commit d8b5e73d8609b74e6a995ee1768d20d47bd4b089.
Broke corpus tests
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1292153002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1268323004 .
|
|
Luckily, it's just one file.
BUG=none
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1281923004 .
|
|
No behavior change.
Generated by:
find . -name '*.cpp' -o -name '*.h' | \
grep -E -v 'third_party|thirdparties|lpng_v163' | \
xargs ../../buildtools/mac/clang-format -i
See thread "tabs vs spaces" on pdfium@googlegroups.com for discussion.
BUG=none
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1265503005 .
|
|
But use platform freetype for library itself according to the rules
for the platform.
This should greatly reduce per-platform diffs in the corpus tests, but
requires that the corpus be rolled at the same time.
When this rolls into chromium, its src/BUILD.gn will need to be updated
to say third_party:fx_freetype instead of third_party:freetype.
R=jam@chromium.org
Review URL: https://codereview.chromium.org/1267493005 .
|
|
This matches the Chromium PDF plugin changes in
https://codereview.chromium.org/1230313006/
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1237233006 .
|
|
This reverts commit 304578020122cc4d2a4a8c1598694ef2b9be92b5.
Turns out that in both cases v8 is already destructed at those points,
and we can't pump the message loops.
TBR=tsepez@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1236603003 .
|
|
In Chrome, all Isolates must be created by gin
R=tsepez@chromium.org, ulan@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1234053003 .
|
|
R=tsepez@chromium.org, ulan@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/1230393006 .
|
|
Allows the following command to return only legitimate
warnings:
buildtools/checkdeps/checkdeps.py --resolve-dotdot
The remaining warnings consist of:
- fx_parser_filters.cpp, due to inclusion of
third_party/zlib_v128/zlib.h, showing the lack
of a header and some prototypes in that .cpp file.
- third_party/*, due to inclusion of fx_system.h and
the like, indicating adulterated libraries that should
be restored to their pristine state.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1233583004 .
|
|
Clang warns if there are missing braces around a subobject
initializer. The most common idiom that triggers this is:
STRUCT s = {0};
if the first field of STRUCT is itself a struct. This can
be more simply written as:
STRUCT s = {};
which also prevents the warning from firing.
Other instances of the warning have been fixed by adding
braces where appropriate.
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1213523004.
|
|
Removed several header files that simply proxy other headers.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1199553002.
|
|
As indicated by:
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/63417/steps/compile%20%28with%20patch%29/logs/stdio
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1160293003
|
|
This won't post tasks to the background threads
BUG=none
R=kcc@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1157123003
|