Age | Commit message (Collapse) | Author |
|
Change-Id: If4ecef883da6abd654ea271c67e17a981e8aa1f5
Reviewed-on: https://pdfium-review.googlesource.com/c/44078
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Remove two unneeded suppressions from pdfium's skia, as these are
already covered by the //build/config/compiler:no_chromium_code config.
BUG=588506
Change-Id: I347f2c98c6fd13679660fb25df2d2141e9b56e55
Reviewed-on: https://pdfium-review.googlesource.com/41611
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: I210b18e4ab037f1190ddb1362d11973d2e492c75
Reviewed-on: https://pdfium-review.googlesource.com/28490
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
unblocks skia roller, as now some core .cpp files need access to SkCodec.h
Bug:
Change-Id: I0e1375bd167fffbf48b2b27632b213c2e009a868
Reviewed-on: https://pdfium-review.googlesource.com/16090
Commit-Queue: Mike Reed <reed@google.com>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
msarett@ realized that if all of the encoders were disabled, then these
files were equivalent.
Bug:
Change-Id: I1bbfd00b9324fb4b051154089c84b7d759ff1a1f
Reviewed-on: https://pdfium-review.googlesource.com/6810
Commit-Queue: Hal Canary <halcanary@chromium.org>
Reviewed-by: Cary Clark <caryclark@google.com>
|
|
To unblock the roll after https://skia-review.googlesource.com/17927
Change-Id: Iba11a5aa2d0994861e976211f6350c1083d7c6b7
Reviewed-on: https://pdfium-review.googlesource.com/5990
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Cary Clark <caryclark@google.com>
|
|
In a way similar to the existing USE_SYSTEM_LIBJPEG. The default is of
course still the DEPS-based zlib checkout.
Changes in v2:
1) Since Chromium doesn't have //third_party:zlib (AKA a "zlib" target in
//third_party/BUILD.GN) all the targets that depended on //third_party:zlib now
depend on third_party:zlib, which always points to PDFium's
third_party/BUILD.GN. The targets that depended on //third_party:zlib in
third_party/BUILD.GN just depend on :zlib instead.
2) Move the zlib bits out of !build_with_chromium block.
Change-Id: Id73eb07591418ff2ae71b83b87c18af71b49a22a
Reviewed-on: https://pdfium-review.googlesource.com/5030
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
see https://codereview.chromium.org/2843823003/
skia is relying on vulkan in ToT so add that
to pdfium's BUILD.gn. Even if pdfium's skia
DEPS doesn't have third_pary/vulkan, no one
seems to mind that the include directory
doesn't exist.
R=dsinclair@chromium.org
Change-Id: I1363f158755caa5e45031c84c1687134096b3ba2
Reviewed-on: https://pdfium-review.googlesource.com/4570
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Cary Clark <caryclark@google.com>
|
|
This reverts commit 36c5b170e722362d4b5f7cb6e4e0099ed227a307.
Reason for revert: This appears to be blocking the roll into Chromium.
https://chromium-review.googlesource.com/c/476165/
Original change's description:
> core: allow building against system zlib
>
> In a way similar to the existing USE_SYSTEM_LIBJPEG. The default is of
> course still the DEPS-based zlib checkout.
>
> Change-Id: I649e75beb1a19c4cf7abda42fa10ebe5babfe946
> Reviewed-on: https://pdfium-review.googlesource.com/4070
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: Lei Zhang <thestig@chromium.org>
>
TBR=thestig@chromium.org,dsinclair@chromium.org,npm@chromium.org,vmiklos@collabora.co.uk,pdfium-reviews@googlegroups.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I1ee6fb002f444ff9b559ce6a69679e63de7ff9cc
Reviewed-on: https://pdfium-review.googlesource.com/4393
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
BUG=pdfium:559,pdfium:695
Change-Id: I534d8b78ae39946e9b423f29ec3884794b3083fc
Reviewed-on: https://pdfium-review.googlesource.com/4256
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
In a way similar to the existing USE_SYSTEM_LIBJPEG. The default is of
course still the DEPS-based zlib checkout.
Change-Id: I649e75beb1a19c4cf7abda42fa10ebe5babfe946
Reviewed-on: https://pdfium-review.googlesource.com/4070
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
The skia build on Windows is not producing a shared .lib file when building
skia. This Cl updates the Skia component build to correctly generate the
needed shared library.
Bug: pdfium:701
Change-Id: I9545b8fcf76c8622624780ee3cc9ba794f4a842d
Reviewed-on: https://pdfium-review.googlesource.com/3971
Reviewed-by: Cary Clark <caryclark@google.com>
Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
BUG=chromium:541704
Change-Id: I313d8853450ff5940b3baa4054ff441b342c46b7
Reviewed-on: https://pdfium-review.googlesource.com/3350
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
|
|
BUG=pdfium:688
Change-Id: I7787b29d0fedc48f1360ab041d43829d0e805462
Change-Id: I7787b29d0fedc48f1360ab041d43829d0e805462
Reviewed-on: https://pdfium-review.googlesource.com/3331
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
|
|
Will allow us to re-land this
https://skia-review.googlesource.com/c/9891/
BUG=skia:6366
Change-Id: I8a82610309f835065487039883180b8a35733a76
Reviewed-on: https://pdfium-review.googlesource.com/3116
Commit-Queue: Mike Reed <reed@google.com>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
https://skia.googlesource.com/skia.git/+log/f44703a87f532..90e3cd78991
A file was split out to reduce dependencies, added to BUILD.gn.
Change-Id: If3675ddc3b06fcb3fe5cad1165d6fe6d4168a152
Reviewed-on: https://pdfium-review.googlesource.com/2590
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Cary Clark <caryclark@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>
|
|
BUG=
Review-Url: https://codereview.chromium.org/2660353002
|
|
This is already the default value and is the only supported case.
Review-Url: https://codereview.chromium.org/2657453005
|
|
See https://skia-review.googlesource.com/c/5844/
BUG=
NOTRY=True
Review-Url: https://codereview.chromium.org/2569853002
|
|
The canvas clip op changed to a
enum class to safeguard against a
regular enum used as a bool in an
overloaded interface.
R=reed@google.com, dsinclair@chromium.org
Review-Url: https://codereview.chromium.org/2568193002
|
|
BUG=
NOTRY=True
Review-Url: https://codereview.chromium.org/2567053002
|
|
This fixes a pfdium build error when using the Skia backend, due to new Skia files which are not being properly included in the pdfium build.
Review-Url: https://codereview.chromium.org/2403863002
|
|
Update clip to use intersect verb
from canvas.
R=dsinclair@chromium.org
Review-Url: https://codereview.chromium.org/2384283002
|
|
This incorporates the changes from the following Chrome Skia build modifications:
https://codereview.chromium.org/2301233002/
This file is provided by the Skia repo so the GN Chrome build doesn't have
to make assumptions about the location and layout of Skia's GYP files.
https://codereview.chromium.org/2299033006
Remove Skia GYP files from Chromium tree.
Inlines the contents into the GN build.
Review-Url: https://codereview.chromium.org/2316653003
|
|
Review-Url: https://codereview.chromium.org/2210563002
|
|
This permits PDFium to build on the Mac with Skia as the backend. It builds on Linux and Windows as well.
R=dsinclair@chromium.org,bungeman@google.com
Review-Url: https://codereview.chromium.org/1995003002
|
|
The build has been broken. This should make it compilable.
Review-Url: https://codereview.chromium.org/2075343002
|
|
The Skia Windows build for PDFium differs from the
Skia Chromium build in that it uses FreeType within
PDFium and Direct Write within Chromium. This allows
Chrome to match the UI of Windows, and allows
PDFium to use FreeType to measure and draw.
When PDFium was updated to use gn, the settings
from Chrome were used as the basis for the PDFium
settings. Subsequently, PDFium built with Skia on
Windows drew text incorrectly as it used FreeType to
look up the font glyphs and Direct Write to draw them.
This fixes the gn files, and also fixes an error that
crept into the now less-used gyp files.
R=dsinclair@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2055353002
|
|
This CL updates the GN files so the Skia port will build on Windows. This does
not mean the functionaly is correct, just that the binaries link.
Review-Url: https://codereview.chromium.org/2032553002
|
|
On Linux, at least.
BUG=pdfium:11
Review-Url: https://codereview.chromium.org/1971023007
|
|
Fix some bit rot with the Skia build; update the gypi
to current and switch a deprecated call for the current
one.
R=tsepez@chromium.org
Review-Url: https://codereview.chromium.org/1958263002
|
|
This Cl makes GN execute correctly for builds with pdf_use_skia=true enabled.
BUG=pdfium:487
Review-Url: https://codereview.chromium.org/1932683003
|
|
Use FreeType instead of Direct Write on Windows. Since PDFium
currently uses the graphics engine to draw but not to measure,
the graphics engine needs to always use FreeType to get
consistent metrics.
Add a translation from PDF's blend modes to Skia's xfer modes.
Turn on subpixel positioning for text to get more precise
glyph placement.
Pass the alpha through to get proper bitmap transparency.
Address earlier nits.
R=dsinclair@chromium.org, tsepez@chromium.org, dsinclair
Review URL: https://codereview.chromium.org/1812263002 .
|
|
Add missing stdarg.h file so mac can build with skia.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1813633002 .
|
|
This CL fixes up build issues with pdfium_use_skia=1 on windows.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1810063002 .
|
|
This CL adds the necessary pieces so you can add pdf_use_skia=1 to GYP_DEFINES
and do a standalone build.
R=caryclark@google.com
Review URL: https://codereview.chromium.org/1812563002 .
|