Age | Commit message (Collapse) | Author |
|
Change-Id: Ib319cad12707cf2a7211c64b0f950e5f0dd2b094
Reviewed-on: https://pdfium-review.googlesource.com/2493
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
When the results of the test runner were converted to return a tuple the
following code which checked the results for true/false were not updated
to extract the success value from the tuple. This caused the code to think
that the results always passed even when they failed.
This CL fixes the two tests which were broken (both just minor image result
differences) which slipped in during this breakage.
Change-Id: I01b56dd7b05013c2c12c83543746cf59b145e561
Reviewed-on: https://pdfium-review.googlesource.com/2456
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
Originally the key "T" was checked which was not correct since that
key is optional. Now change to check "FT" as well as its parent's
key since this key is also inheritable.
BUG=chromium:440132
Review-Url: https://codereview.chromium.org/2554223002
|
|
It passes on Linux bots.
Review-Url: https://codereview.chromium.org/2516133003
|
|
This picks up many Mac expectation files, though not all Macs render
them the same way. This also adds a new "jetman_std" test case.
All the failures on Mac are suppressed.
BUG=pdfium:626
TBR=npm@chromium.org
NOTRY=true
Review-Url: https://codereview.chromium.org/2516133002
|
|
Review-Url: https://codereview.chromium.org/2387333002
|
|
Each annotation has its contents, and users should be able to see the
contents. In this patch, PDFium creates a Popup annotation for each
annotation and stores the author and the content. When a user mouse
hover on the annotation, PDFium draws the corresponding Popup annotation
and displays the content.
Also, roll DEPS for testing/corpus to 5867fa6.
BUG=62625
Review-Url: https://codereview.chromium.org/2273893002
|
|
Now that PDFium supports drawing of more annotation
types, it should also respect the "hidden" flag that
annotations might feature.
For instance, in IE/Acroread if an annotation is flagged as
"hidden" it does not get drawn.
CL adds a check for the specific "hidden" flag, not drawing
annotation that are flagged with it, in order to match IE + acrobat
reader behavior.
The "flags" definition can be seen by looking at "/F {value}"
syntax in a PDF file source, where {value} is an predefined
integer value.
Test: PDF files being added in [1].
[1] https://codereview.chromium.org/2239713003/
BUG=62625
Review-Url: https://codereview.chromium.org/2239853002
|
|
Test still need modification to process input events. For now,
we just suppress anything that diffs.
Review URL: https://codereview.chromium.org/1894083003
|
|
Patch by cherycherian.
patch from issue 1810153003 at patchset 1 (http://crrev.com/1810153003#ps1)
FormCalc expressions containing double-dot operators in SOM expressions
were failing since XFA_ResolveNodes_AnyChild was always stripping the
leading character.
Roll testing/corpus to d671154 to pick up the test.
BUG=pdfium:434
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1821413002 .
|
|
TBR=thestig@chromium.org
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1670843002 .
|
|
Review URL: https://codereview.chromium.org/1586043006 .
(cherry picked from commit 2cb9ae0309417222aa3555dabe4749119dc36d84)
R=ochang@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1582613012 .
|
|
These have gotten out of sync with master.
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1414943004 .
|
|
This pulls in the following CLs from master:
Review URL: https://codereview.chromium.org/1072613003
Review URL: https://codereview.chromium.org/1058463004
Review URL: https://codereview.chromium.org/1057983003
Review URL: https://codereview.chromium.org/1036073002
Review URL: https://codereview.chromium.org/1031203003
Review URL: https://codereview.chromium.org/1029193002
Review URL: https://codereview.chromium.org/1016613004
Review URL: https://codereview.chromium.org/1026903002
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1062163003
|