Age | Commit message (Collapse) | Author |
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1654523002 .
|
|
One more test before replacing the old sort() mechanism.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1650623004 .
|
|
Moved onto JS_ExpandKeywordParams(), and added a test which
showed the failure to pass all the data back to the embedder.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1645413002 .
|
|
I'm about to replace the sort() that underlies this class,
so I first want to be sure I don't disrupt the order.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1652533002 .
|
|
Centralize the "arguments in an object" logic. See the section
"Method Arguments" in the js_api_reference.pdf. Add some tests
to hit the ambiguous cases this section implies, and test that
all parameters are passed end-to-end to our callbacks.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1641693003 .
|
|
Fix the bugs by removing ParseNumber() entirely.
For PDFium's JavaScript bindings, we want to get out of the
numeric conversion business and inflict that on V8 as
possible, avoiding platform-specific issue in strtod().
For other uses, there is a FX_atof() which is similarly
buggy, but we can consolidate the use. Add an overloaded
FX_atof() to handle wide strings more simply.
BUG=pdfium:361
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1586203006 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1607923004 .
|
|
There are multiple functions in CPDF_Object class which can cause infinite loop due to recursively calling circular indirect objects. Fix them by deference indirect object first.
BUG=pdfium:355
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1585533002 .
|
|
We need more powerful tools for exclusion in light of
the XFA merge.
This stops short of integrating the matcher with the
pdfium_test --show-config option.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1586043006 .
|
|
BUG=pdfium:361
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1586983005 .
|
|
This reverts commit 4cd5b80e70e5fc50d8bd805cfa3c7b54878a0a35.
Reason for revert: broke tests on windows
TBR=tombergan@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1573243016 .
|
|
Original patch by tombergan.
The old version of this function was basically strtod with a few quirks:
1. It always interpreted ',' as '.' independent of locale. I kept this
behavior, to be conservative.
2. It interpreted the first non-number character as a decimal point,
unless there was a prior decimal point, in which case all characters
up to that point are ignored. This would parse "123z4" as "123.4"
and "123xy6" as "6". I did not keep this behavior -- in the new code,
these examples all fail to parse.
The new ParseNumber was inlined into ConvertStringToNumber, which
returns true on success and (false, 0) on failure.
BUG=pdfium:361
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1582013002 .
|
|
Although trailer's size value is required by spec, other readers such as
Acrobat or libpoppler can handle without it. Loose up the check to be
more tolerant.
BUG=pdfium:213
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1582193002 .
|
|
These cover some corner cases discussed from the CL at
https://codereview.chromium.org/1582013002/
R=thestig@chromium.org, tombergan@chromium.org
Review URL: https://codereview.chromium.org/1582383002 .
|
|
BUG=pdfium:360
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1585823003 .
|
|
R=thestig@chromium.org, tombergan@chromium.org
Review URL: https://codereview.chromium.org/1588733003 .
|
|
CPDF_SyntaxParser::GetObject() may enter into an infinite loop when a
signature dictionary doesn't have 'Contents' field. Add a check to
avoid that.
BUG=pdfium:344
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1575833004 .
|
|
BUG=pdfium:343
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1569343002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1561303002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1568763003 .
|
|
BUG=572871
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1564773003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1563513002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1554133003 .
|
|
BUG=pdfium:325
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1543043003 .
|
|
When cross reference sections form a loop, our code will enter an
infinite loop. Add detection and exit code for v4 cross reference loading.
V5 loading was done previously.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1558093002 .
|
|
Given the helper routines, use it in the find bookmark test
instead of just trusting another bookmarks title.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1554363002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1557173002 .
|
|
This reverts commit 054fc955c153eb5c581fd14946848b8b2a77136a.
Additionally, this rolls DEPS for the testing corpus to update test
expectations.
BUG=pdfium:336
TBR=jun_fang@foxitsoftware.com
Original Review URL: https://codereview.chromium.org/1555773003
Review URL: https://codereview.chromium.org/1555833002 .
|
|
This reverts commit 84f6a5616be0a1988d361a4b54eb83fff8b8c59f.
BUG=pdfium:336
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1554883002 .
|
|
BUG=pdfium:336
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1555773003 .
|
|
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1547833002 .
|
|
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1544493003 .
|
|
BUG=515137,564736
R=ochang@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1533233002 .
|
|
Also clean up while we're here.
BUG=557223
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1512833008 .
|
|
BUG=pdfium:298
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1496703005 .
|
|
Loosen a check for earlier version of PDF files. When the bytes with
specified length are followed by 'endstream' keyword, even if there is
no EOL marker before the keyword, it signals the end of stream.
BUG=551258
R=jun_fang@foxitsoftware.com, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1499433002 .
|
|
RebuildCrossRef function returns false when we can not find file trailer
or any indirect object. This serves as a basic file format checking.
BUG=pdfium:215
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1476163002 .
|
|
- add DrMemoryWrapper in common.py to adjust Dr. Memory wrapper
- add --wrapper option to run_*_tests.py for Dr. Mempry wrapper
- update run_*_tests.py to handle Dr. Memory wrapper
- add TestPDFiumTest in pdfium_tests.py to support run_*_tests.py
- remove ValgrindTool in valgrind_tests.py
R=thestig@chromium.org
BUG=pdfium:238
Review URL: https://codereview.chromium.org/1464453003 .
|
|
This matches the type of the corresponding |CFX_DIBSource::m_Pitch|,
where integer overflow is checked for FX_DWORD. This change is
propagated to many other places.
Also, check for integer overflow in |CCodec_RLScanlineDecoder::Create|
during the calculation of |m_Pitch| since it aligns to 4 bytes while
overflow was was previously checked without this alignment.
R=tsepez@chromium.org, thestig@chromium.org
BUG=555784
Review URL: https://codereview.chromium.org/1460033002 .
|
|
BUG=none
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1462313002 .
|
|
During decoding, when an image decoder is encountered, any
subsequent decoders are ignored, but remain in the array. However,
later on CPDF_DIBSource::ValidateDictParam expects the image
decoder to be the last in the array, causing issues.
A check is also added in CPDF_DIBSource::GetScanline to ensure
that the calculated pitch value is <= the (4-aligned) pitch value in the
cached bitmap to prevent future issues.
Also cleans up some NULL usages.
BUG=552046
R=jun_fang@foxitsoftware.com, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1406943005 .
|
|
CPDF_DIBSource::DownSampleScanline32Bit
Previously, if |m_bpc| was < 8 (e.g. 4), this function may still try to
access the source components as if |m_bpc| == 8. Even when it fell into
the codepath that tried to do the right thing in this case, it was
wrong.
BUG=554151
R=tsepez@chromium.org, thestig@chromium.org
Committed: https://pdfium.googlesource.com/pdfium/+/9b99615806e358fdb396d1cb162ee2e69c2a20ec
Review URL: https://codereview.chromium.org/1433423002 .
|
|
CPDF_DIBSource::DownSampleScanline32Bit"
This reverts commit 9b99615806e358fdb396d1cb162ee2e69c2a20ec.
Broke Windows build.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1437963003 .
|
|
Previously, if |m_bpc| was < 8 (e.g. 4), this function may still try to
access the source components as if |m_bpc| == 8. Even when it fell into
the codepath that tried to do the right thing in this case, it was
wrong.
BUG=554151
R=tsepez@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1433423002 .
|
|
run from any directory.
Previously the tests which read test files assume the current directory is under pdfium. Running from any other directory will break the build.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1408003014 .
|
|
Do some IWYU to fix build errors due to files that have no #includes but
just happened to work previously because the #includes were in the right
order.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1407423004 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1415803007 .
|
|
- In non-standalone builds, use the provided jpeg library.
- Run gn format over all the GN files.
- Also roll DEPS for buildtools to c2f2598.
BUG=541704
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1425153006 .
|
|
This tests whether RebuildCrossRef could handle well-formatted pdf file.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1409013005 .
|
|
Do not store raw wide string pointers.
BUG=551248
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1411043008 .
|