Age | Commit message (Collapse) | Author |
|
BUG=pdfium:1174
Change-Id: I4ade5c52f505690d14683cb094cc13c6fd9441f4
Reviewed-on: https://pdfium-review.googlesource.com/c/44173
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: I3f06ea7ed39c8a8fff57e07f14ff6c21bedbc028
Reviewed-on: https://pdfium-review.googlesource.com/c/43998
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
Move foo_embeddertest.cpp to the same BUILD.gn file as foo.cpp.
Set up dependencies to make pdfium_embeddertests pass gn check.
Change-Id: If1fe67c261960c35c344c1047950cd7fdb32c4a1
Reviewed-on: https://pdfium-review.googlesource.com/c/43997
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
Move foo_unittest.cpp to the same BUILD.gn file as foo.cpp.
Set up dependencies to make pdfium_unittests pass gn check.
Change-Id: Id9f649d5d0c76fe4254f3887778516abb75fcbce
Reviewed-on: https://pdfium-review.googlesource.com/c/43995
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
Bug: 895152
Change-Id: I678350841892f88a5d580b58a33a639a1b6ec305
Reviewed-on: https://pdfium-review.googlesource.com/c/44050
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
|
|
Change-Id: Ifb2d60bf3c2d86a105705196d65e318081cefe4e
Reviewed-on: https://pdfium-review.googlesource.com/c/43981
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Since BleedBox and TrimBox are supported according to PDF
specification, hence added setters and getters to get the
value if exists.
Bug:894655
Change-Id: I3c2600450f07665241a4724457a7cbc4282941ed
Reviewed-on: https://pdfium-review.googlesource.com/c/43977
Commit-Queue: Shirleen Lou <xlou@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
Still a long way to go, but hit the easy ones first.
Alphabetize property names in cjs_field.cpp file.
Change-Id: I1ede770a1e159d464287775cf9e19cbaf9f2a62f
Reviewed-on: https://pdfium-review.googlesource.com/c/43978
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
|
|
Also alphabetize mailDoc method position in .cpp file.
Change-Id: Ifb53e9a6f5f165bb41b865d51dae15e3bc84c4c7
Reviewed-on: https://pdfium-review.googlesource.com/c/43972
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
|
|
Change-Id: I8ef9bb333e786e833faca75566730a5b441d63c2
Reviewed-on: https://pdfium-review.googlesource.com/c/43830
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
|
|
Also move some implementations out of headers.
Change-Id: I321fc26970c440d874b135bd28e8bc8156b9afee
Reviewed-on: https://pdfium-review.googlesource.com/c/43890
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
core/fdrm/ currently only contains the crypto directory.
Change-Id: I68f4a38e7098f8a3bdc19764bc1ec78c28a386c9
Reviewed-on: https://pdfium-review.googlesource.com/c/43945
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: I3a100e1f009f18ee06959edf47d189d1bfdcb25a
Reviewed-on: https://pdfium-review.googlesource.com/c/43944
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
|
|
Return a more precise error in one case.
Change-Id: I21e4ef6b30be5f44d35922640643bffb9cb4b5e4
Reviewed-on: https://pdfium-review.googlesource.com/c/43950
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
|
|
Change-Id: Ie534b26d8241e889ad9cdca942e142cddca44bf4
Reviewed-on: https://pdfium-review.googlesource.com/c/43933
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
|
|
The test is suppressed because it currently renders incorrectly.
BUG=pdfium:632
Change-Id: Ie780e2128ef3a0bcf5f7d57b164ae38f03b1e9fd
Reviewed-on: https://pdfium-review.googlesource.com/c/43090
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
There are PDFs that use ArtBox. In some use cases, user may scale
a page, scale up/down MediaBox and CropBox. So if ArtBox exists,
it needs to be scaled as well.
Bug:409670
Change-Id: I78ac7afa66942352277f856514bdd9b15dda270b
Reviewed-on: https://pdfium-review.googlesource.com/c/43931
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Shirleen Lou <xlou@chromium.org>
|
|
Make fuzzer helpers that are mutually exclusive use the same name for
their global variables. If any target tries to include both, the jumbo
build will likely fail.
BUG=pdfium:964
Change-Id: Idadbc86ff990bf1e8c7cfb3500f1f191a96432db
Reviewed-on: https://pdfium-review.googlesource.com/c/43850
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
Commit 95860d7 added some new fuzzers, but they try to use both the
generic fuzzer's initialization code, as well as their own custom
initialization code.
Add a new "pdfium_public_fuzzer" GN template for these new fuzzers, so
they use their own initialization code rather than the generic one.
BUG=chromium:894053
TBR=tsepez@chromium.org
Change-Id: I6110a199e1c64d7c0632f9966e146fd316b757ae
Reviewed-on: https://pdfium-review.googlesource.com/c/43832
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Bug: pdfium:1127
Change-Id: I5371ecf6f704761320a021fbee07a79839fb80b7
Reviewed-on: https://pdfium-review.googlesource.com/c/43810
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
Change-Id: Ia4619be65e2ab8ee4bf19ba9608c1cc94594ba89
Reviewed-on: https://pdfium-review.googlesource.com/c/43812
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
|
|
Also increase timeout value when retrying.
Change-Id: I14dd3f76fd1a7555c3a5e1bd8c7bf8f214bc8ec0
Reviewed-on: https://pdfium-review.googlesource.com/c/43616
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: I2897feee27f80c85f0328f0b220ae5be93686170
Reviewed-on: https://pdfium-review.googlesource.com/c/43610
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
These came from Chromium's pdf/pdfium/fuzzer directory. The code has
been modified to be buildable in standalone PDFium and modernized.
Change-Id: Ia4ddad4a164f798689af4b9f92d41d635901dccb
Reviewed-on: https://pdfium-review.googlesource.com/c/43530
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: Ib96a66eb47bea791f061e1d6da8aadad8037a99d
Reviewed-on: https://pdfium-review.googlesource.com/c/43609
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
Otherwise code coverage flags the empty body as unreachable.
Change-Id: Iee1d9a876d68276529c70d9b8c7a28276f271767
Reviewed-on: https://pdfium-review.googlesource.com/c/43514
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
|
|
This is a reland of 9d784c291714b703b16185e69860a3797de85b6c
https://chromium-review.googlesource.com/c/chromium/src/+/1244367
was submitted changing the test that broke with this CL to not depend
on PDF OpenActions anymore.
Original change's description:
> Make potentially dangerous Actions require a user click.
>
> URI and SubmitForm actions are only handled if the event was
> ButtonUp or ButtonDown.
>
> Bug: 851821
> Change-Id: If6eb0ff44f6d62ac6df50b552c0bdc582885ab5d
> Reviewed-on: https://pdfium-review.googlesource.com/42731
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Bug: 851821
Change-Id: Iaf9c399059590f0f1a050ac450e08ee60a8d5a38
Reviewed-on: https://pdfium-review.googlesource.com/43410
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
|
|
Fix IWYU issues in affected files.
Change-Id: I92c145348549d2d0f0e066e134e649b3b958e068
Reviewed-on: https://pdfium-review.googlesource.com/c/43313
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
This path has only been present under XFA, and has resulted in
several bugs, including the referenced one. There is a breakage in some
XFA functionality, but I'm not confident we can do this without
re-engineering all of fpdfsdk widget ownership.
Bug: 891210
Change-Id: I5aa158fa5359b1c8338046eefb25fb25df9ace48
Reviewed-on: https://pdfium-review.googlesource.com/c/43311
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
|
|
Change-Id: I4a47a3d7c7a66de08217dc33d5f6f324e3e6a41c
Reviewed-on: https://pdfium-review.googlesource.com/43312
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
It occasionally times out on the bots.
Change-Id: Ie33d77c0e07f932c374c2ca670f982faeed29659
Reviewed-on: https://pdfium-review.googlesource.com/c/43310
Commit-Queue: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
|
|
BUG=chromium:890322
Change-Id: I11050b84cf440f8d6bb00c661360de4e389dc031
Reviewed-on: https://pdfium-review.googlesource.com/c/43290
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
This adds a test case where a simple red square BMP image is embedded
into an XFA document. This exercises that <image> tags work correctly
and that end to end rendering of BMPs is working.
Displaying BMPs is currently broken, https://crbug.com/pdfium/1168, so
this test is currently suppressed.
BUG=pdfium:1163
Change-Id: I3ef006a7aa16717ad9cdbca1d423613f17246a5e
Reviewed-on: https://pdfium-review.googlesource.com/43132
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
This adds a test case where a simple red square TIFF, using Deflate
compression, image is embedded into an XFA document. This exercises
that <image> tags work correctly and that end to end rendering of
Deflate TIFFs is working.
Change-Id: Ibe1b9f2a367ca3ceba6e08461f392e659459f7b8
Reviewed-on: https://pdfium-review.googlesource.com/43250
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
|
|
This adds a test case where a simple red square TIFF, using PackBits
compression, image is embedded into an XFA document. This exercises
that <image> tags work correctly and that end to end rendering of
PackBits TIFFs is working.
Change-Id: I01723a4ac8192b357b5a8480e7709ac6a0dce945
Reviewed-on: https://pdfium-review.googlesource.com/43270
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
|
|
This adds a test case where a simple red square TIFF, using LZW
compression, image is embedded into an XFA document. This exercises
that <image> tags work correctly and that end to end rendering of LZW
TIFFs is working.
Change-Id: Iecaef68e7eb4b1e822737f3faf4837699261e28b
Reviewed-on: https://pdfium-review.googlesource.com/43230
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
|
|
This adds a test case where a simple red square PNG image is embedded
into an XFA document. This exercises that <image> tags work correctly
and that end to end rendering of PNGs is working.
Change-Id: I8b04c5b0e85f7163e22dcf98593e6c88d5395ebb
Reviewed-on: https://pdfium-review.googlesource.com/43130
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
|
|
This adds a test case where a simple red square TIFF image is embedded
into an XFA document. This exercises that <image> tags work correctly
and that end to end rendering of TIFFs is working.
Change-Id: Ida61ed4bd49a58c432bde017832fa80187dc58d6
Reviewed-on: https://pdfium-review.googlesource.com/43134
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
|
|
This adds a test case where a simple red square JPG image is embedded
into an XFA document. This exercises that <image> tags work correctly
and that end to end rendering of JPGs is working.
Change-Id: Ife2f334c4c2a77a551d7c0b6f31c36f6cf42fcee
Reviewed-on: https://pdfium-review.googlesource.com/43133
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
This adds a test case where a simple red square GIF image is embedded
into an XFA document. This exercises that <image> tags work correctly
and that end to end rendering of GIFs is working.
Displaying GIFs is currently broken, https://crbug.com/pdfium/1167, so
this test is currently suppressed.
BUG=pdfium:904
Change-Id: I400a2a287c24726bc811dacfabe30ddc77f38b9c
Reviewed-on: https://pdfium-review.googlesource.com/43131
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
This reverts commit 9d784c291714b703b16185e69860a3797de85b6c.
Reason for revert: Roll into chromium is stuck, this is a potential
culprit.
Original change's description:
> Make potentially dangerous Actions require a user click.
>
> URI and SubmitForm actions are only handled if the event was
> ButtonUp or ButtonDown.
>
> Bug: 851821
> Change-Id: If6eb0ff44f6d62ac6df50b552c0bdc582885ab5d
> Reviewed-on: https://pdfium-review.googlesource.com/42731
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ryan Harrison <rharrison@chromium.org>
TBR=tsepez@chromium.org,hnakashima@chromium.org,rharrison@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 851821
Change-Id: I6f1bc0a02f65a24fbd49d53526b985f8a4ea0b4f
Reviewed-on: https://pdfium-review.googlesource.com/42990
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
URI and SubmitForm actions are only handled if the event was
ButtonUp or ButtonDown.
Bug: 851821
Change-Id: If6eb0ff44f6d62ac6df50b552c0bdc582885ab5d
Reviewed-on: https://pdfium-review.googlesource.com/42731
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
|
|
This CL addresses the published draft comment from
https://pdfium-review.googlesource.com/c/pdfium/+/5691/
Change-Id: I7a2cd9aa5dbdde18cadb82cbef70f0e8820cc276
Reviewed-on: https://pdfium-review.googlesource.com/42871
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
|
|
Classes marked |final| should not have |protected| members. In turn,
"private field m_dwEncryptObjNum is not used" warning is produced.
Change-Id: I51a96aca5a5f499381a6764d892962f7f2dc0327
Reviewed-on: https://pdfium-review.googlesource.com/42611
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
|
|
When parsing happens in several steps (in pages with > 100 page
objects), the position is reset to 0 and the start pointer is
advanced. This breaks the calculation of which stream an object
belongs to.
Passing in the base pointer separately from the start offset allows
the correct position to be calculated and the correct stream to be
identified.
Change-Id: Ic0d5f59f437609158aa97b3c8a18dbd48cd3b0d4
Reviewed-on: https://pdfium-review.googlesource.com/42270
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
Branches can be dirty when a library sync'ed with gclient sync is
removed from DEPS and from .gitignore. The library will be removed
by "gclient sync --force".
Change-Id: I19fa4a3f13989edb41cd671fd412cc67e67819eb
Reviewed-on: https://pdfium-review.googlesource.com/42211
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
This overwrites deps that are dirty, fixing an issue with deps that are
removed in the "after" branch but not in the "before" branch.
Change-Id: I1c905dc46522455ad160a6fd57fbab979c42162e
Reviewed-on: https://pdfium-review.googlesource.com/42191
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
This reverts commit aaff8f8b902ac3058b44b0f11a236df606082383.
Reason for revert: does not fix the problem, I'll fix in another way
Original change's description:
> Discard deps that are not sync'ed anymore in safetynet_compare.py.
>
> The job is currently blocked by the tools/gyp directory, which is being
> downloaded in the "before" branch, but is not ignored anymore in the
> "after" branch, making it an uncommited change.
>
> Change-Id: I9aca33e2046fbbe2626431febcbbdbebe1937f3b
> Reviewed-on: https://pdfium-review.googlesource.com/42110
> Reviewed-by: Ryan Harrison <rharrison@chromium.org>
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
TBR=thestig@chromium.org,hnakashima@chromium.org,rharrison@chromium.org
Change-Id: I840004d0d9c8d83340fdd0b4d701859cc628f9e6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://pdfium-review.googlesource.com/42190
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
The job is currently blocked by the tools/gyp directory, which is being
downloaded in the "before" branch, but is not ignored anymore in the
"after" branch, making it an uncommited change.
Change-Id: I9aca33e2046fbbe2626431febcbbdbebe1937f3b
Reviewed-on: https://pdfium-review.googlesource.com/42110
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
Bug: pdfium:1140
Change-Id: I306b7be5ea2732742e90e416f58c11bcaf8cbaf6
Reviewed-on: https://pdfium-review.googlesource.com/41770
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|