Age | Commit message (Collapse) | Author |
|
BUG=603895
Review-Url: https://codereview.chromium.org/1992893003
|
|
This removes the last vestiges of antigrain from
a Skia-specific build.
R=dsinclair@chromium.org,tsepez@chromium.org,thestig@chromium.org,reed@google.com
Review-Url: https://codereview.chromium.org/1998623002
|
|
Define and use chromium_code to be used in standalone PDFium GYP
build so that PDFium code can have more stringent warning level.
This is also enabled on GN build by default so that GYP and GN
builds can have consistent compilation results.
Also enable chromium_code for PDFium compilation in Chromium
since most of the warnings are cleared. The left ones are clearly
marked and will be addressed soon.
A few more clean-ups for the build:
-- Remove the suppression of sign-compare warnings for Clang since
the code is clean and the warning can be re-enabled.
-- Re-enable "treat warning as errors" on Mac
-- Add a flag to make GCC build works as well.
BUG=pdfium:29, pdfium:475
Review-Url: https://codereview.chromium.org/1985843002
|
|
ChromeOS still compile pdfium with GCC. Fix the code to be ready
to have workable GCC standalone build. The build file change will
be in a follow-up CL.
One warning is about maybe using uninitialized variable, the other is
about enum and non-enum in a conditional statement.
Review-Url: https://codereview.chromium.org/1981593002
|
|
Remove several obsolete warnings from GYP build;
Move disabled warning flags closer to the target instead of the
whole package for GYP build;
Use macro undefine instead of disabled warning for libtiff for GN
build.
Review-Url: https://codereview.chromium.org/1962863002
|
|
Chromium defines WIN32_LEAN_AND_MEAN on Windows. Third party library
libtiff also defines it. So we undefine it before compiling libtiff
code for GYP build.
Also, remove _CRT_SECURE_NO_WARNINGS macro since it is redefined in
zlib library as well. Our code no longer needs it.
After fixing the above, re-enable warning flag 4005 which alerts about
"macro redefinition".
For GN build, we disable warning 4005 for compiling libtiff
code before we can figure out another way to do this.
Review-Url: https://codereview.chromium.org/1954773002
|
|
https://codereview.chromium.org/1923333002/ )
Reason for revert:
Blocking the roll
Original issue's description:
> Allow overriding GN build flags
>
> In order to enable XFA from GN builds we need to be able to override
> pdf_enable_xfa. To do this a build_overrides/pdfium.gni file needs to be created
> in Chrome. To use that, we have to create a build_overrides/pdfium.gni file
> in PDFium that just uses the default values.
>
> BUG=chromium:62400
>
> Committed: https://pdfium.googlesource.com/pdfium/+/1ae572e7e35b52ce4897d1715c005a1b0f79526a
TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:62400
Review-Url: https://codereview.chromium.org/1941563002
|
|
In order to enable XFA from GN builds we need to be able to override
pdf_enable_xfa. To do this a build_overrides/pdfium.gni file needs to be created
in Chrome. To use that, we have to create a build_overrides/pdfium.gni file
in PDFium that just uses the default values.
BUG=chromium:62400
Review-Url: https://codereview.chromium.org/1923333002
|
|
This CL setups up a standalone GN build. You'll need to set gn args similar to:
use_goma = true
clang_use_chrome_plugins = false
pdf_enable_xfa = true
pdf_enable_v8 = true
pdf_is_standalone = true
The third_party/pymock files are needed to make git cl upload work correctly.
BUG=pdfium:106
Review URL: https://codereview.chromium.org/1904563002
|
|
BUG=pdfium:466
Review URL: https://codereview.chromium.org/1861963002
|
|
Fixes GN build after 47ca692.
R=tsepez@chromium.org,weili@chromium.org
Review URL: https://codereview.chromium.org/1862773002
|
|
Use FreeType instead of Direct Write on Windows. Since PDFium
currently uses the graphics engine to draw but not to measure,
the graphics engine needs to always use FreeType to get
consistent metrics.
Add a translation from PDF's blend modes to Skia's xfer modes.
Turn on subpixel positioning for text to get more precise
glyph placement.
Pass the alpha through to get proper bitmap transparency.
Address earlier nits.
R=dsinclair@chromium.org, tsepez@chromium.org, dsinclair
Review URL: https://codereview.chromium.org/1812263002 .
|
|
This file should not exist and causes issues with gclient.
|
|
This CL moves the fxcrt code into the core/fxcrt directory. The only exception
was fx_bidi.h which was moved into core/fxcrt as it is not used outside of
core/.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1825953002 .
|
|
BUG=pdfium:29
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1821423002 .
|
|
When building with clang-cl and not passing /FIintrin.h, the
__attribute__ defined to nothing, which confuses the compiler
(see bug).
Since nothing seems to require the __attribute__ redefinition,
just remove it.
Reported upstream here: https://github.com/uclouvain/openjpeg/issues/727
BUG=592745
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1810373002 .
|
|
This CL fixes up build issues with pdfium_use_skia=1 on windows.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1810063002 .
|
|
This Cl moves and splits apart the fx_graphics.h file into individual classes.
The .cpp files are renamed to match the .h files. pre.h was removed at the
same time and its contents moved to the correct places as needed.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1810563002 .
|
|
Enabling of XFA-Forms in crrev.com/1775173002 broke VS 2015 builds
because of a conflict between the lfind declaration in libtiff\tiffiop.h
and the one that ships with VS 2015. Defining HAVE_SEARCH_H for VS 2015
builds fixes this problem
BUG=440500,593996
R=thakis@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1781043005 .
|
|
Fixes 32-bit clang-cl build.
These intrinsics require addresses with 16-byte alignment, which doesn't
cause issues for 64-bit builds because of allocator alignment. MSVC
doesn't recognise the __SSE__, __SSE2__ defines, which is why this problem
never surfaced before.
R=tsepez@chromium.org
BUG=pdfium:433
Review URL: https://codereview.chromium.org/1783813003 .
|
|
Also move ScopedFileStream, since it isn't specific to the
parser, and belongs with the fxcrt object it manipulates.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1780063003 .
|
|
R=thakis@chromium.org, tsepez@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1774123005 .
|
|
Part of the work required to ship XFA with chrome.
BUG=pdfium:396
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1763493002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1740103002 .
|
|
These are in third_party libraries so should be fixed upstream. Silencing the
warning in our build.
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1734663002 .
|
|
This is a wrapper which does (a) * (b) / (c). Inline the operations.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1726893002 .
|
|
This is just a wrapper for (a) / (b). Inline the divide.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1727793002 .
|
|
R=tsepez@chromium.org
BUG=587227
Review URL: https://codereview.chromium.org/1726843002 .
|
|
This define just multiples the two parameters together. Inline the *'s.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1729613003 .
|
|
Fix IWYU in stl_util.h
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1672283002 .
|
|
R=tsepez@chromium.org
BUG=584223
Review URL: https://codereview.chromium.org/1672163002 .
|
|
Unfortunately, it is still used on the xfa/ side, so
exclude it only for non-xfa builds.
Original Review URL: https://codereview.chromium.org/1618273004 .
(cherry picked from commit c64e4007ee4561ec2ed3ce986191caf9b024ef55)
TBR=ochang@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1631863003 .
|
|
This is to avoid a compilation warning.
R=thakis@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1607053003 .
|
|
Otherwise this conflicts with Chromium's copy if the include paths just
happens to be in the wrong order. Since the two copies of libpng are of
different versions, we cannot use Chromium's copy.
TBR=tsepez@chromium.org,ochang@chromium.org
Review URL: https://codereview.chromium.org/1599513004 .
|
|
opj_pi_update_decode_poc().
R=tsepez@chromium.org
TBR=tsepez@chromium.org
BUG=571480
Original Review URL: https://codereview.chromium.org/1583233008 .
(cherry picked from commit 7a0f441e1410b3a0d97374c00c4007552d7dd27a)
Review URL: https://codereview.chromium.org/1594603004 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1591483003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1591563002 .
|
|
This was causing pdfium_diff to fail to link on ARM/linux
due to missing neon-specifc symbols. Ideally we could
add the missing symbols (and update the latest version
of libpng), but that can happen in a separate CL.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1585403003 .
|
|
functions.
TBR=thestig@chromium.org
BUG=571479
Original Review URL: https://codereview.chromium.org/1585243003 .
(cherry picked from commit 0b56371b1e9683676cf191f2d9d41d40d47c3726)
Review URL: https://codereview.chromium.org/1590593002 .
|
|
Otherwise there are errors like:
../../third_party/pdfium/third_party/libtiff/tif_jpeg.c:344
error: undefined reference to 'chromium_ijg_jpeg_read_header'
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1582613003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1572523002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567063003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1570443007 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1571523002 .
|
|
R=jun_fang@foxitsoftware.com, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1563103002 .
|
|
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1547833002 .
(cherry picked from commit d20dfba2ae10e8aeb328328f09da79ff904110a8)
Review URL: https://codereview.chromium.org/1545183002 .
|
|
BUG=pdfium:277
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1548583002 .
Review URL: https://codereview.chromium.org/1549873002 .
|
|
TBR=dml@google.com, thakis@chromium.org
Review URL: https://codereview.chromium.org/1544923002 .
Review URL: https://codereview.chromium.org/1545823002 .
(cherry picked from commit ba2586d2c0a50df14aa2549a0a841e1d4b9af4b6)
(cherry picked from commit 87f7d29531dabfd66e547a6be31a08272ff631d5)
Review URL: https://codereview.chromium.org/1542213002 .
|
|
appropriate.
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1540263003 .
(cherry picked from commit 1fc92867ca53f0fba4272fbee3814d844f487495)
Review URL: https://codereview.chromium.org/1542193002 .
|
|
BUG=514514
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1536223002 .
Merge branch 'xfa' of https://pdfium.googlesource.com/pdfium into xfa
Merge to XFA: Correct return values in CPDF_HintTables::CheckPage()
BUG=pdfium:329
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1529173005 .
Review URL: https://codereview.chromium.org/1539163002 .
|