Age | Commit message (Collapse) | Author |
|
Purely code removal.
Review-Url: https://codereview.chromium.org/1991143003
|
|
This CL splits the xfa/fee files into individual class files and moves them
into the xfa/fde directory where they belong.
Review-Url: https://codereview.chromium.org/1994693002
|
|
Define and use chromium_code to be used in standalone PDFium GYP
build so that PDFium code can have more stringent warning level.
This is also enabled on GN build by default so that GYP and GN
builds can have consistent compilation results.
Also enable chromium_code for PDFium compilation in Chromium
since most of the warnings are cleared. The left ones are clearly
marked and will be addressed soon.
A few more clean-ups for the build:
-- Remove the suppression of sign-compare warnings for Clang since
the code is clean and the warning can be re-enabled.
-- Re-enable "treat warning as errors" on Mac
-- Add a flag to make GCC build works as well.
BUG=pdfium:29, pdfium:475
Review-Url: https://codereview.chromium.org/1985843002
|
|
This CL removes:
* IFWL_AdapterNative
* IFWL_Adapter{Widget|Thread}Mgr
* IFWL_WidgetMgrDelegate
* CFWL_SDAdapter{Widget|Thread}Mgr
Methods which just returned have also been removed.
Review-Url: https://codereview.chromium.org/1928963004
|
|
This Cl updates the FWL_WGTHITTEST_ defines to an enum class and fixes up any
code issues.
Review-Url: https://codereview.chromium.org/1948583002
|
|
This CL removes the following and uses the only instance instead.
* IFDE_TxtEdtParag
* IFDE_TxtEdtEventSink
* IFDE_TxtEdtEngine
* IFDE_TxtEdtBuf
Review-Url: https://codereview.chromium.org/1927973003
|
|
This CL merges the IFWL_Target class into IFWL_Widget and IFWL_Thread into
IFWL_App. The IFWL_WidgetMgrDelegate, IFWL_NoteDriver and IFWL_NotThread are
removed in favour of their concrete classes.
Review-Url: https://codereview.chromium.org/1921853006
|
|
Remove IFX_FontProvider, IFX_FontSourceEnum, IFX_SAXReader and
IFX_SAXReaderHandler.
Review-Url: https://codereview.chromium.org/1930533002
|
|
Contents:
https://chromium.googlesource.com/v8/v8/+log/47bcec78..0ff89ea75
BUG=chromium:606547
Review URL: https://codereview.chromium.org/1920863003
|
|
This CL removes the CFWL_Note class. The two subclasses, CFWL_Event and
CFWL_Message are distinct types and should not be related by the subclass. The
code has been updated to pass the correct types as needed.
The various FWL_EVTHASH and FWL_MSGHASH defines have all been removed and turned
into an FWL_EventType and FWL_MessageType enum classes.
BUG=pdfium:474
Review URL: https://codereview.chromium.org/1901183002
|
|
This CL removes IFDE_TextOut, IFDE_Path, IFDE_RenderContext, IFDE_RenderDevice,
and IFDE_VisualSetIterator in favour of the concrete classes.
BUG=pdfium:468
Review URL: https://codereview.chromium.org/1896893003
|
|
This CL removes a series of unused XFA methods.
Review URL: https://codereview.chromium.org/1899103002
|
|
This code was used to subclass Form only, the one method in Panel is overridden
in Form.
Review URL: https://codereview.chromium.org/1899743002
|
|
The NoteThread classes only contained one member and don't provide any
added clarity. This CL moves the NoteDriver up to the Thread classes and
removes the NoteThread classes.
Review URL: https://codereview.chromium.org/1887703003
|
|
This Cl removes several FWL classes that aren't removed. These include:
* IFWL_Content
* CFWL_ContentImp
* CFWL_CustomPanelImp
* CFWL_CustomImp
* IFWL_Custom
* IFWL_CustomPanel
* IFWL_Proxy
* CFWL_App
BUG=pdfium:468
Review URL: https://codereview.chromium.org/1883943002
|
|
Remove unused or ifdef'd code from FWL.
Review URL: https://codereview.chromium.org/1874963002
|
|
These interfaces were not implemented, removed.
BUG=pdfium:468
Review URL: https://codereview.chromium.org/1866333003
|
|
This CL replaces IFX_Barcode with the concrete class.
BUG=pdfium:468
Review URL: https://codereview.chromium.org/1890443002
|
|
This Cl removes the two interfaces and renames CFDE_SolidBrush to CFDE_Brush.
Uncalled methods are removed from both CFDE_Brush and CFDE_Pen and code
simplified to match.
BUG=pdfium:468
Review URL: https://codereview.chromium.org/1881803003
|
|
We only ever create a CFDE_SolidBrush, there is nothing which creates Texture,
Hatch or LinearGradient brushes. This Cl removes all the code that isn't
used for SolidBrush.
A followup Cl will rename SolidBrush to Brush and remove the Brush interface
in favour of the concrete class.
BUG=pdfium:468
Review URL: https://codereview.chromium.org/1877383002
|
|
This CL moves the remaining files in xfa/include/fxfa to xfa/fxfa/include.
Review URL: https://codereview.chromium.org/1864973005
|
|
The IFWL_Grid class wasn't an interface, it was a concrete class. Even as a
concrete class it was never instantiated. The various other CFWL_Grid* class
were also not instantiated.
BUG=pdfium:468
Review URL: https://codereview.chromium.org/1862243002
|
|
This Cl splits apart the fxfa_objectacc.h file and moves the individual classes
into the xfa/fxfa/parser directory.
Review URL: https://codereview.chromium.org/1861353002
|
|
This CL removes the proxy methods from CXFA_FFWidgetHandler and CXFA_DocHandler
and removes CXFA_FFMenuHandler as it was only proxy methods.
The calls are made directly on the object now.
Review URL: https://codereview.chromium.org/1857893002
|
|
The gyp build on Windows detected
a few typos in recent edits.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1855173003
|
|
This CL removes the IXFA_* interfaces which are:
- Implemented once.
- Not implemented by an fpdfsdk class.
This requires making a few classes visible to fpdfsdk so we can have the
correct instances available instead of the IXFA types.
Review URL: https://codereview.chromium.org/1846993002
|
|
This CL moves and splits the remaining FWL files out of xfa/include and into
their proper locations.
Review URL: https://codereview.chromium.org/1834323003
|
|
These are found by the Windows version of GYP. Not sure how to turn the
warnings on for other platforms.
R=caryclark@google.com
Review URL: https://codereview.chromium.org/1830913003 .
|
|
This CL moves and splits the FWL files from the core and basewidget directories
into the non-include folders.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1827923002 .
|
|
This CL splits apart the larger header into individual class headers in the
xfa/fxbarcode directory.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1816133002 .
|
|
This Cl moves and splits apart the fx_graphics.h file into individual classes.
The .cpp files are renamed to match the .h files. pre.h was removed at the
same time and its contents moved to the correct places as needed.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1810563002 .
|
|
This CL moves the fxjse.h header and splits the cfxjse_arguments.h into its
own file.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1807623002 .
|
|
Re-enable the warning by naming the unnamed structs. Also clean up
fx_graphics files.
BUG=pdfium:29
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1784323006 .
|
|
This CL moves the xfa/src files up to the xfa/ directory and fixes the includes,
include guards, and build files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1803723002 .
|
|
This CL renames xfa/src/fdp to xfa/src/fde to better match all of the content
(nothing mentions fdp other then the directory name). The inner src/ and
include/ folders are collapsed up a level and xfa/src/fdp/src/fde is moved
up to xfa/src/fde.
Some of the header moves conflicted with existing headers. In that case, the
existing header had the content moved into the .cpp file and we replaced the
existing header with the one from include/.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1784543002 .
|
|
This CL moves the code from xfa/src/fgas/src up one level. It then takes the
headers in xfa/src/fgas/include and moves them to their correct folder. The
src/ and include/ directories are then removed.
In some cases, when moving from include/ there was another header with the
same name. Those headers were either folded together, or the content of the
conflicting folder moved to an anonymous namespace in the cpp file as they were
not used anywhere else.
Files with duplicate names as core/src/crt were renamed to be fgas_ instead of
fx_. (e.g. fgas_system.h, fgas_memory.h, fgas_stream.h)
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1776303002 .
|
|
This CL moves xfa/src/fee/src/fee up to xfa/src/fee and moves the
xfa/src/fee/include files up to xfa/src/fee.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1778633003 .
|
|
This Cl moves the xfa/src/fxgraphics/src code up to the, previously empty,
xfa/src/fxgraphics directory and removes xfa/src/fxgraphics/src.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1775733004 .
|
|
This CL removes the xfa/src/fxjse/src and moves all of the .h and .cpp files
up to the, previously empty, xfa/src/fxjse directory.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1776643002 .
|
|
This Cl moves the code in xfa/src/fxfa/src/common to the diretory which
contains the respective implementations and removes the xfa/src/fxfa/src/common
directory. It them moves all of the code in xfa/src/fxfa/src up one level and
removes the xfa/src/fxfa/src
directory.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1770073003 .
|
|
This Cl moves the xfa/src/fwl/src code up to the previously empty parent
directory and removes xfa/src/fwl/src.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1770953004 .
|
|
This CL collapses the xfa/src/fwl/src/core/include and
xfa/src/fwl/src/basewidget/include up one level.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1770273002 .
|
|
warning C4201: nonstandard extension used : nameless struct/union
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1767263002 .
|
|
Remove deprecated declarations
BUG=pdfium:356
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1769833002 .
|
|
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1766043002 .
|
|
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1768693002 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1770473002 .
|
|
See https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/178070/steps/compile%20%28with%20patch%29/logs/stdio
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1770453002 .
|
|
Temporary measure until FX fixes these (or I do).
This is blocking rolling XFA into chrome.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1764503003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1745023003 .
|