Age | Commit message (Collapse) | Author |
|
The core/ directory in FWL no-longer provides any context. This Cl moves all
of the core/ files up to the fwl/ folder.
As well, the CFWL_EvtFoo files are renamed CFWL_EventFoo and the CFWL_MsgFoo
files are renamed CFWL_MessageFoo. The event and message preceed the type in
order to keep the files sorted together and to make it clear that they're all
related.
Review-Url: https://codereview.chromium.org/2559173002
|
|
Current GetWidgetRect accepts the rect as an out-param. This CL converts the
code to return the rect instead.
Review-Url: https://codereview.chromium.org/2556873004
|
|
This CL cleans up the remaining default values in the fwl/core directory. Some
methods are renamed to better represent what they do.
Review-Url: https://codereview.chromium.org/2557103002
|
|
This Cl removes some of the default FWL parameters.
Review-Url: https://codereview.chromium.org/2533623002
|
|
This CL removes any CFWL_Evt classes for which nothing was listening to the
events. For events with no parameters the override class was removed and
the event type passed into CFWL_Event which is used instead. Any event or
message parameters which are un-read have been removed.
Review-Url: https://codereview.chromium.org/2530993002
|
|
This Cl updates the TxtEdtEngine and TxtEdtBuf to return CFX_WideStrings on
a Get instead of taking an out param. The change is propagated out through
the various Get methods that call into the edit engine.
Change-Id: Iccf10a8ee06678ae3b59f3afd6e65308dacd16bd
Reviewed-on: https://pdfium-review.googlesource.com/2070
Commit-Queue: ooo 11-24 -- 12-05 (dsinclair) <dsinclair@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
|
|
Review-Url: https://codereview.chromium.org/2527783004
|
|
This CL merges the IFWL hierarchy into the CFWL hierachy. All CFWL proxy methods
have been replaced by the IFWL implementations.
Review-Url: https://codereview.chromium.org/2524173002
|
|
This CL removes the generic DataProvider code from CFWL_WidgetProperties and
adds the specific providers to the two classes that require them.
Review-Url: https://codereview.chromium.org/2527683002
|
|
This CL removes the IFWL_ListBox::DataProvider and builds the data storage
for the list directly into IFWL_ListBox. This removes the need for the provider
in CFWL_ComboBox and CFWL_ListBox.
Change-Id: I74c2286757a0b73083908f1cc630a88e7d730fd9
Reviewed-on: https://pdfium-review.googlesource.com/2050
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
This class is not an interface but a concrete implementation. Rename to match.
Review-Url: https://codereview.chromium.org/2521303002
|
|
This CL renames some methods in IFWL which have the same name as the CFWL
methods but the CFWL methods are not proxy methods.
Review-Url: https://codereview.chromium.org/2520413002
|
|
This method mostly returns L"". In the one case where it returns
something different the value is substituted into the callsite.
The IFWL_Tooltip class was using the caption, but it is not currently
being used. Removed as well.
Review-Url: https://codereview.chromium.org/2522663002
|
|
Split classes in FWL to be single class per file. In the case of data providers
which added no new methods, removed and used the IFWL_DataProvider directly.
Review-Url: https://codereview.chromium.org/2506253004
|
|
This Cl cleans up the visibility, method usage and return values in the
remaining CFWL files.
Review-Url: https://codereview.chromium.org/2498163002
|
|
Cleanup visibility and unused methods in the IFWL combo code.
Review-Url: https://codereview.chromium.org/2494743002
|
|
Remove usunsed methods and FWL_Error returns.
Review-Url: https://codereview.chromium.org/2488963005
|
|
This CL removes a few methods from IFWL that are around just to proxy from
CFWL methods which are, in turn, never called.
Review-Url: https://codereview.chromium.org/2486333004
|
|
Cleaning up more IFWL classes.
Review-Url: https://codereview.chromium.org/2492563002
|
|
This CL removes the empty IFWL_ListItem class and uses CFWL_ListItem in its
place. As well, the CFWL_ComboListItem is removed and replaced with
CFWL_ListItem. These were almost duplicate classes and the one missing field
added to CFWL_ListItem.
Review-Url: https://codereview.chromium.org/2487943003
|
|
This CL removes the data provider classes and folds the code into the parent
classes.
Review-Url: https://codereview.chromium.org/2480233003
|
|
Review-Url: https://codereview.chromium.org/2467203003
|
|
This Cl removes the various CFWL_*::GetWidget overrides and adds anonymous
To* methods as needed.
Review-Url: https://codereview.chromium.org/2467503003
|
|
This parameter is always nullptr, removed.
Review-Url: https://codereview.chromium.org/2463073002
|
|
This CL removes the FWL_GetApp, FWL_SetApp and FWL_GetWidgetAdapter methods.
In the process it changes the various Initialize methods to return void.
Review-Url: https://codereview.chromium.org/2436103002
|
|
This CL moves the code from fwl/lightwidget into fwl/core. In anticipation of
merging the two hierarchies.
Review-Url: https://chromiumcodereview.appspot.com/2430923006
|