Age | Commit message (Collapse) | Author |
|
This CL merges the IFWL_Target class into IFWL_Widget and IFWL_Thread into
IFWL_App. The IFWL_WidgetMgrDelegate, IFWL_NoteDriver and IFWL_NotThread are
removed in favour of their concrete classes.
Review-Url: https://codereview.chromium.org/1921853006
|
|
Review-Url: https://codereview.chromium.org/1924093003
|
|
Ideally, these will become std::vector<>, but in the mean time
this is quicker and allow us to remove casts. Doing so has already
turned up one place where the wrong type of object was being used.
Review-Url: https://codereview.chromium.org/1924073002
|
|
There are currently three ways to assert in the code (ASSERT, FXSYS_assert and
assert). This CL standardizes on ASSERT. The benefit of ASSERT is that it can
be overridden if the platform requies and we can pickup the Chromium version
if it has already been defined in the build.
This does change behaviour. Currently FXSYS_assert is always defined but ASSERT
is only defined in debug builds. So, the FXSYS_assert's would fire in Release
builds. That will no longer happen.
BUG=pdfium:219
Review-Url: https://codereview.chromium.org/1914303003
|
|
This CL folds IFX_SystemHandler into CFX_SystemHandler. Methods which either
had no implementation, or returned a default value have been removed.
Review URL: https://codereview.chromium.org/1923093002
|
|
Missing default statement in the switch. Duplicated the method signature
on both sides of the #ifdef to make it clearer what was going on.
Review URL: https://codereview.chromium.org/1905303003
|
|
This CL removes the CFWL_Note class. The two subclasses, CFWL_Event and
CFWL_Message are distinct types and should not be related by the subclass. The
code has been updated to pass the correct types as needed.
The various FWL_EVTHASH and FWL_MSGHASH defines have all been removed and turned
into an FWL_EventType and FWL_MessageType enum classes.
BUG=pdfium:474
Review URL: https://codereview.chromium.org/1901183002
|
|
No usages, removed.
Review URL: https://codereview.chromium.org/1903993003
|
|
This CL converts FWL_WGTCAPACITY_* defines to the CFWL_WidgetCapacity enum
class. The FWL_PART_* defines to the FWL_Part enum class and the
FWL_PartState_* defines to an enum.
Review URL: https://codereview.chromium.org/1898713003
|
|
The FWL_SetFullScreen() method is never called, remove and all the supporting
fullscreen code.
Review URL: https://codereview.chromium.org/1902083002
|
|
This CL changes the FWL_CornerEnlarge define into a const value in the
anonymous namespace.
Review URL: https://codereview.chromium.org/1896923002
|
|
This code was used to subclass Form only, the one method in Panel is overridden
in Form.
Review URL: https://codereview.chromium.org/1899743002
|
|
The NoteThread classes only contained one member and don't provide any
added clarity. This CL moves the NoteDriver up to the Thread classes and
removes the NoteThread classes.
Review URL: https://codereview.chromium.org/1887703003
|
|
Use the more standard name "clear()" instead.
Review URL: https://codereview.chromium.org/1888103002
|
|
This Cl removes several FWL classes that aren't removed. These include:
* IFWL_Content
* CFWL_ContentImp
* CFWL_CustomPanelImp
* CFWL_CustomImp
* IFWL_Custom
* IFWL_CustomPanel
* IFWL_Proxy
* CFWL_App
BUG=pdfium:468
Review URL: https://codereview.chromium.org/1883943002
|
|
This CL removes various methods from FWL that are not called.
Review URL: https://codereview.chromium.org/1886703005
|
|
Remove unused or ifdef'd code from FWL.
Review URL: https://codereview.chromium.org/1874963002
|
|
Review URL: https://codereview.chromium.org/1878293002
|
|
The naming is redundant given the base type, and will stand
in the way of consolidating Byte and Wide code.
BUG=
Review URL: https://codereview.chromium.org/1862123003
|
|
The IFWL_Grid class wasn't an interface, it was a concrete class. Even as a
concrete class it was never instantiated. The various other CFWL_Grid* class
were also not instantiated.
BUG=pdfium:468
Review URL: https://codereview.chromium.org/1862243002
|
|
This CL is a straight move of the fxge includes into core/fxge/include.
Review URL: https://codereview.chromium.org/1868533002
|
|
Companion to https://codereview.chromium.org/1853233002
BUG=
Review URL: https://codereview.chromium.org/1857073002
|
|
This CL moves and splits the remaining FWL files out of xfa/include and into
their proper locations.
Review URL: https://codereview.chromium.org/1834323003
|
|
Some headers were missed in the previous CL.
Review URL: https://codereview.chromium.org/1835703002
|
|
Review URL: https://codereview.chromium.org/1830323006
|
|
This CL removes _FPDFAPI_GetInternalFontData which is not implemented,
FWL_PostMessageToMainRoop which has no body and the PostMessage which was
the only caller.
FWL_ShowCaret is moved to the only place where it's used.
BUG=pdfium:112
Review URL: https://codereview.chromium.org/1827343003
|
|
This CL moves and splits the FWL files from the core and basewidget directories
into the non-include folders.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1827923002 .
|
|
This CL moves the fxcrt code into the core/fxcrt directory. The only exception
was fx_bidi.h which was moved into core/fxcrt as it is not used outside of
core/.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1825953002 .
|
|
This Cl moves and splits apart the fx_graphics.h file into individual classes.
The .cpp files are renamed to match the .h files. pre.h was removed at the
same time and its contents moved to the correct places as needed.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1810563002 .
|
|
This CL moves the xfa/src files up to the xfa/ directory and fixes the includes,
include guards, and build files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1803723002 .
|