Age | Commit message (Collapse) | Author |
|
This CL splits the cursor code into specific show/hide methods to make it
clearer what is happening at each point.
Review-Url: https://codereview.chromium.org/2535623002
|
|
This CL removes any CFWL_Evt classes for which nothing was listening to the
events. For events with no parameters the override class was removed and
the event type passed into CFWL_Event which is used instead. Any event or
message parameters which are un-read have been removed.
Review-Url: https://codereview.chromium.org/2530993002
|
|
This Cl updates the TxtEdtEngine and TxtEdtBuf to return CFX_WideStrings on
a Get instead of taking an out param. The change is propagated out through
the various Get methods that call into the edit engine.
Change-Id: Iccf10a8ee06678ae3b59f3afd6e65308dacd16bd
Reviewed-on: https://pdfium-review.googlesource.com/2070
Commit-Queue: ooo 11-24 -- 12-05 (dsinclair) <dsinclair@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
|
|
Review-Url: https://codereview.chromium.org/2527783004
|
|
This CL merges the IFWL hierarchy into the CFWL hierachy. All CFWL proxy methods
have been replaced by the IFWL implementations.
Review-Url: https://codereview.chromium.org/2524173002
|
|
This CL moves the IFWL classes that do not have CFWL class buddies to have the
CFWL name. This CL leaves the tree in a weird state of having CFWL be two
hierarchies, one of which is intertwined with the IFWL hierarchy. This should
be commited just before the CL to move the rest of IFWL to CFWL.
Review-Url: https://codereview.chromium.org/2525083002
|
|
This CL removes the generic DataProvider code from CFWL_WidgetProperties and
adds the specific providers to the two classes that require them.
Review-Url: https://codereview.chromium.org/2527683002
|
|
The height value returned is always 0. This CL removes the plumbing and uses
the 0 value directly.
R=npm@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/2525003002 .
|
|
This CL removes the IFWL_ListBox::DataProvider and builds the data storage
for the list directly into IFWL_ListBox. This removes the need for the provider
in CFWL_ComboBox and CFWL_ListBox.
Change-Id: I74c2286757a0b73083908f1cc630a88e7d730fd9
Reviewed-on: https://pdfium-review.googlesource.com/2050
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
The calendar always sets today to 2011/01/01. This Cl removes the various
DataProviders needed to plumb this value and just sets it where needed.
Review-Url: https://codereview.chromium.org/2524993002
|
|
These methods should be in all implementations, make them pure virtual to
make that required.
Review-Url: https://codereview.chromium.org/2525703004
|
|
This class is not an interface but a concrete implementation. Rename to match.
Review-Url: https://codereview.chromium.org/2521303002
|
|
These twho files are not interfaces. Renamed to be CFWL to signify they are
concrete implementations.
Review-Url: https://codereview.chromium.org/2526513002
|
|
This CL renames some methods in IFWL which have the same name as the CFWL
methods but the CFWL methods are not proxy methods.
Review-Url: https://codereview.chromium.org/2520413002
|
|
This method mostly returns L"". In the one case where it returns
something different the value is substituted into the callsite.
The IFWL_Tooltip class was using the caption, but it is not currently
being used. Removed as well.
Review-Url: https://codereview.chromium.org/2522663002
|
|
The only value being set from the enum was the All Mask. This was always set
through the default value in the methods. This Cl removes the mask code completely
and updates surrounding code as needed.
Review-Url: https://codereview.chromium.org/2515243003
|
|
Split classes in FWL to be single class per file. In the case of data providers
which added no new methods, removed and used the IFWL_Widget::DataProvider
directly.
Review-Url: https://codereview.chromium.org/2520063002
|
|
Removed some unused method, named files properly, cleaned up a bit.
Review-Url: https://codereview.chromium.org/2524493002
|
|
The Customized Layout flag in FWL is always false. Removed the flag and updated
the code as needed.
Review-Url: https://codereview.chromium.org/2520023002
|
|
The SetThemeColor and SetThemeData methods are always called with a parameter
of 0. This Cl removes the parameter and updates the code as needed.
Review-Url: https://codereview.chromium.org/2521683002
|
|
The FWL_GetThemeColor method is always called with 0 which will return 0. This
CL removes the calls and replaces the callsites with 0 as needed.
Review-Url: https://codereview.chromium.org/2523453002
|
|
FWL_GetThemeLayout is only called in one place with 0 as the parameter. This
can never be true, so replace it with false at the callsite.
Review-Url: https://codereview.chromium.org/2521673002
|
|
The theme ID is never set, so it's always 0. This CL removes the Set/Get methods
and updates the code to use 0 in place of m_dwThemeId.
Review-Url: https://codereview.chromium.org/2519113002
|
|
The -build/include setting was masking out build/include_what_you_use. This CL
restores them, fixes any build errors, and adds NOLINT as needed. As well,
the runtime/explicit and runtime/printf flags are aslo enabled and NOLINT'd.
lint cleanups
Change-Id: Ib013b3eb29c8d0e48cad74c5df9028684130719f
Reviewed-on: https://pdfium-review.googlesource.com/2030
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
Split classes in FWL to be single class per file. In the case of data providers
which added no new methods, removed and used the IFWL_DataProvider directly.
Review-Url: https://codereview.chromium.org/2506253004
|
|
The FWL_WGTSTYLE_Icon flag is never set. This CL removes it and the supporting
Icon code from IFWL_Form.
Review-Url: https://codereview.chromium.org/2516433003
|
|
This CL removes the flag which never appears to be set and the supporting code
for captions in IFWL_Form as they are never used.
Review-Url: https://codereview.chromium.org/2507283003
|
|
This flag does not appear to be applied to the styles, so the supporting code
will never be executed.
Review-Url: https://codereview.chromium.org/2502233005
|
|
The m_InfoStart variable has values set but never read. Removed.
Review-Url: https://codereview.chromium.org/2513673002
|
|
The m_eResizeType variable is set but never read. Removed.
Review-Url: https://codereview.chromium.org/2508263002
|
|
There are no longer any classes which implement this interface.
Remove interface.
Review-Url: https://codereview.chromium.org/2511183002
|
|
No longer used.
Review-Url: https://codereview.chromium.org/2506153003
|
|
This CL removes the ListBox SelectChange class as it is never processed. The
other two have been unified into a single classs.
Review-Url: https://codereview.chromium.org/2509283003
|
|
This CL creates a generic event for CFWL_EventType::EditChanged and uses it
in the ComboBox and DateTimePicker. None of the params from the custom events
were used so they have been removed.
Review-Url: https://codereview.chromium.org/2511813002
|
|
The ListBox DrawItems event is caught by the ComboBox which converts the
event into a ComboBox DrawItems event which is never processed. Removed both.
Review-Url: https://codereview.chromium.org/2510123002
|
|
The m_bUp flag of CFWL_EvtSpbClick is never used after being set. Remove the
flag and replace CFWL_EvtSpbClick with CFWL_EvtClick.
Review-Url: https://codereview.chromium.org/2511803002
|
|
This moves the remaining EventType class definitions to there own files where
the EventType only has a single implementation.
Review-Url: https://codereview.chromium.org/2508203002
|
|
The DropDown, HoverChanged and CloseUp events are created and thrown but
are not caught for processing anywhere. Removed.
Review-Url: https://codereview.chromium.org/2509733006
|
|
This Cl moves the edit events to actual class files and renames to drop the
Edt from the names.
Review-Url: https://codereview.chromium.org/2515463002
|
|
Nothing listens for CFWL_Event::PreSelfAdaption events and nothing sets the
HSelfAdaption or VSelfAdaption flags into IFWL_Edit. Removing code.
Review-Url: https://codereview.chromium.org/2514443002
|
|
This CL splits the common event classes out to individual files instead of
being created by the macro.
The other classes will be split out in subsequent CLs.
Review-Url: https://codereview.chromium.org/2507713003
|
|
CFWL_Event has no Retain method, just a Release method. So, it's essentially
just a delete call whenever used. This CL removes the Release method and turns
the one usage into a unique_ptr.
Review-Url: https://codereview.chromium.org/2509863002
|
|
Currently the CFWL messages are created by a macro in the CFWL_Message header
file. This Cl splits out the class to their own files and writes them directly
instead of using the macro.
Review-Url: https://codereview.chromium.org/2510823003
|
|
Review-Url: https://codereview.chromium.org/2510793003
|
|
Review-Url: https://codereview.chromium.org/2506083002
|
|
Review-Url: https://codereview.chromium.org/2501033005
|
|
Review-Url: https://codereview.chromium.org/2506493003
|
|
This Cl cleans up the nits in the first set of cfwl_* files. The unused Event
and Message classes are removed.
Review-Url: https://codereview.chromium.org/2505703003
|
|
This Cl cleans up the visibility, method usage and return values in the
remaining CFWL files.
Review-Url: https://codereview.chromium.org/2498163002
|
|
First pass at cleaning up visibility, return values and const'ness of
cfwl_* class.
Review-Url: https://codereview.chromium.org/2501743002
|