Age | Commit message (Collapse) | Author |
|
The only value being set from the enum was the All Mask. This was always set
through the default value in the methods. This Cl removes the mask code completely
and updates surrounding code as needed.
Review-Url: https://codereview.chromium.org/2515243003
|
|
Split classes in FWL to be single class per file. In the case of data providers
which added no new methods, removed and used the IFWL_Widget::DataProvider
directly.
Review-Url: https://codereview.chromium.org/2520063002
|
|
Removed some unused method, named files properly, cleaned up a bit.
Review-Url: https://codereview.chromium.org/2524493002
|
|
The Customized Layout flag in FWL is always false. Removed the flag and updated
the code as needed.
Review-Url: https://codereview.chromium.org/2520023002
|
|
The SetThemeColor and SetThemeData methods are always called with a parameter
of 0. This Cl removes the parameter and updates the code as needed.
Review-Url: https://codereview.chromium.org/2521683002
|
|
The FWL_GetThemeColor method is always called with 0 which will return 0. This
CL removes the calls and replaces the callsites with 0 as needed.
Review-Url: https://codereview.chromium.org/2523453002
|
|
FWL_GetThemeLayout is only called in one place with 0 as the parameter. This
can never be true, so replace it with false at the callsite.
Review-Url: https://codereview.chromium.org/2521673002
|
|
The theme ID is never set, so it's always 0. This CL removes the Set/Get methods
and updates the code to use 0 in place of m_dwThemeId.
Review-Url: https://codereview.chromium.org/2519113002
|
|
The -build/include setting was masking out build/include_what_you_use. This CL
restores them, fixes any build errors, and adds NOLINT as needed. As well,
the runtime/explicit and runtime/printf flags are aslo enabled and NOLINT'd.
lint cleanups
Change-Id: Ib013b3eb29c8d0e48cad74c5df9028684130719f
Reviewed-on: https://pdfium-review.googlesource.com/2030
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
Split classes in FWL to be single class per file. In the case of data providers
which added no new methods, removed and used the IFWL_DataProvider directly.
Review-Url: https://codereview.chromium.org/2506253004
|
|
The FWL_WGTSTYLE_Icon flag is never set. This CL removes it and the supporting
Icon code from IFWL_Form.
Review-Url: https://codereview.chromium.org/2516433003
|
|
This CL removes the flag which never appears to be set and the supporting code
for captions in IFWL_Form as they are never used.
Review-Url: https://codereview.chromium.org/2507283003
|
|
This flag does not appear to be applied to the styles, so the supporting code
will never be executed.
Review-Url: https://codereview.chromium.org/2502233005
|
|
The m_InfoStart variable has values set but never read. Removed.
Review-Url: https://codereview.chromium.org/2513673002
|
|
The m_eResizeType variable is set but never read. Removed.
Review-Url: https://codereview.chromium.org/2508263002
|
|
There are no longer any classes which implement this interface.
Remove interface.
Review-Url: https://codereview.chromium.org/2511183002
|
|
No longer used.
Review-Url: https://codereview.chromium.org/2506153003
|
|
This CL removes the ListBox SelectChange class as it is never processed. The
other two have been unified into a single classs.
Review-Url: https://codereview.chromium.org/2509283003
|
|
This CL creates a generic event for CFWL_EventType::EditChanged and uses it
in the ComboBox and DateTimePicker. None of the params from the custom events
were used so they have been removed.
Review-Url: https://codereview.chromium.org/2511813002
|
|
The ListBox DrawItems event is caught by the ComboBox which converts the
event into a ComboBox DrawItems event which is never processed. Removed both.
Review-Url: https://codereview.chromium.org/2510123002
|
|
The m_bUp flag of CFWL_EvtSpbClick is never used after being set. Remove the
flag and replace CFWL_EvtSpbClick with CFWL_EvtClick.
Review-Url: https://codereview.chromium.org/2511803002
|
|
This moves the remaining EventType class definitions to there own files where
the EventType only has a single implementation.
Review-Url: https://codereview.chromium.org/2508203002
|
|
The DropDown, HoverChanged and CloseUp events are created and thrown but
are not caught for processing anywhere. Removed.
Review-Url: https://codereview.chromium.org/2509733006
|
|
This Cl moves the edit events to actual class files and renames to drop the
Edt from the names.
Review-Url: https://codereview.chromium.org/2515463002
|
|
Nothing listens for CFWL_Event::PreSelfAdaption events and nothing sets the
HSelfAdaption or VSelfAdaption flags into IFWL_Edit. Removing code.
Review-Url: https://codereview.chromium.org/2514443002
|
|
This CL splits the common event classes out to individual files instead of
being created by the macro.
The other classes will be split out in subsequent CLs.
Review-Url: https://codereview.chromium.org/2507713003
|
|
CFWL_Event has no Retain method, just a Release method. So, it's essentially
just a delete call whenever used. This CL removes the Release method and turns
the one usage into a unique_ptr.
Review-Url: https://codereview.chromium.org/2509863002
|
|
Currently the CFWL messages are created by a macro in the CFWL_Message header
file. This Cl splits out the class to their own files and writes them directly
instead of using the macro.
Review-Url: https://codereview.chromium.org/2510823003
|
|
Review-Url: https://codereview.chromium.org/2510793003
|
|
Review-Url: https://codereview.chromium.org/2506083002
|
|
Review-Url: https://codereview.chromium.org/2501033005
|
|
Review-Url: https://codereview.chromium.org/2506493003
|
|
This Cl cleans up the nits in the first set of cfwl_* files. The unused Event
and Message classes are removed.
Review-Url: https://codereview.chromium.org/2505703003
|
|
This Cl cleans up the visibility, method usage and return values in the
remaining CFWL files.
Review-Url: https://codereview.chromium.org/2498163002
|
|
First pass at cleaning up visibility, return values and const'ness of
cfwl_* class.
Review-Url: https://codereview.chromium.org/2501743002
|
|
This CL cleans up the classes in the fwl_* and cfx_* files in fwl/core.
Review-Url: https://codereview.chromium.org/2503513002
|
|
This CL cleans up the remaining ifwl_* files to fixup visibility, remove
unused methods and remove unused FWL_Error return codes.
Review-Url: https://codereview.chromium.org/2502653002
|
|
Cleanup visibility and unused methods in the IFWL combo code.
Review-Url: https://codereview.chromium.org/2494743002
|
|
IFGAS_FontMgr is an interface only for a class only defined on Windows,
plus a class only defined for non-Windows. I'm removing the interface,
renaming the class to have the same name in both cases, and cleaning up
a bit of unused methods.
Review-Url: https://codereview.chromium.org/2494883002
|
|
Remove usunsed methods and FWL_Error returns.
Review-Url: https://codereview.chromium.org/2488963005
|
|
This CL removes a few methods from IFWL that are around just to proxy from
CFWL methods which are, in turn, never called.
Review-Url: https://codereview.chromium.org/2486333004
|
|
Cleaning up virtual methods, unused methods, and visibility.
Review-Url: https://codereview.chromium.org/2491103002
|
|
This CL cleans up the methods and parameters in IFWL_MonthCalendar.
Review-Url: https://codereview.chromium.org/2493583002
|
|
The IFWL_MonthCalendar was never instantiated and had a single sub-class. This
CL folds the subclass into IFWL_MonthCalendar and uses MonthCalendar directly.
Review-Url: https://codereview.chromium.org/2491443003
|
|
Cleaning up more IFWL classes.
Review-Url: https://codereview.chromium.org/2492563002
|
|
This Cl changes the enum into an enum class and updates calling code to pass
the enum instead of a uint32_t
Review-Url: https://codereview.chromium.org/2482253004
|
|
More work cleaning up visiblity, unused methods and return values.
Review-Url: https://codereview.chromium.org/2489013002
|
|
This Cl cleans up the IFWL_Widget class including:
* Making members and methods private where possible
* Removing virtual methods that are never overridden
* Removing methods that do nothing
* Removing unchecked FWL_Error return codes
Review-Url: https://codereview.chromium.org/2488953003
|
|
This CL removes the empty IFWL_ListItem class and uses CFWL_ListItem in its
place. As well, the CFWL_ComboListItem is removed and replaced with
CFWL_ListItem. These were almost duplicate classes and the one missing field
added to CFWL_ListItem.
Review-Url: https://codereview.chromium.org/2487943003
|
|
This CL removes the data provider classes and folds the code into the parent
classes.
Review-Url: https://codereview.chromium.org/2480233003
|