pdfium.git - Unnamed repository; edit this file 'description' to name the repository.

Age	Commit message (Collapse)	Author
2016-05-20	Clean up XFA code which causes warnings	weili
	This is part of efforts to bring XFA to chromium_code standard. The warnings are from unreachable code, or using potentially uninitialized variables, or using assignment within a condition. This change list only contains easy to fix cases. More cleanups will follow. BUG=pdfium:29 Review-Url: https://codereview.chromium.org/1998873002
2016-05-19	Remove Release() from CXFA_WidgetLayoutData	tsepez
	Use unique_ptrs. Review-Url: https://codereview.chromium.org/1990033002
2016-05-16	Remove some c_str() calls from StringCs in xfa docs.	tsepez
	Avoids the risk of possibly getting a non-null terminated buffer if the StringC happened to be created by Mid(), etc. Doesn't seem to happen in practice. Review-Url: https://codereview.chromium.org/1983683003
2016-05-13	Make CFX_WideString(const CFX_WideString&) explicit.	tsepez
	BUG= Review-Url: https://codereview.chromium.org/1979723003
2016-05-11	Replace some calls to Release() with direct delete, part 1.	tsepez
	Searching for the anti-pattern: void Release() { delete this; } We must be explicit on the ownership model. Add unique_ptrs as a result. Review-Url: https://codereview.chromium.org/1960673003
2016-04-27	Standardize on ASSERT.	dsinclair
	There are currently three ways to assert in the code (ASSERT, FXSYS_assert and assert). This CL standardizes on ASSERT. The benefit of ASSERT is that it can be overridden if the platform requies and we can pickup the Chromium version if it has already been defined in the build. This does change behaviour. Currently FXSYS_assert is always defined but ASSERT is only defined in debug builds. So, the FXSYS_assert's would fire in Release builds. That will no longer happen. BUG=pdfium:219 Review-Url: https://codereview.chromium.org/1914303003
2016-04-21	Cleanup FDE interfaces.	dsinclair
	This CL removes IFDE_TextOut, IFDE_Path, IFDE_RenderContext, IFDE_RenderDevice, and IFDE_VisualSetIterator in favour of the concrete classes. BUG=pdfium:468 Review URL: https://codereview.chromium.org/1896893003
2016-04-14	Simplify XFA event handling.	thestig
	- Avoid casting to void* - Don't bother firing events that no one listens for Review URL: https://codereview.chromium.org/1890563003
2016-04-13	Remove implicit cast from CFX_WideString to (const wchar_t*)	tsepez
	BUG= Review URL: https://codereview.chromium.org/1882043004
2016-04-08	Rename both As{Byte,Wide}StringC() helpers to AsStringC().	tsepez
	The naming is redundant given the base type, and will stand in the way of consolidating Byte and Wide code. BUG= Review URL: https://codereview.chromium.org/1862123003
2016-04-06	Move remaining xfa/include/fxfa files	dsinclair
	This CL moves the remaining files in xfa/include/fxfa to xfa/fxfa/include. Review URL: https://codereview.chromium.org/1864973005
2016-04-06	Make CFX_WideString::FromUTF8() take a CFX_ByteStringC argument.	tsepez
	Methods that take string arguments and do not persist them should take StringC types as argument rather than discrete ptr/len args. Avoids a number of implicit casts from CFX_ByteString to char. BUG= Review URL: https://codereview.chromium.org/1861183002
2016-04-05	Make down-conversion explicit from CFX_Widetring to CFX_WideStringC.	tsepez
	Companion to https://codereview.chromium.org/1853233002 BUG= Review URL: https://codereview.chromium.org/1857073002
2016-04-04	Cleanup the FF Handler proxy methods.	dsinclair
	This CL removes the proxy methods from CXFA_FFWidgetHandler and CXFA_DocHandler and removes CXFA_FFMenuHandler as it was only proxy methods. The calls are made directly on the object now. Review URL: https://codereview.chromium.org/1857893002
2016-04-01	Remove CFX_{Byte,Wide}String::Equal in favor of "==".	tsepez
	Makes the code slightly cleaner. Review URL: https://codereview.chromium.org/1846083002
2016-03-31	Remove IXFA_* interfaces.	dsinclair
	This CL removes the IXFA_* interfaces which are: - Implemented once. - Not implemented by an fpdfsdk class. This requires making a few classes visible to fpdfsdk so we can have the correct instances available instead of the IXFA types. Review URL: https://codereview.chromium.org/1846993002
2016-03-29	Remove IFDE_XML* classes.	dsinclair
	The CFDE_XML* classes did not inhert from the IFDE_XML variants but we casted to them anyway. This CL removes the IFDE_XML* variants and we just use the CPDF_XML* classes directly. BUG=pdfium:357 Review URL: https://codereview.chromium.org/1836353002
2016-03-25	Remove FX_DWORD from XFA.	tsepez
	Review URL: https://codereview.chromium.org/1830323006
2016-03-18	Fix a typo	Wei Li
	R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1808853007 .
2016-03-14	Move xfa/src up to xfa/.	Dan Sinclair
	This CL moves the xfa/src files up to the xfa/ directory and fixes the includes, include guards, and build files. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1803723002 .