pdfium.git - Unnamed repository; edit this file 'description' to name the repository.

Age	Commit message (Collapse)	Author
2016-04-25	Pass CFX_*StringCs to FX_HashCode_GETA and _GETW hash functions.	tsepez
	Too many calls were of the form fn(x.c_str(), x.GetLength()) which is an anti-pattern given the StringC classes which tie these together. There are a few places where explicit CFX_*StringCs are constructed, but this can be avoided by changing the args to these functions in the same manner. Removed String_ from name of functions since it added little value. Also removed default argument. Review URL: https://codereview.chromium.org/1919563002
2016-04-14	Rename CFX_ByteTextBuf::GetByteString() to AsStringC().	tsepez
	Do the same for CFX_WideTextBuf as well. The name is confusing because these return CFX_ByteStringC, not CFX_ByteString. The AsStringC naming gives parallelism with the string types themselves, and may help to indicate that the result is only good for the lifetime of the object being operated upon. Review URL: https://codereview.chromium.org/1886263003
2016-04-14	Replace calls to deprecated CFX_{Wide,Byte}String::Empty()	tsepez
	Use the more standard name "clear()" instead. Review URL: https://codereview.chromium.org/1888103002
2016-04-13	Remove implicit cast from CFX_WideString to (const wchar_t*)	tsepez
	BUG= Review URL: https://codereview.chromium.org/1882043004
2016-04-13	Remove implicit cast from CFX_ByteString to (const char*).	tsepez
	BUG= Review URL: https://codereview.chromium.org/1885973002
2016-04-08	Rename both As{Byte,Wide}StringC() helpers to AsStringC().	tsepez
	The naming is redundant given the base type, and will stand in the way of consolidating Byte and Wide code. BUG= Review URL: https://codereview.chromium.org/1862123003
2016-04-06	Make CFX_WideString::FromUTF8() take a CFX_ByteStringC argument.	tsepez
	Methods that take string arguments and do not persist them should take StringC types as argument rather than discrete ptr/len args. Avoids a number of implicit casts from CFX_ByteString to char. BUG= Review URL: https://codereview.chromium.org/1861183002
2016-04-06	Rename CFX_WideStringC::raw_str() to c_str()	tsepez
	No functional change intended. This difference in naming is standing in the way of consolidating some of the string code between Wide and Byte strings. The Wide code wants to call raw_str() in exactly the same spots that the Byte code calls c_str(). This makes sense, because in both places we get a character type back, and not a uint*_t type. If WideStringC had a raw_str() method, it would have to return uint32_t or similar. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1863593004
2016-04-05	Make down-conversion explicit from CFX_Widetring to CFX_WideStringC.	tsepez
	Companion to https://codereview.chromium.org/1853233002 BUG= Review URL: https://codereview.chromium.org/1857073002
2016-04-05	Rename GetCStr and GetPtr to match CFX_ByteString.	dsinclair
	This CL updates CFX_ByteStringC to use the more common c_str and raw_str instead of GetCStr and GetPtr. Review URL: https://codereview.chromium.org/1857713003
2016-04-04	Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.	tsepez
	Having this happen implicitly can be dangerous because the lifetime has to be considered; we should have caught the "red bots" in https://codereview.chromium.org/1847333004/#ps60001 at compile time. Review URL: https://codereview.chromium.org/1853233002
2016-04-01	Remove CFX_{Byte,Wide}String::Equal in favor of "==".	tsepez
	Makes the code slightly cleaner. Review URL: https://codereview.chromium.org/1846083002
2016-03-31	Remove IXFA_* interfaces.	dsinclair
	This CL removes the IXFA_* interfaces which are: - Implemented once. - Not implemented by an fpdfsdk class. This requires making a few classes visible to fpdfsdk so we can have the correct instances available instead of the IXFA types. Review URL: https://codereview.chromium.org/1846993002
2016-03-25	Remove FX_DWORD from XFA.	tsepez
	Review URL: https://codereview.chromium.org/1830323006
2016-03-23	Move core/include/fxcrt to core/fxcrt/include.	Dan Sinclair
	This CL moves the fxcrt code into the core/fxcrt directory. The only exception was fx_bidi.h which was moved into core/fxcrt as it is not used outside of core/. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1825953002 .
2016-03-15	Move xfa/include/fxjse/fxjse.h into xfa/fxjse/include.	Dan Sinclair
	This CL moves the fxjse.h header and splits the cfxjse_arguments.h into its own file. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1807623002 .
2016-03-14	Move xfa/src up to xfa/.	Dan Sinclair
	This CL moves the xfa/src files up to the xfa/ directory and fixes the includes, include guards, and build files. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1803723002 .