pdfium.git - Unnamed repository; edit this file 'description' to name the repository.

Age	Commit message (Collapse)	Author
2016-11-29	Use unique_ptr in CFXA_FM expressions constructorschromium/2937	npm
	Review-Url: https://codereview.chromium.org/2534143003
2016-11-28	Use unique pointers in CXFA_FMParse	npm
	Replaced CXFA_FMParse's returns to be unique pointers to prevent leaks. Review-Url: https://codereview.chromium.org/2530933002
2016-11-02	Remove FX_BOOL from xfa.	tsepez
	Review-Url: https://codereview.chromium.org/2467203003
2016-09-29	Move core/fxcrt/include to core/fxcrt	dsinclair
	BUG=pdfium:611 Review-Url: https://codereview.chromium.org/2382723003
2016-08-03	Fixup class name spelling	dsinclair
	Fix CXFA_FMIdentifierExpressionn to remove the duplicate n. Review-Url: https://codereview.chromium.org/2210543002
2016-08-03	Fix FMCallExpression undefined shift behaviour.	dsinclair
	When determining which params should be an object and which are a value it is possible to overflow the int on the shift comparision (if there are more then 32 arguments). This never happens in practise as it's a controlled list of method calls which we pass objects for. Cap the check at 32 for the shifting so it doesn't overflow. We can revisit and extend the value later if we ever have an internal formcalc method that needs an object in a position greater then 32. BUG=chromium:603490 Review-Url: https://codereview.chromium.org/2206253002
2016-06-16	Make code compile with clang_use_chrome_plugin (part V)chromium/2770	weili
	This change mainly contains files in xfa/fxfa directory. This is part of the efforts to make PDFium code compilable by Clang chromium style plugins. The changes are mainly the following: -- move inline constructor/destructor of complex class/struct out-of-line; -- add constructor/destructor of complex class/struct if not explicitly defined; -- add explicit out-of-line copy constructor when needed; -- move inline virtual functions out-of-line; -- Properly mark virtual functions with 'override'; -- some minor cleanups; BUG=pdfium:469 Review-Url: https://codereview.chromium.org/2071683002
2016-05-13	Make CFX_WideString(const CFX_WideString&) explicit.	tsepez
	BUG= Review-Url: https://codereview.chromium.org/1979723003
2016-04-28	Convert CFX_PtrArray to typesafe CFX_ArrayTemplate, Part 6	tsepez
	Review-Url: https://codereview.chromium.org/1926303002
2016-04-27	Standardize on ASSERT.	dsinclair
	There are currently three ways to assert in the code (ASSERT, FXSYS_assert and assert). This CL standardizes on ASSERT. The benefit of ASSERT is that it can be overridden if the platform requies and we can pickup the Chromium version if it has already been defined in the build. This does change behaviour. Currently FXSYS_assert is always defined but ASSERT is only defined in debug builds. So, the FXSYS_assert's would fire in Release builds. That will no longer happen. BUG=pdfium:219 Review-Url: https://codereview.chromium.org/1914303003
2016-04-25	Pass CFX_*StringCs to FX_HashCode_GETA and _GETW hash functions.	tsepez
	Too many calls were of the form fn(x.c_str(), x.GetLength()) which is an anti-pattern given the StringC classes which tie these together. There are a few places where explicit CFX_*StringCs are constructed, but this can be avoided by changing the args to these functions in the same manner. Removed String_ from name of functions since it added little value. Also removed default argument. Review URL: https://codereview.chromium.org/1919563002
2016-04-14	Rename CFX_ByteTextBuf::GetByteString() to AsStringC().	tsepez
	Do the same for CFX_WideTextBuf as well. The name is confusing because these return CFX_ByteStringC, not CFX_ByteString. The AsStringC naming gives parallelism with the string types themselves, and may help to indicate that the result is only good for the lifetime of the object being operated upon. Review URL: https://codereview.chromium.org/1886263003
2016-04-06	Rename CFX_WideStringC::raw_str() to c_str()	tsepez
	No functional change intended. This difference in naming is standing in the way of consolidating some of the string code between Wide and Byte strings. The Wide code wants to call raw_str() in exactly the same spots that the Byte code calls c_str(). This makes sense, because in both places we get a character type back, and not a uint*_t type. If WideStringC had a raw_str() method, it would have to return uint32_t or similar. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1863593004
2016-04-05	Rename GetCStr and GetPtr to match CFX_ByteString.	dsinclair
	This CL updates CFX_ByteStringC to use the more common c_str and raw_str instead of GetCStr and GetPtr. Review URL: https://codereview.chromium.org/1857713003
2016-04-01	Remove CFX_ string type static initializers.	tsepez
	In XFA, we were constructing some CFX_ string types before we reached main(). Setting breakpoints on these as well as main() shows we hit main first after applying the patch. Doing so also turned up an unused variable, presumably because the static initializer made it appear used. Review URL: https://codereview.chromium.org/1846353002
2016-04-01	Remove CFX_{Byte,Wide}String::Equal in favor of "==".	tsepez
	Makes the code slightly cleaner. Review URL: https://codereview.chromium.org/1846083002
2016-03-25	Remove FX_DWORD from XFA.	tsepez
	Review URL: https://codereview.chromium.org/1830323006
2016-03-23	Move core/include/fxcrt to core/fxcrt/include.	Dan Sinclair
	This CL moves the fxcrt code into the core/fxcrt directory. The only exception was fx_bidi.h which was moved into core/fxcrt as it is not used outside of core/. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1825953002 .
2016-03-14	Move xfa/src up to xfa/.	Dan Sinclair
	This CL moves the xfa/src files up to the xfa/ directory and fixes the includes, include guards, and build files. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1803723002 .