| Age | Commit message (Collapse) | Author |
|---|
|
Use smart pointers instead of raw pointer to make memory management
easier for classes mainly under xfa/fxfa.
Also change the return type of IFGAS_FontMgr::Create() to smart
pointer type.
BUG=pdfium:518
Review-Url: https://codereview.chromium.org/2227883002
|
|
This change mainly contains files in fpdfsdk/ directory.
This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins.
The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups plus removing an unused file and splitting
cxfa_eventparam out from fxfa.h
BUG=pdfium:469
Review-Url: https://codereview.chromium.org/2062313002
|
|
This class is not used anywhere. Also there are no implementation of its
member functions except MoveToNext() function which was implemented
wrong -- direct return in a while loop?
BUG=pdfium:29
Review-Url: https://codereview.chromium.org/2007623002
|
|
Review-Url: https://codereview.chromium.org/1993313005
|
|
Review-Url: https://codereview.chromium.org/1990793004
|
|
Review-Url: https://codereview.chromium.org/1976123003
|
|
Capitalize m_bindItems while we're at it.
Review-Url: https://codereview.chromium.org/1932513002
|
|
- Avoid casting to void*
- Don't bother firing events that no one listens for
Review URL: https://codereview.chromium.org/1890563003
|
|
Avoids downgrade followed by duplication of existing strings.
Review URL: https://codereview.chromium.org/1891673003
|
|
This CL moves the remaining files in xfa/include/fxfa to xfa/fxfa/include.
Review URL: https://codereview.chromium.org/1864973005
|
