| Age | Commit message (Collapse) | Author |
|---|
|
This CL converts the CXFA_MarginData::Try{Left|Right|Top|Bottom}Inset
methods to return an Optional instead of a bool with an out param.
Change-Id: Ib48384c1670db7255b2b6388ced41f2f10fe4385
Reviewed-on: https://pdfium-review.googlesource.com/18890
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
This CL adds Get*Inset helpers to CXFA_MarginData which just return a
default value of 0 if the Try*Inset method fails.
Change-Id: I03b00b7a371c39e521f95952e965b4a3ef71d517
Reviewed-on: https://pdfium-review.googlesource.com/18870
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
This CL renames the CXFA_MarginData::Get*Inset methods to
CXFA_MarginData::Try*Inset to match the fact that they may fail. The
default value has been removed and all the callers correctly set the
default values.
Change-Id: Ib0dc8dc35807b60a0ddc0e5724604cb39845fcea
Reviewed-on: https://pdfium-review.googlesource.com/18771
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
The CXFA_Data nd CXFA_ExData files are part of the data hierarchy. They
need to be renamed to not clash with XFA node names.
Change-Id: I1ad11dd92edf26912f845aec21c57a9d23e51fcf
Reviewed-on: https://pdfium-review.googlesource.com/18270
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
This CL renames CXFA_Margin to CXFA_MarginData to reflect the fact this
is part of the data hierarchy.
Change-Id: I50d82d01fcaf35c621f13b8b68bc04d850ec885a
Reviewed-on: https://pdfium-review.googlesource.com/17986
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
