pdfium.git - Unnamed repository; edit this file 'description' to name the repository.

Age	Commit message (Collapse)	Author
2016-06-09	Fix crash in CXFA_Node::TryUserData() (speculative)	tsepez
	Fix is speculative because I can't repro locally, but I know the current code is wrong. I fixed this intially in https://codereview.chromium.org/2015143005/ I then broke it again in https://codereview.chromium.org/2019333006/ There is another spot where we are still casting through void, and the CXFA_Node's alignment is getting messed up when it fails to adjust for it's vtable. Using CFXJSE_HostObject consistently avoids the issue. Adding a virtual dtor to CFXJSE_HostObject might skirt the issue, but I want to be able to wrap simple objects without that penalty if desired. BUG=616339 Review-Url: https://codereview.chromium.org/2055473004
2016-06-08	Remove more FXJSE c-method wrappers.	dsinclair
	This Cl cleans up a bunch of the FXJSE_* methods and moves others into the classes where they most make sense. Review-Url: https://codereview.chromium.org/2045883004
2016-06-01	Stop casting struct CFXJSE_ArgumentsImpl to unrelated class CFXJSE_Arguments	tsepez
	Remove the 'Impl entirely, and put the details into the class itself. Review-Url: https://codereview.chromium.org/2036513002
2016-05-31	Replace CFXJSE_Value create/destroy with new and delete.	dsinclair
	In most cases, the destroy calls were removed and the object wrapped in a unique_ptr. Review-Url: https://codereview.chromium.org/2014323003
2016-05-27	Workaround dubious casting between CXFA_Object and void* in FXJSE	tsepez
	This is just a crock to get things working until we fix the underlying issue. When there's single-inheritance, it may often work in practice to C-style (reinterpret) cast a Derived* ptr to void* and then back to a Base* ptr. One place where this blows up is if Derived has virtual functions but Base does not, in which case the world will be offset by the size of a vtable ptr. Because of the use of void* types in FXJSE, the above was happening when setting a CXFA_ThisProxy (Derived, virtual) to be a global object (void*). This would then be cast back to a CFXA_Object (Base, non-virtual) and chaos is ensured. Not sure how far back this goes. Along the way, pick up some tidying which was necessary for simplicity while tracking this down. BUG=613607 Review-Url: https://codereview.chromium.org/2015143005
2016-05-26	Rename FXJSE_CLASS to avoid confusion with CFXJSE_CLASS	tsepez
	BUG= Review-Url: https://codereview.chromium.org/2010013003
2016-05-26	Remove FXJSE_HOBJECT and FXJSE_HVALUE for CFXJSE_Value*	dsinclair
	This CL replaces FXJSE_HOBJECT and FXJSE_HVALUE with the concrete CFXJSE_Value* type. All variables are renamed to match. Review-Url: https://codereview.chromium.org/2012253002
2016-05-26	Replace FXJSE_HCLASS with CFXJSE_Class*	dsinclair
	This CL removes FXJSE_HCLASS and replaces with CFXJSE_Class*. All variables have been updated to the new type. Review-Url: https://codereview.chromium.org/2014213002
2016-05-26	Replace FXJSE_HCONTEXT with CFXJSE_Context*	dsinclair
	This Cl removes FXJSE_HCONTEXT and replaces it with the concrete CFXJSE_Context. All varibles have been updated as well to match the new type. Review-Url: https://codereview.chromium.org/2013963005
2016-05-26	Revert of Remove parameters which are always null (patchset #1 id:1 of ↵	dsinclair
	https://codereview.chromium.org/2009413002/ ) Reason for revert: Suspect that the lack of this parameter being passed accurately to GetObject is leading to https://bugs.chromium.org/p/chromium/issues/detail?id=613607, and that the right fix will be to pass it. Original issue's description: > Remove parameters which are always null > > These parameters are never set, remove them and their supporting code. > > Committed: https://pdfium.googlesource.com/pdfium/+/818e1900a3811e1bde1e594e4966db612f845966 TBR=tsepez@chromium.org,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2014863002
2016-05-25	Remove parameters which are always null	dsinclair
	These parameters are never set, remove them and their supporting code. Review-Url: https://codereview.chromium.org/2009413002
2016-05-25	Rename FXJSE_HRUNTIME to v8::Isolate	dsinclair
	This CL renames all of the instances of FXJSE_HRUNTIME to be v8::Isolate* and updates the various varible names to match the new type. Review-Url: https://codereview.chromium.org/2010833002
2016-05-17	Remove some CFX_ArrayTemplate<> usage from fxjse	tsepez
	Allows use of otherwise incompatible unique_ptrs. Review-Url: https://codereview.chromium.org/1992513002
2016-04-27	Standardize on ASSERT.	dsinclair
	There are currently three ways to assert in the code (ASSERT, FXSYS_assert and assert). This CL standardizes on ASSERT. The benefit of ASSERT is that it can be overridden if the platform requies and we can pickup the Chromium version if it has already been defined in the build. This does change behaviour. Currently FXSYS_assert is always defined but ASSERT is only defined in debug builds. So, the FXSYS_assert's would fire in Release builds. That will no longer happen. BUG=pdfium:219 Review-Url: https://codereview.chromium.org/1914303003
2016-04-19	XFA unused function cleanup	dsinclair
	This CL removes a series of unused XFA methods. Review URL: https://codereview.chromium.org/1899103002
2016-04-13	Remove implicit cast from CFX_ByteString to (const char*).	tsepez
	BUG= Review URL: https://codereview.chromium.org/1885973002
2016-03-15	Move xfa/include/fxjse/fxjse.h into xfa/fxjse/include.	Dan Sinclair
	This CL moves the fxjse.h header and splits the cfxjse_arguments.h into its own file. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1807623002 .
2016-03-14	Move xfa/src up to xfa/.	Dan Sinclair
	This CL moves the xfa/src files up to the xfa/ directory and fixes the includes, include guards, and build files. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1803723002 .