Age | Commit message (Collapse) | Author |
|
It isn't buying us anthing, and it looks strange in
a struct when other uint types are already present.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1821043003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1820573002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1808853007 .
|
|
BUG=pdfium:401
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1758553003 .
|
|
This CL moves the fxjse.h header and splits the cfxjse_arguments.h into its
own file.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1807623002 .
|
|
This CL moves the xfa/src files up to the xfa/ directory and fixes the includes,
include guards, and build files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1803723002 .
|
|
This Cl moves the code in xfa/src/fxfa/src/common to the diretory which
contains the respective implementations and removes the xfa/src/fxfa/src/common
directory. It them moves all of the code in xfa/src/fxfa/src up one level and
removes the xfa/src/fxfa/src
directory.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1770073003 .
|
|
This value is never set and never read. Removing it fixes a series of warnings
when building on OSX as g_XFAElementPropertyIndex does not initialize the
value.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1744893002 .
|
|
This CL removes duplicate forward declarations, removes extraneous declarations
and adds a couple of missing declarations.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1741003002 .
|
|
Grepping for FX_BOOL and |==| on the same line gives
a very strong clue that the expression won't be out
of range of the |bool| type iteself.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1736323003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735833003 .
|
|
They're technically not allowed because they are reserved
for the preprocessor.
Also get rid of LPC* typedefs along the way.
Also provide a header for a data file containing many
instance of these found along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1722873002 .
|
|
This CL sorts all the includes in the xfa/ directory. There are a lot of IWYU
errors that have been fixed to make things compile again.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1722803002 .
|
|
This Cl updates the includes in the XFA directory to be relative to the
pdfium/ directory instead of the current directory.
This does not sort the includes as that is a larger IWYU task that will be
handled separately.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1723533002 .
|
|
This CL updates include guards throughout the code base to be in the
chromium style.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1707893004 .
|
|
Fix IWYU and include paths as we go.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1701883004 .
|
|
Remove implicit CXFA_Node* operator.
Add bool() operator.
Remove IsExistInXML() which duplicates bool operator.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1663313002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1640033002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1636873004 .
|
|
Also remove useless files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1570743002 .
|
|
BUG=pdfium:292
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1486573002 .
|
|
(cherry picked from commit 5b3d0208723f21c50b9922bdc500c9d78c359a25)
Original Review URL: https://codereview.chromium.org/1389783002 .
New changes to fix IWYU in:
fpdfsdk/include/fpdfxfa/fpdfxfa_app.h
xfa/include/fxfa/fxfa.h
xfa/include/fxfa/fxfa_objectacc.h
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1388023003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1377853004 .
|
|
No behavior change.
Generated by:
find . -name '*.cpp' -o -name '*.h' | \
grep -E -v 'third_party|thirdparties|lpng_v163|tiff_v403' | \
xargs ../../buildtools/mac/clang-format -i
Then manually merged https://codereview.chromium.org/1269223002/
See thread "tabs vs spaces" on pdfium@googlegroups.com for discussion.
BUG=none
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1176333002.
(cherry picked from commit 0ef0de55657db8a83372ad8eb22d84c5893afc4c)
Review URL: https://codereview.chromium.org/1195943005.
|
|
Nearly automatic merge + re-run script on new files.
Original Review URL: https://codereview.chromium.org/1180593004.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1174303002.
|
|
Original Review URL: https://codereview.chromium.org/1171733003
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1178613002.
|
|
Near-automatic merge, plus re-running scripts to update
additional usage.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1172793002
|
|
A second case of casting willy-nilly between unrelated structures
to provide information hiding. Bad Idea. Remove dozens of casts
in the process.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1155273002
|
|
There are better ways to provide information hiding than casting
willy-nilly from an unrelated structure. Kill dozens of casts in
the process.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1146153005
|
|
Move interface comments from the implementation header to the
interface header.
Replace Create / Release functions with static methods.
Replace dubious Release() methods with deletion via virtual dtor, also
for IXFA_App and IXFA_FontMgr while we're at it.
Untabify and fix (theoretically) illegal _CAP include guard definitions
for fpdfxfa/ headers.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1153553003
|
|
BUG=471991
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1126273004
|
|
Not just a simple merge, but changes to remove CFX_Object from XFA.
Original Review URL: https://codereview.chromium.org/1088733002
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1087053002
|
|
On the XFA branch, there are still some of these warnings that were fixed
(mostly) in master. Correct a few more of these. Also tidy a few needless
returns.
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/891003003
|
|
61750 for dateField input "aaa" not dislpay;
update font map;
|
|
|