Age | Commit message (Collapse) | Author |
|
Since it is malloc'd, memset, and such, and clang-cl
notices this. Also delete unused function found by clang-cl.
BUG=pdfium:429
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1777573003 .
|
|
This reverts commit c582c0ddfea8ba01c8449ed7841cdb33c12e0a98.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1769263002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1772543003 .
|
|
This does not appear to ever be defined, removed.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1773753002 .
|
|
This CL fixes and enables:
* readability/namespace
* readability/multiline_string
* readability/multiline_comment
* readability/inheritance
* readability/function
* readability/braces
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1747123002 .
|
|
Helps with transparency. Also remove default args and
use override consistently in the affected methods.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1751093002 .
|
|
This is never defined in the current code base. Remove.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1751913002 .
|
|
Change a couple int32_t's to size_t in order to fix warnings on OSX.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1747793002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1749703002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1749793002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1749783002 .
|
|
This CL removes duplicate forward declarations, removes extraneous declarations
and adds a couple of missing declarations.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1741003002 .
|
|
Grepping for FX_BOOL and |==| on the same line gives
a very strong clue that the expression won't be out
of range of the |bool| type iteself.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1736323003 .
|
|
Do some cleanups along the way.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1732223002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1740863002 .
|
|
Add default ctor so we don't have to zero these out.
Also, make CFX_VTemplate simpler.
Also, remove the Set() method in favor of assignment.
Also, remove CFX_FloatPoint define.
Also, remove unused (and wrong) CFX_VTemplate methods.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1733523003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735833003 .
|
|
Missed one remaining use of FGAS_LPCFONTUSB.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735623003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735663002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1731483004 .
|
|
Two files become completely empty and are deleted.
Oddly, they never appeared in gyp/gn files.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1724303002 .
|
|
This CL enables several of the diabled whitelist/* lint checks.
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1730553002 .
|
|
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1722913002 .
|
|
We need to pull in the fgas_base.h file before looking at the _FX_OS_ checks
otherwise they become true and windows XFA build fails.
TBR=tsepez@chromium.org
BUG=pdfium:65
Review URL: https://codereview.chromium.org/1725843002 .
|
|
This CL sorts all the includes in the xfa/ directory. There are a lot of IWYU
errors that have been fixed to make things compile again.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1722803002 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1723693002 .
|
|
Move FX_DOUBLE to fx_system.h to keep it with the others
until we remove it.
Having one memset/cpy wrapper is dubious, two are worse.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1724523002 .
|
|
Also fix -Wunused warnings as a result of this change.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1717063002 .
|
|
We wouldn't want to imply that any of this is
thread-safe ...
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1724483002 .
|
|
This Cl updates the includes in the XFA directory to be relative to the
pdfium/ directory instead of the current directory.
This does not sort the includes as that is a larger IWYU task that will be
handled separately.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1723533002 .
|
|
This update fixes all include guards so cpplint build/header_guard completes
without error.
A presubmit check is added to make sure the guards stay clean.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1719083002 .
|
|
Use/add CFX_{Byte,Wide}String::FromFoo() instead.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1711893003 .
|
|
The face names from font file stream may be different
with the ones from chromium. Pdfium should save face
names from chromium for font mapping when it works
in sandbox environment.
BUG=pdfium:392
BUG=pdfium:393
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1710753002 .
|
|
This CL updates include guards throughout the code base to be in the
chromium style.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1707893004 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1647613003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1636873004 .
|
|
BUG=pdfium:367
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1620813003 .
|
|
BUG=pdfium:350
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1608593003 .
|
|
Inconsisten use of "override".
BUG=pdfium:354
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1577723004 .
|
|
BUG=pdfium:347
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1573893002 .
|
|
BUG=pdfium:348
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1579503002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1572393002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1578003002 .
|
|
Fix lint errors along the way.
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567343002 .
(cherry picked from commit 9adfbb0920a258e916003b1ee9515e97879db82a)
Review URL: https://codereview.chromium.org/1577503002 .
|
|
Also remove useless files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1570743002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1521163002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1521563002 .
(cherry picked from commit 1956a174020686f91cd3b34294e91f4560fe45aa)
Review URL: https://codereview.chromium.org/1526823002 .
|
|
This CL includes the following changes:
1. Add return value for InitFont(). It can indicate a failure
in the initialization of non-standard fonts.
2. Change NULL to nullptr.
3. Rewrite several pointer checking.
BUG=pdfium:279, pdfium:286
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1465423002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1443563002 .
|
|
Mostly unused variables, unused private members, or
initialization order. Added a few missing initializers
for pointer members along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1414903004 .
|