Age | Commit message (Collapse) | Author |
|
This CL enables several of the diabled whitelist/* lint checks.
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1730553002 .
|
|
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1722913002 .
|
|
This CL sorts all the includes in the xfa/ directory. There are a lot of IWYU
errors that have been fixed to make things compile again.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1722803002 .
|
|
This Cl updates the includes in the XFA directory to be relative to the
pdfium/ directory instead of the current directory.
This does not sort the includes as that is a larger IWYU task that will be
handled separately.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1723533002 .
|
|
This update fixes all include guards so cpplint build/header_guard completes
without error.
A presubmit check is added to make sure the guards stay clean.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1719083002 .
|
|
Use/add CFX_{Byte,Wide}String::FromFoo() instead.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1711893003 .
|
|
This CL updates include guards throughout the code base to be in the
chromium style.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1707893004 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1636873004 .
|
|
BUG=pdfium:261
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1570893003 .
|
|
Fix lint errors along the way.
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567343002 .
(cherry picked from commit 9adfbb0920a258e916003b1ee9515e97879db82a)
Review URL: https://codereview.chromium.org/1577503002 .
|
|
Also remove useless files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1570743002 .
|
|
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1547833002 .
(cherry picked from commit d20dfba2ae10e8aeb328328f09da79ff904110a8)
Review URL: https://codereview.chromium.org/1545183002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1521163002 .
|
|
In some cases, we can use the safe FX_Alloc2D, in others
there's an extra multiplication by the size of the type.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1519233002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1505353009 .
|
|
BUG=pdfium:261
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1500313002 .
|
|
Review URL: https://codereview.chromium.org/1513363002 .
(cherry picked from commit f32c969bce6743fca1e7ff796b54a1692d26d7f0)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1519693002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1413253003 .
|
|
Mostly unused variables, unused private members, or
initialization order. Added a few missing initializers
for pointer members along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1414903004 .
|
|
BUG=pdfium:261
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1413343003 .
|
|
Mainly:
volatile/override/method shadowing.
unused variables.
intialization list init order.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1422113003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1422713007 .
|
|
Add some consts and overrides along the way.
Group some statics together.
Tidy some unused vars.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1411683005 .
|
|
We need to include the <cmath> header so std::isnan exists.
BUG=pdfium:250
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1411633006 .
|
|
The unittests had a case where we added an abort() call to
the code, but left the case. And one of the expected results
was not updated with the code.
The fpdfview.cpp got broken by a recent change, and was not
caught due to all the void* returns. Also, the tests now
clean up the page automatically.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1403373006 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1377853004 .
|
|
Similarly, Clean up CFX_UnicodeEncodingEx and remove IFX_FontEncodingEx.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1296753003 .
(cherry picked from commit 52a48aadc19b2dee8abeb702269bb168eb6b6999)
Review URL: https://codereview.chromium.org/1297083002 .
|
|
Also add a presubmit that checks for this so I don't have to keep doing it.
No behavior change.
Generated by:
find . -name '*.cpp' -o -name '*.h' | \
grep -E -v 'third_party|thirdparties|lpng_v163|tiff_v403' | \
xargs ../../buildtools/mac/clang-format -i
Then manually merged https://codereview.chromium.org/1269223002/
See thread "tabs vs spaces" on pdfium@googlegroups.com for discussion.
BUG=none
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1277043002 .
|
|
It would seem that this never merged completely.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1277583002 .
|
|
No behavior change.
Generated by:
find . -name '*.cpp' -o -name '*.h' | \
grep -E -v 'third_party|thirdparties|lpng_v163|tiff_v403' | \
xargs ../../buildtools/mac/clang-format -i
Then manually merged https://codereview.chromium.org/1269223002/
See thread "tabs vs spaces" on pdfium@googlegroups.com for discussion.
BUG=none
|
|
Required fixing xfa-specific code.
Original Review URL: https://codereview.chromium.org/1192013002.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1176413004.
|
|
Only manual merge was core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp
follwed by scripts.
Original Review URL: https://codereview.chromium.org/1179693003.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1179953002.
|
|
Nearly automatic merge + re-run script on new files.
Original Review URL: https://codereview.chromium.org/1180593004.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1174303002.
|
|
Original Review URL: https://codereview.chromium.org/1171733003
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1178613002.
|
|
Near-automatic merge, plus re-running scripts to update
additional usage.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1172793002
|
|
Not just a simple merge, but changes to remove CFX_Object from XFA.
Original Review URL: https://codereview.chromium.org/1088733002
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1087053002
|
|
This bug is fixed in https://github.com/zxing/zxing/commit/71d83953bdb2aa83a5c70e7e005adcbc523647dc
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/837663004
|
|
Here, testing/gtest and testing/some-pdfium-stuff will be different
directories, since we will use the gtest at top-level. For standalone,
they happen to be the same.
TBR=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/852493002
|
|
Previously all the files in barcode are lumped together.
The naming of some files are inconsistent,
leading to difficult understanding of the structure.
Now files are grouped based on different barcode type like in zxing.
This also matches what it looks like in other xfa folders.
The file names in each folder could be further modified to be consistent.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/842043002
|
|
R=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/840903002
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/742243002
|
|
TBR=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/798723003
|
|
Previously no big integer support in Pdfium and XFA.
The PDF417 barcode functionality could not work properly.
BUG=https://code.google.com/p/pdfium/issues/detail?id=98
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/777553002
|
|
|