Age | Commit message (Collapse) | Author |
|
Mostly unused variables, unused private members, or
initialization order. Added a few missing initializers
for pointer members along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1414903004 .
|
|
BUG=pdfium:261
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1413343003 .
|
|
Mainly:
volatile/override/method shadowing.
unused variables.
intialization list init order.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1422113003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1422713007 .
|
|
Add some consts and overrides along the way.
Group some statics together.
Tidy some unused vars.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1411683005 .
|
|
We need to include the <cmath> header so std::isnan exists.
BUG=pdfium:250
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1411633006 .
|
|
The unittests had a case where we added an abort() call to
the code, but left the case. And one of the expected results
was not updated with the code.
The fpdfview.cpp got broken by a recent change, and was not
caught due to all the void* returns. Also, the tests now
clean up the page automatically.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1403373006 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1377853004 .
|
|
Similarly, Clean up CFX_UnicodeEncodingEx and remove IFX_FontEncodingEx.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1296753003 .
(cherry picked from commit 52a48aadc19b2dee8abeb702269bb168eb6b6999)
Review URL: https://codereview.chromium.org/1297083002 .
|
|
Also add a presubmit that checks for this so I don't have to keep doing it.
No behavior change.
Generated by:
find . -name '*.cpp' -o -name '*.h' | \
grep -E -v 'third_party|thirdparties|lpng_v163|tiff_v403' | \
xargs ../../buildtools/mac/clang-format -i
Then manually merged https://codereview.chromium.org/1269223002/
See thread "tabs vs spaces" on pdfium@googlegroups.com for discussion.
BUG=none
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1277043002 .
|
|
It would seem that this never merged completely.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1277583002 .
|
|
No behavior change.
Generated by:
find . -name '*.cpp' -o -name '*.h' | \
grep -E -v 'third_party|thirdparties|lpng_v163|tiff_v403' | \
xargs ../../buildtools/mac/clang-format -i
Then manually merged https://codereview.chromium.org/1269223002/
See thread "tabs vs spaces" on pdfium@googlegroups.com for discussion.
BUG=none
|
|
Required fixing xfa-specific code.
Original Review URL: https://codereview.chromium.org/1192013002.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1176413004.
|
|
Only manual merge was core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp
follwed by scripts.
Original Review URL: https://codereview.chromium.org/1179693003.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1179953002.
|
|
Nearly automatic merge + re-run script on new files.
Original Review URL: https://codereview.chromium.org/1180593004.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1174303002.
|
|
Original Review URL: https://codereview.chromium.org/1171733003
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1178613002.
|
|
Near-automatic merge, plus re-running scripts to update
additional usage.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1172793002
|
|
Not just a simple merge, but changes to remove CFX_Object from XFA.
Original Review URL: https://codereview.chromium.org/1088733002
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1087053002
|
|
This bug is fixed in https://github.com/zxing/zxing/commit/71d83953bdb2aa83a5c70e7e005adcbc523647dc
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/837663004
|
|
Here, testing/gtest and testing/some-pdfium-stuff will be different
directories, since we will use the gtest at top-level. For standalone,
they happen to be the same.
TBR=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/852493002
|
|
Previously all the files in barcode are lumped together.
The naming of some files are inconsistent,
leading to difficult understanding of the structure.
Now files are grouped based on different barcode type like in zxing.
This also matches what it looks like in other xfa folders.
The file names in each folder could be further modified to be consistent.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/842043002
|
|
R=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/840903002
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/742243002
|
|
TBR=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/798723003
|
|
Previously no big integer support in Pdfium and XFA.
The PDF417 barcode functionality could not work properly.
BUG=https://code.google.com/p/pdfium/issues/detail?id=98
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/777553002
|
|
|