Age | Commit message (Collapse) | Author |
|
This Cl moves the code in xfa/src/fxfa/src/common to the diretory which
contains the respective implementations and removes the xfa/src/fxfa/src/common
directory. It them moves all of the code in xfa/src/fxfa/src up one level and
removes the xfa/src/fxfa/src
directory.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1770073003 .
|
|
This CL fixes and enables:
* readability/namespace
* readability/multiline_string
* readability/multiline_comment
* readability/inheritance
* readability/function
* readability/braces
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1747123002 .
|
|
This flag is always defined, remove conditional code and flag.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1752503004 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1745023003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1746053003 .
|
|
The _XFA_LAYOUTITEM_ProcessCACHE_ define is always set and the
_XFA_LAYOUTITEM_MAPCACHE_ define is never set.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1750623002 .
|
|
This CL removes duplicate forward declarations, removes extraneous declarations
and adds a couple of missing declarations.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1741003002 .
|
|
Grepping for FX_BOOL and |==| on the same line gives
a very strong clue that the expression won't be out
of range of the |bool| type iteself.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1736323003 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1735333002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735833003 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1729983002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1733693002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1730713002 .
|
|
They're technically not allowed because they are reserved
for the preprocessor.
Also get rid of LPC* typedefs along the way.
Also provide a header for a data file containing many
instance of these found along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1722873002 .
|
|
This CL sorts all the includes in the xfa/ directory. There are a lot of IWYU
errors that have been fixed to make things compile again.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1722803002 .
|
|
This Cl updates the includes in the XFA directory to be relative to the
pdfium/ directory instead of the current directory.
This does not sort the includes as that is a larger IWYU task that will be
handled separately.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1723533002 .
|
|
This update fixes all include guards so cpplint build/header_guard completes
without error.
A presubmit check is added to make sure the guards stay clean.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1719083002 .
|
|
BUG=pdfium:398
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1704343002 .
|
|
This CL updates include guards throughout the code base to be in the
chromium style.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1707893004 .
|
|
Mark some ctors explicit.
Rename GetXFANode to GetXFAObject to match its return type,
since it is cast to node in many places.
BUG=pdfium:384
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1662063002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1636873004 .
|
|
BUG=pdfium:354
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1580773002 .
|
|
Also remove useless files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1570743002 .
|
|
IFXA_LayoutPage now a pure virtual interface, with its
code moving to CXFA_ContainerLayoutItem's implementaton
of it.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1466103002 .
|
|
Also protect the LayoutItem constructor, as !m_bIsContent
implies the object can be cast to the container class, so
ensure we don't make any of parent class.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1441243005 .
|
|
There is no longer a LayoutItem/LayoutItemImpl distinction.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1441423002 .
|
|
Fixes illegal casting between unrelated types, and removes
about 30 explicit casts that are no longer required.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1441183002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1439083002 .
|
|
Mostly unused variables, unused private members, or
initialization order. Added a few missing initializers
for pointer members along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1414903004 .
|
|
BUG=pdfium:261
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1413343003 .
|
|
No behavior change.
Generated by:
find . -name '*.cpp' -o -name '*.h' | \
grep -E -v 'third_party|thirdparties|lpng_v163|tiff_v403' | \
xargs ../../buildtools/mac/clang-format -i
Then manually merged https://codereview.chromium.org/1269223002/
See thread "tabs vs spaces" on pdfium@googlegroups.com for discussion.
BUG=none
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1183483003.
|
|
Nearly automatic merge + re-run script on new files.
Original Review URL: https://codereview.chromium.org/1180593004.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1174303002.
|
|
Original Review URL: https://codereview.chromium.org/1171733003
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1178613002.
|
|
Near-automatic merge, plus re-running scripts to update
additional usage.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1172793002
|
|
A second case of casting willy-nilly between unrelated structures
to provide information hiding. Bad Idea. Remove dozens of casts
in the process.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1155273002
|
|
There are better ways to provide information hiding than casting
willy-nilly from an unrelated structure. Kill dozens of casts in
the process.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1146153005
|
|
CXFA_ItemLayoutProcessor::CalculatePositionedContainerPos
BUG=471991
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1138993002
|
|
Original Review URL: https://codereview.chromium.org/1129433002
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1122903002
|
|
Not just a simple merge, but changes to remove CFX_Object from XFA.
Original Review URL: https://codereview.chromium.org/1088733002
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1087053002
|
|
|