summaryrefslogtreecommitdiff
path: root/xfa/src/fxfa
AgeCommit message (Collapse)Author
2016-02-26Remove some FX_BOOLsTom Sepez
Grepping for FX_BOOL and |==| on the same line gives a very strong clue that the expression won't be out of range of the |bool| type iteself. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1736323003 .
2016-02-26Replace or remove _FX control-flow definesTom Sepez
They buy us nothing and obfuscate the logic. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1740223002 .
2016-02-25Use std::lower_bound() in a couple places.Lei Zhang
Do some cleanups along the way. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1732223002 .
2016-02-25_XFA_VERIFY_Checksum is always defined.Dan Sinclair
Remove the define and the #ifdef checks. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1741543002 .
2016-02-25Remove fde_mem.hDan Sinclair
The fde_memory.h include wasn't needed. This CL converts the FDE_NewWith and FDE_DeleteWith calls to their FXTARGET_ counterparts. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1736053002 .
2016-02-25Remove fgas.h and IWYU.Dan Sinclair
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1740863002 .
2016-02-25Use std::unique_ptr in CXFA_FMParse.Lei Zhang
R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1740643002 .
2016-02-25Remove fde.h and IWYU.Dan Sinclair
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1735353002 .
2016-02-25Make CXFA_Node::GetMeasure() and friends const.Lei Zhang
R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1735333002 .
2016-02-25Remove set but unsed variables.Lei Zhang
And other nearby dead code. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1740613002 .
2016-02-25Make CFX_PSVTemplate simpler.Tom Sepez
Add default ctor so we don't have to zero these out. Also, make CFX_VTemplate simpler. Also, remove the Set() method in favor of assignment. Also, remove CFX_FloatPoint define. Also, remove unused (and wrong) CFX_VTemplate methods. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1733523003 .
2016-02-25Remove include only fwl.h and IWYU.Dan Sinclair
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1735833003 .
2016-02-24Remove foo != NULL checks in xfa/src/fxfa.Lei Zhang
R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1729983002 .
2016-02-24Remove xfa_common.h and IWYU.Dan Sinclair
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1733693002 .
2016-02-24Fixing whitespace lint errors.Dan Sinclair
This CL enables several of the diabled whitelist/* lint checks. R=thestig@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/1730553002 .
2016-02-23Moar _CAPS work, part 3.Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1730713002 .
2016-02-23Remove uses of this->foo.Lei Zhang
R=weili@chromium.org Review URL: https://codereview.chromium.org/1722913002 .
2016-02-23Remove many _CAPS structure names.Tom Sepez
They're technically not allowed because they are reserved for the preprocessor. Also get rid of LPC* typedefs along the way. Also provide a header for a data file containing many instance of these found along the way. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1722873002 .
2016-02-23Sort includes in xfa/.Dan Sinclair
This CL sorts all the includes in the xfa/ directory. There are a lot of IWYU errors that have been fixed to make things compile again. BUG=pdfium:65 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1722803002 .
2016-02-23Fix a crasher in CXFA_ItemLayoutProcessor::DoLayoutTableContainer()Jun Fang
BUG=pdfium:408 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1719863002 .
2016-02-23Fix a crasher in CXFA_LayoutPageMgr::GetAvailHeight()Jun Fang
BUG=pdfium:407 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1717243002 .
2016-02-23Fix a crasher in CFX_ArrayTemplate::GetAt()Jun Fang
BUG=pdfium:406 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1720743003 .
2016-02-22Switch from _DEBUG to NDEBUG.Lei Zhang
- NDEBUG is more widely used in Chromium - _DEBUG is not defined on Mac in Chromium - Leaving _DEBUG in for standalone debug builds for the benefit of third party libraries / Windows. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1721073004 .
2016-02-23Fix a crasher in ParsePostfixExpression()Jun Fang
BUG=pdfium:409 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1715363002 .
2016-02-22Remove unused stuff from fx_sys.hTom Sepez
Move FX_DOUBLE to fx_system.h to keep it with the others until we remove it. Having one memset/cpy wrapper is dubious, two are worse. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1724523002 .
2016-02-22Define NDEBUG for Release builds.Lei Zhang
Also fix -Wunused warnings as a result of this change. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1717063002 .
2016-02-22Expand XFA includes to be relative to pdfium/.Dan Sinclair
This Cl updates the includes in the XFA directory to be relative to the pdfium/ directory instead of the current directory. This does not sort the includes as that is a larger IWYU task that will be handled separately. BUG=pdfium:65 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1723533002 .
2016-02-22Fixing include guards, and presubmit.Dan Sinclair
This update fixes all include guards so cpplint build/header_guard completes without error. A presubmit check is added to make sure the guards stay clean. BUG=pdfium:65 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1719083002 .
2016-02-19Add a proper bounds check to XFA_FM_KeywordToStringOliver Chang
R=tsepez@chromium.org BUG=588200 Review URL: https://codereview.chromium.org/1718453003 .
2016-02-19Define _DEBUG for debug builds.Lei Zhang
Otherwise ASSERT() is useless. BUG=pdfium:136 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1712053003 .
2016-02-19Revert "Revert "Use safe arithmentic in CFX_BinaryBuf::ExpandBuf.""Tom Sepez
This relands the CL at https://codereview.chromium.org/1710403002 Tests passed locally. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1717603003 .
2016-02-19Revert "Use safe arithmentic in CFX_BinaryBuf::ExpandBuf."Tom Sepez
This reverts commit 78353d5dbc0b0c9b2d6946005439a51efa7d108c. Reason for revert Failed tests. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1719493002 .
2016-02-19Use safe arithmentic in CFX_BinaryBuf::ExpandBuf.Tom Sepez
Always call ExpandBuf(), and if it returns, we know the subsequent calculations won't overflow. Also use std::unique_ptr, and fix unintentional copies thus detected by its suppressed copy ctor in fsdk_baseform.cpp Also Remove unused CFX_BinaryBuf::TakeOver(), AppendFill(), CopyData(). Also remove operator= in favor of using <<, for similarity with std::ostream and friends. Also move ByteStringC methods to CFX_ByteTextBuf sub-class. Also re-order members, may pack tighter on 64-bits. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1710403002 .
2016-02-19Move m_rgPendingNodes off of CFX_PtrList.Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1712913002 .
2016-02-19Remove XFA_DATAMERGE_UPDATEBINDINGRELATIONS_DFSTom Sepez
Doing so removes another CFX_PtrList usage. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1716633002 .
2016-02-19fix crashed in FXJSE_Value_Setjinming_wang
BUG=pdfium:394 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1704813002 .
2016-02-19Fix a crasher in CXFA_Node::Script_Form_Recalculate()Jun Fang
BUG=pdfium:398 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1704343002 .
2016-02-19Fix a crasher in CFDE_TxtEdtDoRecord_Insert::CFDE_TxtEdtDoRecord_Insert()Jun Fang
If a widget is barcode, we should set the data length of barcode as the max length of input string. BUG=pdfium:372 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1703963003 .
2016-02-18Fixup incorrect include guards.Dan Sinclair
This CL updates include guards throughout the code base to be in the chromium style. BUG=pdfium:65 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1707893004 .
2016-02-17Fix some issues with CXFA_FMParse/CXFA_FMLexer infinite looping.chromium/2657chromium/2656chromium/2655Oliver Chang
The parser did not expect an invalid token in some places, leading to an infinite loop. In the lexer, if an invalid string was found, the underlying pointer was never advanced. Also cleans some minor stuff along the way: - Remove nonsensical/useless destructors - Use unique_ptrs for owned members - Remove unused members - Other minor style changes BUG=587620 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1701363003 .
2016-02-17Banish CFX_ByteArray and CFX_WideArray to the XFA side.Tom Sepez
Fix IWYU and include paths as we go. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1701883004 .
2016-02-16IFWL_App::Create() always passed adapter, "fuel" adapter unusedTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1707433002 .
2016-02-09Several pure virtual IFWL_Adapter* classes not implemented.Tom Sepez
The routines that would return them always return NULL. Some path, however, didn't previously check for NULL. Those must have been bugs; treat such cases as unreachable. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1679103002 .
2016-02-08Tidy fpdfsave.cppTom Sepez
Remove CFX_PtrArray filelist. Promote ScopedFileStream to .h file and use it. Fix _CAPS names, bool returns, and put in anonymous namespace. FX_CreateMemoryStream() can't return null, so remove checks. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1672153002 .
2016-02-05Fix heap-use-after-free in CXFA_FFWidget::GetDataAcc()Jun Fang
BUG=pdfium:386 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1680463002 .
2016-02-06Add a parameter checker in CXFA_ScriptContext::QueryNodeByFlag()Jun Fang
BUG=pdfium:380 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1674453004 .
2016-02-04Fix an assertion failure in CXFA_DefFontMgr::GetDefaultFont()Jun Fang
BUG=pdfium:385 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1668813002 . Review URL: https://codereview.chromium.org/1669193002 .
2016-02-04Call CXFA_Object::ToNode() rather than C-style casting.Tom Sepez
The static_casts<> are places where void* pointers are converted. Fix these in a subsequent CL by using a properly typed container. The const_casts<> are places where functions are missing "consts". Fix these in a subsequent CL, too. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1668003003 .
2016-02-03Make CXFA_Data sub-classes ctors explicit.Tom Sepez
Remove implicit CXFA_Node* operator. Add bool() operator. Remove IsExistInXML() which duplicates bool operator. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1663313002 .
2016-02-03Add CFXA_Object helper methods.Tom Sepez
Mark some ctors explicit. Rename GetXFANode to GetXFAObject to match its return type, since it is cast to node in many places. BUG=pdfium:384 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1662063002 .
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-17 08:36:14 +0000