Age | Commit message (Collapse) | Author |
|
Contains additional XFA-specific changes.
Original Review URL: https://codereview.chromium.org/1632143002 .
(cherry picked from commit 66a9dc9dd65ed2b9c7ede448d046b770140f16d5)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1636503006 .
|
|
BUG=pdfium:367
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1620813003 .
|
|
And a few other nits.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1635853002 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1573243003 .
|
|
Small tidying.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1601023004 .
|
|
BUG=pdfium:354
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1580773002 .
|
|
BUG=pdfium:350
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1608593003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1581823002 .
|
|
Inconsisten use of "override".
BUG=pdfium:354
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1577723004 .
|
|
BUG=pdfium:347
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1573893002 .
|
|
BUG=pdfium:348
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1579503002 .
|
|
BUG=pdfium:261
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1570893003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1572393002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1578003002 .
|
|
Fix lint errors along the way.
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567343002 .
(cherry picked from commit 9adfbb0920a258e916003b1ee9515e97879db82a)
Review URL: https://codereview.chromium.org/1577503002 .
|
|
Replaces CFX_CMapByteStringToPtr. XFA still uses CFX_CMapByteStringToPtr
so it's not completely removed just yet.
Adds begin()/end() to CPDF_Dictionary and removes the
GetStartPos()/GetNextElement() functions to traverse the dictionary.
Callers are changed accordingly. AddValue() is also removed.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1541703003 .
(cherry picked from commit 14f39950451bb9c2a11fbc7173fd47367410f80f)
Review URL: https://codereview.chromium.org/1576033002 .
|
|
Also remove useless files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1570743002 .
|
|
The reference count didn't increase when a
computed style object was referred.
BUG=pdfium:281
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1527263002 .
|
|
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1547833002 .
(cherry picked from commit d20dfba2ae10e8aeb328328f09da79ff904110a8)
Review URL: https://codereview.chromium.org/1545183002 .
|
|
BUG=pdfium:333
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1537413002 .
|
|
BUG=pdfium:328
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1538513002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1521163002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1521563002 .
(cherry picked from commit 1956a174020686f91cd3b34294e91f4560fe45aa)
Review URL: https://codereview.chromium.org/1526823002 .
|
|
When some layout items are released, applications should
be notified. It usually happens when there are layout
changes.
BUG=pdfium:303
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1502133002 .
|
|
In some cases, we can use the safe FX_Alloc2D, in others
there's an extra multiplication by the size of the type.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1519233002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1505353009 .
|
|
BUG=none
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1512283002 .
|
|
BUG=pdfium:261
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1500313002 .
|
|
BUG=pdfium:324
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1507683010 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1512423003 .
|
|
Review URL: https://codereview.chromium.org/1513363002 .
(cherry picked from commit f32c969bce6743fca1e7ff796b54a1692d26d7f0)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1519693002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1508883003 .
|
|
BUG=pdfium:306
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1506423002 .
|
|
The proper way to "wide-stringify" a parameter is by L###arg,
not L"## arg ##", which does no replacement. Also remove dubious
CloneToEvent() method, and make the proper event in the one place
it is called.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1510493005 .
|
|
Re-introduce create methods that actually create the
corresponding impl so we don't have ifaces without impls.
Remove per-subclass Initialize() methods.
Remove unused ctors.
BUG=pdfium:282
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1453473002 .
|
|
This reverts commit 5e4f290e939ded90a518ff8eab1db59930655e11.
BUG=
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1502063005 .
|
|
BUG=pdfium:282
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1509203002 .
|
|
This reverts commit 6fa20c60c6ed551af55bfc879668eaac5c237805.
Reason for revert: broke tests
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1507893002 .
|
|
This matches the 3-level parallel hierarchy convention
used elsewhere in FWL. Remove dead code along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1503503003 .
|
|
Uncovered bad casts in a couple of places, replaced with
correct objects.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1503583003 .
|
|
In the process, found two CFWL_ classes that didn't inherit
from the virtual inteface they were allegedly supporting.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1499853003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1500023003 .
|
|
Remove some dead code.
Add missing consts.
Convert some integer expressions to bools for return.
Remove expression (with bad cast) that can't happen.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1496323004 .
|
|
Remove dead code along the way.
BUG=pdfium:300
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1490093006 .
|
|
Add () to suppress gcc-style error about assignment in conditionals.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1491403002 .
|
|
These hide early returns from the casual reader, hide
the inversion of the condition under test from the reader,
prevent the folding of conditions into a single statement,
and take up more characters than the if() itself.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1494683002 .
|
|
Remove duplicate code from 10 places.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1486283002 .
|
|
It's part of the CFWL_*Imp hierarchy, and hence should be
named CFWL_CustomImp. CFWL_Custom would belong to a differnt
hierarchy according to naming conventions.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1491723002 .
|
|
BUG=pdfium:292
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1486573002 .
|
|
BUG=pdfium:281
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1481503002 .
|