Age | Commit message (Collapse) | Author |
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1740633004 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1738983002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735833003 .
|
|
Also fix IWYU in various fxbarcode headers.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1734823002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1729983002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1726373002 .
|
|
Missed one remaining use of FGAS_LPCFONTUSB.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735623003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735663002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1730893003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1731483004 .
|
|
Two files become completely empty and are deleted.
Oddly, they never appeared in gyp/gn files.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1724303002 .
|
|
This header just includes other headers, remove file and callsites.
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1734683002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1733693002 .
|
|
This CL enables several of the diabled whitelist/* lint checks.
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1730553002 .
|
|
Also remove another CFX_ArrayTemplate usage.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1730753002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1730713002 .
|
|
This is just a wrapper for (a) / (b). Inline the divide.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1727793002 .
|
|
This define just multiples the two parameters together. Inline the *'s.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1729613003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1726803002 .
|
|
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1722913002 .
|
|
They're technically not allowed because they are reserved
for the preprocessor.
Also get rid of LPC* typedefs along the way.
Also provide a header for a data file containing many
instance of these found along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1722873002 .
|
|
This CL cleans up the code enabled and disabled by _FDE_BLOCK_BUFFER.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1724793002 .
|
|
We never define _FDEPLUS so all the #ifndef checks can be removed as they will
always be true.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1723693005 .
|
|
We need to pull in the fgas_base.h file before looking at the _FX_OS_ checks
otherwise they become true and windows XFA build fails.
TBR=tsepez@chromium.org
BUG=pdfium:65
Review URL: https://codereview.chromium.org/1725843002 .
|
|
This CL sorts all the includes in the xfa/ directory. There are a lot of IWYU
errors that have been fixed to make things compile again.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1722803002 .
|
|
BUG=pdfium:402
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1719803002 .
|
|
BUG=pdfium:408
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1719863002 .
|
|
BUG=pdfium:407
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1717243002 .
|
|
BUG=pdfium:406
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1720743003 .
|
|
- NDEBUG is more widely used in Chromium
- _DEBUG is not defined on Mac in Chromium
- Leaving _DEBUG in for standalone debug builds for the benefit of
third party libraries / Windows.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1721073004 .
|
|
BUG=pdfium:409
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1715363002 .
|
|
Also remove unused variable in CFWL_FormImpDelegate::OnProcessMessage().
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1717383003 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1723693002 .
|
|
Move FX_DOUBLE to fx_system.h to keep it with the others
until we remove it.
Having one memset/cpy wrapper is dubious, two are worse.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1724523002 .
|
|
Also fix -Wunused warnings as a result of this change.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1717063002 .
|
|
We wouldn't want to imply that any of this is
thread-safe ...
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1724483002 .
|
|
These are not included in the gyp or gn files so they won't be built.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1717403002 .
|
|
This Cl updates the includes in the XFA directory to be relative to the
pdfium/ directory instead of the current directory.
This does not sort the includes as that is a larger IWYU task that will be
handled separately.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1723533002 .
|
|
This update fixes all include guards so cpplint build/header_guard completes
without error.
A presubmit check is added to make sure the guards stay clean.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1719083002 .
|
|
R=tsepez@chromium.org
BUG=588200
Review URL: https://codereview.chromium.org/1718453003 .
|
|
Otherwise ASSERT() is useless.
BUG=pdfium:136
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1712053003 .
|
|
This relands the CL at https://codereview.chromium.org/1710403002
Tests passed locally.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1717603003 .
|
|
This reverts commit 78353d5dbc0b0c9b2d6946005439a51efa7d108c.
Reason for revert Failed tests.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1719493002 .
|
|
Always call ExpandBuf(), and if it returns, we know the
subsequent calculations won't overflow.
Also use std::unique_ptr, and fix unintentional copies thus
detected by its suppressed copy ctor in fsdk_baseform.cpp
Also Remove unused CFX_BinaryBuf::TakeOver(), AppendFill(), CopyData().
Also remove operator= in favor of using <<, for similarity
with std::ostream and friends.
Also move ByteStringC methods to CFX_ByteTextBuf sub-class.
Also re-order members, may pack tighter on 64-bits.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1710403002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1712913002 .
|
|
Use/add CFX_{Byte,Wide}String::FromFoo() instead.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1711893003 .
|
|
Doing so removes another CFX_PtrList usage.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1716633002 .
|
|
BUG=pdfium:394
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1704813002 .
|
|
BUG=pdfium:398
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1704343002 .
|
|
If a widget is barcode, we should set the data length
of barcode as the max length of input string.
BUG=pdfium:372
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1703963003 .
|