summaryrefslogtreecommitdiff
path: root/xfa
AgeCommit message (Collapse)Author
2016-02-01Fix AddressSanitizer: heap-buffer-overflow in ValidateCanonicalTime()Jun Fang
BUG=pdfium:378 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1652933002 .
2016-01-29Merge to XFA: Member function name refactoringWei Li
This is needed by Cl 1634373003 as the name collision with virtual functions will be shown as warnings on Linux. Also, it is better to use different names for different cases. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1644633003 . (cherry picked from commit d45e7a51904164fb22049f0a7a80d2a94c06936b) Review URL: https://codereview.chromium.org/1648233002 .
2016-01-27XFA: Fix checkdeps violations.Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1647613003 .
2016-01-27XFA: Remove dead AddDoRecord code.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1640033002 .
2016-01-26Fix DOS newlinesTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1636873004 .
2016-01-26Merge to XFA: War on #defines, part 1.Tom Sepez
Contains additional XFA-specific changes. Original Review URL: https://codereview.chromium.org/1632143002 . (cherry picked from commit 66a9dc9dd65ed2b9c7ede448d046b770140f16d5) R=thestig@chromium.org Review URL: https://codereview.chromium.org/1636503006 .
2016-01-26Fix SEGV in VerifyUnicode()Jun Fang
BUG=pdfium:367 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1620813003 .
2016-01-25XFA: Fix a bunch of pointless returns.chromium/2637chromium/2636chromium/2635chromium/2634chromium/2633chromium/2632Lei Zhang
And a few other nits. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1635853002 .
2016-01-20Remove CFX_CMapByteStringToPtr usage in XFA.Tom Sepez
R=ochang@chromium.org Review URL: https://codereview.chromium.org/1573243003 .
2016-01-20Remove _FXFA_USEGASFONTMGR_ (always true).Tom Sepez
Small tidying. R=ochang@chromium.org Review URL: https://codereview.chromium.org/1601023004 .
2016-01-20Remove dubious cast in CXFA_ScriptContext::AddJSBuiltinObject()Jun Fang
BUG=pdfium:354 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1580773002 .
2016-01-19Fix an assertion failure in CXFA_FWLTheme::Initialize()Jun Fang
BUG=pdfium:350 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1608593003 .
2016-01-19Resolve fde_xml.h header collisionchromium/2631chromium/2630chromium/2629chromium/2628chromium/2627chromium/2626Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1581823002 .
2016-01-12XFA: Fix compilation warnings introduced at b9bc6b7chromium/2621chromium/2620Tom Sepez
Inconsisten use of "override". BUG=pdfium:354 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1577723004 .
2016-01-12Fix an assertion failure in CFX_RTFBreak::SetLineWidth()Jun Fang
BUG=pdfium:347 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1573893002 .
2016-01-11XFA: Fix memory leakage on LinuxJun Fang
BUG=pdfium:348 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1579503002 .
2016-01-11Clean compiling warnings on LinuxJun Fang
BUG=pdfium:261 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1570893003 .
2016-01-11XFA: Get rid of dead code in an #ifndef FX_FILESIZE block.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1572393002 .
2016-01-11XFA: Fix the Mac build after commit 375a86403b7f.Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1578003002 .
2016-01-11Merge to XFA: Switch most min/max macros to std::min/max.Lei Zhang
Fix lint errors along the way. R=tsepez@chromium.org TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1567343002 . (cherry picked from commit 9adfbb0920a258e916003b1ee9515e97879db82a) Review URL: https://codereview.chromium.org/1577503002 .
2016-01-11Merge to XFA: Use std::map as CPDF_Dictionary's underlying store.Oliver Chang
Replaces CFX_CMapByteStringToPtr. XFA still uses CFX_CMapByteStringToPtr so it's not completely removed just yet. Adds begin()/end() to CPDF_Dictionary and removes the GetStartPos()/GetNextElement() functions to traverse the dictionary. Callers are changed accordingly. AddValue() is also removed. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1541703003 . (cherry picked from commit 14f39950451bb9c2a11fbc7173fd47367410f80f) Review URL: https://codereview.chromium.org/1576033002 .
2016-01-08XFA: Remove many relative includes in xfa/Lei Zhang
Also remove useless files. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1570743002 .
2016-01-07Fix writing to read-only region in CXFA_TextParser::GetHorScale().Jun Fang
The reference count didn't increase when a computed style object was referred. BUG=pdfium:281 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1527263002 .
2016-01-05Merge to XFA: Remove header files that only have includes.Lei Zhang
Also do some cleanups in affected files. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1552583002 . (cherry picked from commit d794d34b5deb6ad691c19af758090f9ce46015a3) Review URL: https://codereview.chromium.org/1566583002 .
2015-12-24Merge to XFA: Switch from nonstd::unique_ptr to std::unique_ptr.Lei Zhang
TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1547833002 . (cherry picked from commit d20dfba2ae10e8aeb328328f09da79ff904110a8) Review URL: https://codereview.chromium.org/1545183002 .
2015-12-22Rename LayoutWidget() to PerformLayout()Jun Fang
BUG=pdfium:333 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1537413002 .
2015-12-18Fix a bug that items can't be selected in list boxesJun Fang
BUG=pdfium:328 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1538513002 .
2015-12-17Remove FDE_Alloc in favor of FX_Alloc.Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1521163002 .
2015-12-14Merge to XFA: Remove FX_BSTRC.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1521563002 . (cherry picked from commit 1956a174020686f91cd3b34294e91f4560fe45aa) Review URL: https://codereview.chromium.org/1526823002 .
2015-12-11Fix a crasher in CXFA_FFDocView::SetFocus()Jun Fang
When some layout items are released, applications should be notified. It usually happens when there are layout changes. BUG=pdfium:303 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1502133002 .
2015-12-11XFA: avoid multiplications in FX_AllocsTom Sepez
In some cases, we can use the safe FX_Alloc2D, in others there's an extra multiplication by the size of the type. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1519233002 .
2015-12-11Fix size calculation in BC_QRCodeWriter.cppTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1505353009 .
2015-12-11Don't pass bogus testing flags to V8Jochen Eisinger
BUG=none R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1512283002 .
2015-12-10Fix compiling warnings on Linux (part2)Jun Fang
BUG=pdfium:261 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1500313002 .
2015-12-10Fix crashing in CFWL_CheckBox::Initialize()Jun Fang
BUG=pdfium:324 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1507683010 .
2015-12-10Convert last batch of casts in fwl.Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1512423003 .
2015-12-10Merge to XFA: Remove CFX_AffineMatrix/CPDF_MatrixTom Sepez
Review URL: https://codereview.chromium.org/1513363002 . (cherry picked from commit f32c969bce6743fca1e7ff796b54a1692d26d7f0) R=thestig@chromium.org Review URL: https://codereview.chromium.org/1519693002 .
2015-12-10Replace more static casts in FWL (part 3)Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1508883003 .
2015-12-09Fix heap-use-after-free in CXFA_PDFFontMgr::~CXFA_PDFFontMgr()Jun Fang
BUG=pdfium:306 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1506423002 .
2015-12-09Fix errors in BEGIN_FWL_MESSAGE_DEF macrosTom Sepez
The proper way to "wide-stringify" a parameter is by L###arg, not L"## arg ##", which does no replacement. Also remove dubious CloneToEvent() method, and make the proper event in the one place it is called. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1510493005 .
2015-12-09FWL refcounts never incremented (part 2).Tom Sepez
Re-introduce create methods that actually create the corresponding impl so we don't have ifaces without impls. Remove per-subclass Initialize() methods. Remove unused ctors. BUG=pdfium:282 R=jun_fang@foxitsoftware.com, thestig@chromium.org Review URL: https://codereview.chromium.org/1453473002 .
2015-12-09Re-land "Rename CFWL_Thread classes to ThreadImp"Tom Sepez
This reverts commit 5e4f290e939ded90a518ff8eab1db59930655e11. BUG= R=thestig@chromium.org Review URL: https://codereview.chromium.org/1502063005 .
2015-12-08FWL refcounts never incremented (part 1)Tom Sepez
BUG=pdfium:282 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1509203002 .
2015-12-07Revert "Rename CFWL_Thread classes to ThreadImp"Tom Sepez
This reverts commit 6fa20c60c6ed551af55bfc879668eaac5c237805. Reason for revert: broke tests TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1507893002 .
2015-12-07Rename CFWL_Thread classes to ThreadImpTom Sepez
This matches the 3-level parallel hierarchy convention used elsewhere in FWL. Remove dead code along the way. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1503503003 .
2015-12-07Remove C-Style casts in severl other fwl_...imp.cpp filesTom Sepez
Uncovered bad casts in a couple of places, replaced with correct objects. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1503583003 .
2015-12-04Remove C-Style casts in fwl_{barcode,caret,checkbox,combobox}imp.cppTom Sepez
In the process, found two CFWL_ classes that didn't inherit from the virtual inteface they were allegedly supporting. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1499853003 .
2015-12-04Remove unused Thread class and static members.Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1500023003 .
2015-12-04Tidy fwl_widgetimp.cpp.Tom Sepez
Remove some dead code. Add missing consts. Convert some integer expressions to bools for return. Remove expression (with bad cast) that can't happen. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1496323004 .
2015-12-04Fix dubious casting in fwl_widgetimp.cpp.Tom Sepez
Remove dead code along the way. BUG=pdfium:300 R=jun_fang@foxitsoftware.com, thestig@chromium.org Review URL: https://codereview.chromium.org/1490093006 .