summaryrefslogtreecommitdiff
path: root/xfa
AgeCommit message (Collapse)Author
2016-02-23Resolve heap-use-after-free in CFX_WideString::~CFX_WideString()Jun Fang
BUG=pdfium:402 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1719803002 .
2016-02-23Fix a crasher in CXFA_ItemLayoutProcessor::DoLayoutTableContainer()Jun Fang
BUG=pdfium:408 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1719863002 .
2016-02-23Fix a crasher in CXFA_LayoutPageMgr::GetAvailHeight()Jun Fang
BUG=pdfium:407 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1717243002 .
2016-02-23Fix a crasher in CFX_ArrayTemplate::GetAt()Jun Fang
BUG=pdfium:406 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1720743003 .
2016-02-22Switch from _DEBUG to NDEBUG.Lei Zhang
- NDEBUG is more widely used in Chromium - _DEBUG is not defined on Mac in Chromium - Leaving _DEBUG in for standalone debug builds for the benefit of third party libraries / Windows. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1721073004 .
2016-02-23Fix a crasher in ParsePostfixExpression()Jun Fang
BUG=pdfium:409 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1715363002 .
2016-02-22Fix return values in CFWL_FormImp::EndDoModal().Lei Zhang
Also remove unused variable in CFWL_FormImpDelegate::OnProcessMessage(). R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1717383003 .
2016-02-22Fix remaining FX_memsets in windowsTom Sepez
TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1723693002 .
2016-02-22Remove unused stuff from fx_sys.hTom Sepez
Move FX_DOUBLE to fx_system.h to keep it with the others until we remove it. Having one memset/cpy wrapper is dubious, two are worse. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1724523002 .
2016-02-22Define NDEBUG for Release builds.Lei Zhang
Also fix -Wunused warnings as a result of this change. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1717063002 .
2016-02-22Remove CFX_ThreadLock (its a no-op)Tom Sepez
We wouldn't want to imply that any of this is thread-safe ... R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1724483002 .
2016-02-22Remove unused fde_gdidevice files.Dan Sinclair
These are not included in the gyp or gn files so they won't be built. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1717403002 .
2016-02-22Expand XFA includes to be relative to pdfium/.Dan Sinclair
This Cl updates the includes in the XFA directory to be relative to the pdfium/ directory instead of the current directory. This does not sort the includes as that is a larger IWYU task that will be handled separately. BUG=pdfium:65 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1723533002 .
2016-02-22Fixing include guards, and presubmit.Dan Sinclair
This update fixes all include guards so cpplint build/header_guard completes without error. A presubmit check is added to make sure the guards stay clean. BUG=pdfium:65 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1719083002 .
2016-02-19Add a proper bounds check to XFA_FM_KeywordToStringOliver Chang
R=tsepez@chromium.org BUG=588200 Review URL: https://codereview.chromium.org/1718453003 .
2016-02-19Define _DEBUG for debug builds.Lei Zhang
Otherwise ASSERT() is useless. BUG=pdfium:136 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1712053003 .
2016-02-19Revert "Revert "Use safe arithmentic in CFX_BinaryBuf::ExpandBuf.""Tom Sepez
This relands the CL at https://codereview.chromium.org/1710403002 Tests passed locally. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1717603003 .
2016-02-19Revert "Use safe arithmentic in CFX_BinaryBuf::ExpandBuf."Tom Sepez
This reverts commit 78353d5dbc0b0c9b2d6946005439a51efa7d108c. Reason for revert Failed tests. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1719493002 .
2016-02-19Use safe arithmentic in CFX_BinaryBuf::ExpandBuf.Tom Sepez
Always call ExpandBuf(), and if it returns, we know the subsequent calculations won't overflow. Also use std::unique_ptr, and fix unintentional copies thus detected by its suppressed copy ctor in fsdk_baseform.cpp Also Remove unused CFX_BinaryBuf::TakeOver(), AppendFill(), CopyData(). Also remove operator= in favor of using <<, for similarity with std::ostream and friends. Also move ByteStringC methods to CFX_ByteTextBuf sub-class. Also re-order members, may pack tighter on 64-bits. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1710403002 .
2016-02-19Move m_rgPendingNodes off of CFX_PtrList.Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1712913002 .
2016-02-19Remove CFX_{Byte,Wide}String::ConvertFrom().Lei Zhang
Use/add CFX_{Byte,Wide}String::FromFoo() instead. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1711893003 .
2016-02-19Remove XFA_DATAMERGE_UPDATEBINDINGRELATIONS_DFSTom Sepez
Doing so removes another CFX_PtrList usage. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1716633002 .
2016-02-19fix crashed in FXJSE_Value_Setjinming_wang
BUG=pdfium:394 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1704813002 .
2016-02-19Fix a crasher in CXFA_Node::Script_Form_Recalculate()Jun Fang
BUG=pdfium:398 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1704343002 .
2016-02-19Fix a crasher in CFDE_TxtEdtDoRecord_Insert::CFDE_TxtEdtDoRecord_Insert()Jun Fang
If a widget is barcode, we should set the data length of barcode as the max length of input string. BUG=pdfium:372 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1703963003 .
2016-02-19Fix an assertion failure in CXFA_FWLTheme::Initialize()Jun Fang
The face names from font file stream may be different with the ones from chromium. Pdfium should save face names from chromium for font mapping when it works in sandbox environment. BUG=pdfium:392 BUG=pdfium:393 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1710753002 .
2016-02-18Fixup incorrect include guards.Dan Sinclair
This CL updates include guards throughout the code base to be in the chromium style. BUG=pdfium:65 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1707893004 .
2016-02-17Fix some issues with CXFA_FMParse/CXFA_FMLexer infinite looping.chromium/2657chromium/2656chromium/2655Oliver Chang
The parser did not expect an invalid token in some places, leading to an infinite loop. In the lexer, if an invalid string was found, the underlying pointer was never advanced. Also cleans some minor stuff along the way: - Remove nonsensical/useless destructors - Use unique_ptrs for owned members - Remove unused members - Other minor style changes BUG=587620 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1701363003 .
2016-02-17Banish CFX_ByteArray and CFX_WideArray to the XFA side.Tom Sepez
Fix IWYU and include paths as we go. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1701883004 .
2016-02-16IFWL_App::Create() always passed adapter, "fuel" adapter unusedTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1707433002 .
2016-02-12One less PI.Tom Sepez
One less Bezier. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1692413002 .
2016-02-09Several pure virtual IFWL_Adapter* classes not implemented.Tom Sepez
The routines that would return them always return NULL. Some path, however, didn't previously check for NULL. Those must have been bugs; treat such cases as unreachable. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1679103002 .
2016-02-08Tidy fpdfsave.cppTom Sepez
Remove CFX_PtrArray filelist. Promote ScopedFileStream to .h file and use it. Fix _CAPS names, bool returns, and put in anonymous namespace. FX_CreateMemoryStream() can't return null, so remove checks. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1672153002 .
2016-02-08Remove CFX_PtrArray from xfa/include/fwlTom Sepez
Fix IWYU in stl_util.h R=thestig@chromium.org Review URL: https://codereview.chromium.org/1672283002 .
2016-02-05Fix heap-use-after-free in CXFA_FFWidget::GetDataAcc()Jun Fang
BUG=pdfium:386 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1680463002 .
2016-02-06Add a parameter checker in CXFA_ScriptContext::QueryNodeByFlag()Jun Fang
BUG=pdfium:380 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1674453004 .
2016-02-05Fix build broken at e059b5ba1260Tom Sepez
TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1671213002 .
2016-02-05Remove CFX_PtrArray from xfa's combobox.h.Tom Sepez
patch from issue 1665243003 at patchset 1 (http://crrev.com/1665243003#ps1) R=thestig@chromium.org Review URL: https://codereview.chromium.org/1669313002 .
2016-02-04Fix an assertion failure in CXFA_DefFontMgr::GetDefaultFont()Jun Fang
BUG=pdfium:385 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1668813002 . Review URL: https://codereview.chromium.org/1669193002 .
2016-02-04Call CXFA_Object::ToNode() rather than C-style casting.Tom Sepez
The static_casts<> are places where void* pointers are converted. Fix these in a subsequent CL by using a properly typed container. The const_casts<> are places where functions are missing "consts". Fix these in a subsequent CL, too. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1668003003 .
2016-02-04Pdfium does not create isolate when it runs in chromiumjinming_wang
BUG=pdfium:373 R=jochen@chromium.org Review URL: https://codereview.chromium.org/1652873003 .
2016-02-03Make CXFA_Data sub-classes ctors explicit.Tom Sepez
Remove implicit CXFA_Node* operator. Add bool() operator. Remove IsExistInXML() which duplicates bool operator. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1663313002 .
2016-02-03Add CFXA_Object helper methods.Tom Sepez
Mark some ctors explicit. Rename GetXFANode to GetXFAObject to match its return type, since it is cast to node in many places. BUG=pdfium:384 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1662063002 .
2016-02-02XFA: Fix a crashier in SetFocus()Jun Fang
BUG=pdfium:374 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1640233004 .
2016-02-01Fix AddressSanitizer: heap-buffer-overflow in ValidateCanonicalTime()Jun Fang
BUG=pdfium:378 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1652933002 .
2016-01-29Merge to XFA: Member function name refactoringWei Li
This is needed by Cl 1634373003 as the name collision with virtual functions will be shown as warnings on Linux. Also, it is better to use different names for different cases. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1644633003 . (cherry picked from commit d45e7a51904164fb22049f0a7a80d2a94c06936b) Review URL: https://codereview.chromium.org/1648233002 .
2016-01-27XFA: Fix checkdeps violations.Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1647613003 .
2016-01-27XFA: Remove dead AddDoRecord code.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1640033002 .
2016-01-26Fix DOS newlinesTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1636873004 .
2016-01-26Merge to XFA: War on #defines, part 1.Tom Sepez
Contains additional XFA-specific changes. Original Review URL: https://codereview.chromium.org/1632143002 . (cherry picked from commit 66a9dc9dd65ed2b9c7ede448d046b770140f16d5) R=thestig@chromium.org Review URL: https://codereview.chromium.org/1636503006 .